From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA82A0350; Mon, 28 Feb 2022 08:58:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F40F341158; Mon, 28 Feb 2022 08:58:15 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id DCA894068A; Mon, 28 Feb 2022 08:58:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646035094; x=1677571094; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=GVrPFOK1saNfjkLRKeqo0WBJzU236ch74xQBEaWXYwY=; b=jmb7gCSPxNolRCPQQlH3UFbuST80UvNNPEjEVEEjypmeMjtqN5RY4bQz Eo7yZYKJGE0wsKlS+JuLTCloU/5syQW9rr0arwCXdGtBuEEzHTczEt25Q rb9YbrjWe5SR04OzWaSsxLppNY7tkoEsGgQ6/mak0VdGZyTulyZ/Fp4D9 AWFwDDh5mEIXBSqs7CFdSaaVmPj4WxAb/3e37GVZ8Nmwr2IBDs/3v/fkp Ze05AD2Y99AaAJmEcbGOqbzgycQCLtVT7cKgRMJwNSykHCSMBrQFAgLJ4 4zMwh9jzH8W31wkc7oPy2WNgWkYk6zrXHCD52SJGztCxD2LBrQdPvI4gV Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10271"; a="253020089" X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="253020089" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2022 23:58:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,142,1643702400"; d="scan'208";a="638909611" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 27 Feb 2022 23:58:12 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 27 Feb 2022 23:58:12 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 27 Feb 2022 23:58:12 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 27 Feb 2022 23:58:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XU94ZYUKAU5rzvbLz9HlzYN3ZuUlII9i9a00bo3KdW7EQm8ItekSvzrvDUZo9nEtCdbLVmVaUVjmO+pfXssr76ObRz2AMpOFzNxLEhj/DEaXqrtnNaLeC0RmQwzmUcVaGHuLcDU2rAvOKoROcG4ncAthyrP/jbifU5WjsjZ8llPOEyJ+HjVyMxgZdzYCn4dRK+oSxDd0peouOau3Yh+rwKSee+QbcGfaOjcAZuReA+zT1RXyVx3tJgCOI7KP/cNOXlF1wICzsuqskWucAhypcrf5jeO8vIaDZ0QWCE/BBoly8qnJKEWER6/wCVdhLjcobDgm2UtnRongOGol8ZMMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=woylOWGkKpjUZt5ZKc8QBiPfMHcnewCNMkEpxX5zLs4=; b=GK1UV47m9fBArmosg4LrKHwpyag1Ukr1QbNUfefd7kom152QPjeq8daY/bq44+7CRID2eAIJmJFaj7Fpadi68PNarIw0eXQHDKqqnMDFwofX9k1hF48xj43oIbCLyleuJzMP8qWKDZtzRAaDkU6h/y0UqMkj8PDsdUN1edft8ZBFL4XZRRas8cUYWAtZuMtg8P20JIcPEPBGqVSkmB/GH0jdQplXi1dVAkI3USCbhJjJvtU1tjuiN3mi4WYD7Vw/jTmFsItHHn20Y0NwoVxNB/nWYdr6qE944dktC1PA3tUeojnmx1wWycTiJwOCGk+QDQT8gPpAIjG07jYkO5fjVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL1PR11MB5477.namprd11.prod.outlook.com (2603:10b6:208:31f::19) by MW4PR11MB5935.namprd11.prod.outlook.com (2603:10b6:303:18a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Mon, 28 Feb 2022 07:58:10 +0000 Received: from BL1PR11MB5477.namprd11.prod.outlook.com ([fe80::edd1:8494:b5bb:3b64]) by BL1PR11MB5477.namprd11.prod.outlook.com ([fe80::edd1:8494:b5bb:3b64%6]) with mapi id 15.20.5017.027; Mon, 28 Feb 2022 07:58:10 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" CC: "stable@dpdk.org" , "Yigit, Ferruh" Subject: RE: [PATCH v5] raw/ifpga: initialize scalar variable before using Thread-Topic: [PATCH v5] raw/ifpga: initialize scalar variable before using Thread-Index: AQHYJvhzj87rk0dXl0mHCOmFa6MD4qyoo7Pw Date: Mon, 28 Feb 2022 07:58:09 +0000 Message-ID: References: <20220221063444.305376-1-wei.huang@intel.com> <20220221075222.306101-1-wei.huang@intel.com> In-Reply-To: <20220221075222.306101-1-wei.huang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6e8aae4b-0de0-4d7f-0b5e-08d9fa901005 x-ms-traffictypediagnostic: MW4PR11MB5935:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yGTCiwAAfOZc+25Gol3yQ3P7O0jvk71fGyp045IeGhGwcEIwug9P/JEr7eTP8eLd8PHlv4KZfl4CioJiQQ+2z5f025G1pPLPE6rH89pSxTZCKF1A1xHj2dxaksaLICVgFLT8kvySOWRBKjB5tzz7cYogOq8etV2Cyw5zZD2H/upSngPBMBN19Yw53T4h8FNdaDoXJnBfvA7HVVzT67tEgDFjn7jFWh/5bjM2x8lstlJd8O5CgB4hZsDtaHhTKiJ7R/zcrTuvpEGTsI7UXuAbD+dAPN0xbqBle5GYzVyIOqrQMpHiifv4k+BGlt2fGYmGcm3zrR0ViCqfWmPhuWTr0bhrn0/mu3Uo/MPCvgJFtlIHwCvAeY8+U7YWRFcev0SgFWy6FRdTVqgo4m4BHkfdZllOE+skoxIgbgrjOn3GG1TK25u4uMbpC3pwh+TTxqK3705/IyWBNzKCMRzr80IN1N8ft9ewmA3/4JLDIoy0wsletLQW0x1EewgNYWnK+hzMNuuVgSLEZufAwDTM1JfeGx6OyuuE1Ki11UsdYjmbayXdHXyvHDio7jtdHdlcMDShqtA6YvjNj/NEYDKNZoNBzgaOyFQttq2pbKknCUlqKtlH7CY1fzYz6h9ZQTlMKiJPQEwZcudbCqrLmk40pxGt8Bcsc+E06L67+7lEqqjbAqkG2p7crw57YTqtwI8n9JXpgEaPPrdPBn3jZvXD+uAlCg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR11MB5477.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(9686003)(122000001)(8936002)(71200400001)(66946007)(66476007)(76116006)(64756008)(4326008)(8676002)(86362001)(66556008)(66446008)(54906003)(82960400001)(38100700002)(33656002)(5660300002)(316002)(55016003)(7696005)(6506007)(52536014)(38070700005)(110136005)(53546011)(26005)(186003)(508600001)(2906002)(83380400001)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n1oE2a50W9ds/xXZUCylOUZ9EvVykXlsXaZlqnsStzfkr4YXaBsHSx8WjBcL?= =?us-ascii?Q?IH1Uis9uEOKVzZTHXxOUjsU0zFHaxkRto05eZAp+o+uaiK/D4MrfedfVoeYb?= =?us-ascii?Q?NyxitXwH/qToUIxflipDtBufqgEDmajjGygN6njNGRhu+tu30TVTVtXLBzgN?= =?us-ascii?Q?0/qrRvXOQvqjdboRPs/XFGVPaxMiaqGUZm7JOxYpDx9r3nTb7y02107upBkq?= =?us-ascii?Q?bLUc9ZZiJiMkWpvMC9Ts/5DNKLLiWVmPmE5zmUZWSe6VWUgLpf7BTjLNgoNZ?= =?us-ascii?Q?aomAG0zaLop+f7DBrkru9rypNiZwau9XY7jS63Joav0IciXMhfZBbmR8MZnP?= =?us-ascii?Q?5CK0JORMJxF3ZoPg3ufQ0QYCgCyfSzdOn2p3d9/Bv+fu6eVLT93GUTl3WrgW?= =?us-ascii?Q?VmwxyPx8WXI+QCbo8r/M6T2JVb3x4s6Px6F5qEE18npH6F2LhJIcQrXQeWhP?= =?us-ascii?Q?hSDbDB7N2ILEa8b+KVVnBpDxqJ6EVo3fg3phKZ49dySpqh4/AD+8SAS9W1Wr?= =?us-ascii?Q?y63I/VBaz2/WB6Vw92k6QCZ/Ckw3kGqwV4OeOEqGRWTmqCwTdQnnXSB009Jg?= =?us-ascii?Q?JUjI2ItnxUdagGefkIu7y/P/CQ5CdmSZ+lNLHeHAc3YjCMfeiQwIvGAoVpIs?= =?us-ascii?Q?qrJ8LwV63gHu7tIGqQ+etj7wt1ZSS063xA7dznpD7OSYqxamuBI0NtrIvW2H?= =?us-ascii?Q?U/XFOOcsvLvfnFzlbOYAj7+NJVDTNurA7C7G5zTN+l70JA1rwuuuJVzlvRa5?= =?us-ascii?Q?N/owUaV/cI8gCyGgJeUYoNK3gG+x51dJmBVieL1I0+2pJ3QkX4DZewPAJpon?= =?us-ascii?Q?01fHlkTg7DcyLstRuA7ShT+ig3UUEdM1nP36+rBjcfchJPBHfwHDoAYikBeQ?= =?us-ascii?Q?VdDCZl4/rfNjMIUMjN6PqbY+6OzcYefr8BGM14TSYa06v5Tbu9cYBBHmzB5c?= =?us-ascii?Q?Y7Fbqt8A/UF7I3bZGbpwpqDKnozbhbDOiF0mFrCCE5dAETdRXdTyUcWU7C90?= =?us-ascii?Q?2VS75wRnlKB1oI28qDN4ZVwTYeBrcMGnwGxijR3Zc2j2DAA2dScr6wANoQ/T?= =?us-ascii?Q?qjyUGi5YF+ahMKyO4y5YvVcN9+ogBwcRvKcmTKZK2RyTExX40vIixGsFbuGH?= =?us-ascii?Q?8Y9KyP3zPB6wegc3M3wcPEIoAdbzZUr7mXxNn2qwUlctTAV/8FxA4t9iVve5?= =?us-ascii?Q?SoJSOd7t3XLerKRHte+Ziz9itjpmx6s8jxkqY+KeBi7i9IcLvg0+YSO7blU1?= =?us-ascii?Q?kIOxHM6/FSXlcBQgxVL+vL9RMThyt7ngJQmQ5GWQ3cla/v6c0fsoLTuWASTR?= =?us-ascii?Q?J/1H7dGnEKuyUscBdgp4Om/P6+cukr6nmv7lg629DyfyodA+0T8/TrCl3Z5z?= =?us-ascii?Q?nryhGwqzqZ9weXvijqJjem95rtN0Fl9I7IEkhPeVAWeKKLIG4/+Yb0DsfT2O?= =?us-ascii?Q?aHZuFL7Q2sV/iJf+vNTRzaUiBEnozYqGleQgaXHIdpKVSH8KvEuLM5dyW/BW?= =?us-ascii?Q?LNGqeCHRF5z+LQoafUA18Z40jwEeTACniZPfI0En7OxJH9/SOMtyvm8w3RHg?= =?us-ascii?Q?o7ur7yZxtbYMinv+WyMSgU/FWJu+fwL7vCGkOoD1F9eE5XaZnmCZmbdJM7dp?= =?us-ascii?Q?BVjcuGmuccgsHtIAvpm/SAE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5477.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e8aae4b-0de0-4d7f-0b5e-08d9fa901005 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2022 07:58:09.8761 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 14NfSgLbs1Ej2SWZ5mEJ1wDYWWRr1hXn/hCOAKrQeWaCCDJ6MZPLSo/FP4deT6M4rE0WzDN7SQpCOcqgVFKLWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5935 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huang, Wei > Sent: Monday, February 21, 2022 3:52 PM > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; nipun.gupta@nxp.com; hemant.agrawal@nxp.com > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, Fer= ruh > ; Huang, Wei > Subject: [PATCH v5] raw/ifpga: initialize scalar variable before using >=20 > Scalar variable sub_brg_bdf may be used uninitialized in function > ifpga_rawdev_fill_info(). It is initialized now in this fix. >=20 > Coverity issue: 375805 > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Huang > --- > v2: add space after comma to meet coding style requirement > --- > v3: refine log > --- > v4: add coverity issue id > --- > v5: use simple initializer > --- > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index b73512d..6beecb7 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -216,7 +216,7 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev > *ifpga_dev, > char dir[1024] =3D "/sys/devices/"; > char *c; > int ret; > - char sub_brg_bdf[4][16]; > + char sub_brg_bdf[4][16] =3D {{0}}; > int point; > DIR *dp =3D NULL; > struct dirent *entry; > -- It looks good for me. Acked-by: Tianfei Zhang > 1.8.3.1