From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15521A0C4C; Tue, 21 Sep 2021 11:05:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 955D64003E; Tue, 21 Sep 2021 11:05:35 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 9136B4003C for ; Tue, 21 Sep 2021 11:05:33 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18KMahle005324; Tue, 21 Sep 2021 02:05:32 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by mx0b-0016f401.pphosted.com with ESMTP id 3b7384hkn9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Sep 2021 02:05:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gVI4ZFCPzFi+dWl10LQMdo0EUREyRNefgE4a3O9ziH+QZ4zigpTkRP7zwvuj1KqqwTOOnWoyeGxxL9QmbArmztaRlrQeHrPQXM7ohtflA37kp9+oaXq0A/c5rw+JpPZHV6PiGpgNN3tUAVrid01zctep1VsGIU+NHB0vvfRgLF16aQC1XY/Ki+1Z/RZcePZD1lQSZJxJy5cfwIfArIGv4x9uXitH5Yu6rroMUVnVZQq5a8RixGV1Hz/rb3pKZuparbOPUxCuzP3lK9E11bz95OW7m9imzOd4KmLoknjFswsLC0FNbSr0Qb3p5WFGtnNHcldyt03pdMlNVuEY56xbAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qDYsha8qrz2qo3yd/PXf3uCtEmQh4GKy+pt9AK5nzDg=; b=iR78ejpjWzry845dYumcm+/ttPnxxoRR/N2S9w428vwqXozuTgk4M4am3iwRAbXyq5qxj/mFDxtgps4Fc/FrzK2J3ILPeqjO1rYQORUvB04gbBr3Rq5OqkPfoN5TCNOazZ5vqdD82UrufX/QaHcqoP3h7mSLkeo0q6nYBY9aLghYZvqcPrzsSTfaH8LSre2XJtiywRfFqh0ZMsDo2u4pLdWATD8vWo+Obt//sMOV2NQfTJTVDX3o51kkRVmzZ1rDcdynNBKDiAkXwbdwkf6ZoB2Xl6pPzwa5DFsJqb1fllmSQa346ol5cNuXC4Jruv65bQNTSDyFfp9f2pVHDBlkIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qDYsha8qrz2qo3yd/PXf3uCtEmQh4GKy+pt9AK5nzDg=; b=JNto91XkPXC0H6Q6DR8E4jdkY9dv9mxttQxwKKEKkhZ3dVgXZJd9GA5EummiMGRqnBxZ08yPnT2ialDMYLFo0x75bXCpjDA5ngmmrAuwD1JIe1sRsHaza4DR22hbyf83A7rkBvZXCwj03+1MDeJuKohp7hw2p4kX45w1Dwl+tko= Received: from BL1PR18MB4197.namprd18.prod.outlook.com (2603:10b6:208:309::16) by MN2PR18MB3309.namprd18.prod.outlook.com (2603:10b6:208:166::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.17; Tue, 21 Sep 2021 09:05:30 +0000 Received: from BL1PR18MB4197.namprd18.prod.outlook.com ([fe80::35c8:850b:ccf8:e387]) by BL1PR18MB4197.namprd18.prod.outlook.com ([fe80::35c8:850b:ccf8:e387%4]) with mapi id 15.20.4544.013; Tue, 21 Sep 2021 09:05:29 +0000 From: Harman Kalra To: Bruce Richardson CC: "dev@dpdk.org" , "ciara.power@intel.com" , Anatoly Burakov Thread-Topic: [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info Thread-Index: AQHXqhea/uKCAEY/v0SOSSuB1EqyL6utHBkAgAEaULA= Date: Tue, 21 Sep 2021 09:05:29 +0000 Message-ID: References: <20210915095336.105635-1-hkalra@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 000048e1-5750-44ee-45a0-08d97cdef5d9 x-ms-traffictypediagnostic: MN2PR18MB3309: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S0vAhWmwfT92rnS9kJxrCFts2c/LR4yUXeB2N38e+Ho3coSPce1BlxbVjJm45G15hPxqsmfL5owFZogsy4LeGVP+fa7jdjyMdkIVh97llSvB4MuvJHBgPES7qnPtv/2ZZxyHCF7m5VNzO05V5QD1lQYYOdChmXJ/bh5VYtA9HaHP3gRy4fEhC2vapRuB2wahKouI5vT7aOa9/Mzzrg4rhfaGiZHLHn2E1arL07DvyIB2SgenqearIMqgQkW8+HwjsszrqlxVVsko1/Fp2dBFMAnYf2nruxuXAFq5cLRV07clDoQeHuEwRRxkrfhFi5NpnThMyq51WeURGfv54bNZWzqJhPxtf2tDS6sjyBv8rtkVFXXJiZk/zEt5WSdr0QfNkcEPE5L8Rgcoxu3Qlwmtr0UG3vIRRmnOmfeBKwbYZW9/4ovsrQ06mV2LlzMC6D47/yIh/j6mn0fjLHmuxgN9OzDNmXohD2ZxD8irT/2G+P+ZuBJm/9v67TCEc0OdtKu6IweQqYRbfFuAn6lxle7CKqnaCjZGptO4kNb8LjfD8FjCEbDoIPLLzXDY1YwO1ThRKEu03b3T7NVzoPtnMl9wIAnCcK7aId6gU7XVjaY95LDGE/X6UgqEGiFlUCL9C8sup3qvUW5cDZaCW9iDokDuTdwohWCBz6Gik1IK7y+ji3Hrv/bYlXNZnWh+SngrwqcyOMscFxgwIhg9yJnpMx64Sg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL1PR18MB4197.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(186003)(508600001)(76116006)(71200400001)(6506007)(66946007)(64756008)(66476007)(66446008)(66556008)(4326008)(316002)(26005)(33656002)(52536014)(7696005)(8936002)(6916009)(122000001)(55016002)(9686003)(38070700005)(38100700002)(54906003)(86362001)(8676002)(5660300002)(83380400001)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C/dny/ICC0cukQrjVuBU9V13VLS8lMRZ0UWQ6PE8SusZzL1dPkA3lhyR3MVt?= =?us-ascii?Q?2L8xyq3ajq+R/mczBW9gfRX/t5E7OKy1LNmDGWESo5QMXutTUk/+jErE4wzA?= =?us-ascii?Q?v2vMgfqJILYtDxDFxL8AAmtf0iwKIsbsM4T5IeyGwToVwq0GDCYV3EH7jPw6?= =?us-ascii?Q?6/W8j2Iswph06svdWl8xABuYBxPLWbVJkJp3KShkKnByD53sfulc4HfxHk9l?= =?us-ascii?Q?hpS8SgTpI3F7+6FBwmFlJ+EOQQpFzNP4JoWaRSJAk8plIHs2mUg5/+1B4qbO?= =?us-ascii?Q?cqH4KZY5J9rAwM55B4HGafhe3yDXGfftJNQcr35a+VTYbEt8WYaDO0sU1VwW?= =?us-ascii?Q?g2DC0WHc0xigavsCNyMeILuVscZKfoe0awoCMXA3Rp8z71zXoD1RIghMJ7cw?= =?us-ascii?Q?z5cxl3NfYzirRAkLtWSyE1P3FMNlyWQT6Y8/LNoa7ft+C3aWTY3OYnq0ltto?= =?us-ascii?Q?f1Sm7qdlfcFlkGAGKjpiNILH88+eu9Ea3kooZuWmpGgCiBXDCEwYdaMywGzI?= =?us-ascii?Q?C2BoQMr57zmZJMqCcEtWI1DcjwlQ1Axpw2UGCcm3FYwWgmDhfqgtQltTgymW?= =?us-ascii?Q?x/8k49LVH/2SBrU62p7ngSrnTa89Z3K/PVgwVW4jJvB8d+Iij0U72e5BagLu?= =?us-ascii?Q?yiIx0qR7plEAVl83LvFvDkiQ+hUGpEPZZ0kLiJS5mcVf91bEN6XtL3rI6tBI?= =?us-ascii?Q?LB6yXeTOf0Em3sESSM4HnYA/+qmBPbsmwqIyoR/SBU8Jmq1bpYARJMX+gToP?= =?us-ascii?Q?6IsXyunQtW3UyPU4Njne4uLvbUzX5YpglMGHMSM+mLzmlb01QDMrpIPQhTPq?= =?us-ascii?Q?nPiiiaqsf0Izkdn1Saje03A5pJumqeFdyrlXxf04/3Rv9QLThRWNpjWehgjJ?= =?us-ascii?Q?VsJ+zHQ7C95sLXlW1MR2E5Y1KyutJKsdlqwbET8ticsbbp1wkt0q9JWI79uV?= =?us-ascii?Q?/Yd/yeYXLzxXh/b10u9wUVFBevI1Q12x9Vta4nlrCkJsbkENIjq4s8QV9V04?= =?us-ascii?Q?rtcmvRCmU7HIqnYj3uV8l2C9RN64nB0U+ddPwTtbIzFSrYs3XwRlTC4PYYX0?= =?us-ascii?Q?sh2SfqXtLy7RFAs39jYWYaRrxSFFvtLopYF6C+k0bj1dPua4K6Ows5NejLtd?= =?us-ascii?Q?JjkTDLizXLbLCNVngJAai7x7CUtKvYIBtgs005FxKRBivn6XT8Xrhzdn7xMq?= =?us-ascii?Q?Pgnt2+Sk/mHddXMSsjmKH0UDFKsiFBEzhkqmomsUVfpt4tC5CH4kGYTJDXr1?= =?us-ascii?Q?kVJTN8E7Q2WLB2cZ4NLqh03HP0ogoDb7bSOlUPZwZ1VLkoCwP0NdgIw32npB?= =?us-ascii?Q?dwdEJ6CcorF+T6qrw/L926pM?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR18MB4197.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 000048e1-5750-44ee-45a0-08d97cdef5d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2021 09:05:29.7468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aNPrhGb/CiHjWFoTn7fmS0uVQaM83EzZT3Dr4hVK9U1TWxHY7UOjOfredLCknDh1sowy/Gdv9tLZzsW+zviVSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3309 X-Proofpoint-GUID: M9fGXTaqKFZDzWpe5JvOB0CLibG-60i_ X-Proofpoint-ORIG-GUID: M9fGXTaqKFZDzWpe5JvOB0CLibG-60i_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-21_01,2021-09-20_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, September 20, 2021 9:27 PM > To: Harman Kalra > Cc: dev@dpdk.org; ciara.power@intel.com; Anatoly Burakov > > Subject: [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Wed, Sep 15, 2021 at 03:23:36PM +0530, Harman Kalra wrote: > > Registering new telemetry callbacks to dump named (memzones) and > > unnamed (malloc) memory information to a file provided as an argument. > > > > Example: > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > > {"version": "DPDK 21.08.0", "pid": 34075, "max_output_len": 16384} > > Connected to application: "dpdk-testpmd" > > --> /eal/malloc_dump,/tmp/malloc_dump > > {"/eal/malloc_dump": {"Malloc elements file: ": "/tmp/malloc_dump"}} > > --> > > --> /eal/malloc_info,/tmp/info > > {"/eal/malloc_info": {"Malloc stats file: ": "/tmp/info"}} > > --> > > --> > > --> /eal/memzone_dump,/tmp/memzone_info > > {"/eal/memzone_dump": {"Memzones count: ": 11, \ "Memzones info file: > > ": "/tmp/memzone_info"}} > > > > Signed-off-by: Harman Kalra > > --- >=20 > For this info, why not just send the data out as telemetry data rather th= an > writing files on the filesystem containing it? If the info is too large t= o dump it > all in a single go, a shortened form could be sent via some form of list = call, > and additional calls could be used to provide more detail on specific ite= ms in > the list. >=20 > Also, this seems more a debugging operation than a telemetry one, though= I > don't have a strong objection to the info being exported as telemetry dir= ectly > (just not via filesystem). >=20 > Regards, > /Bruce Hi Bruce, Thanks for reviewing the patch. I have implemented these telemetry commands as a wrapper which uses existin= g malloc/memzone debug APIs to collect the debug information, these debug APIs are implemented in the way = that they accept a file pointer/stdout. to get the information. As a solution either I should make changes to these debug APIs to accept a= buffer also? Or other way could be get the info dumped into a file, and inside telemetry command parse and convert= the info into json format and send it. But its lot of debug information so will require multiple iterations as you= suggested. But on client (peer) side one will have to again convert json to retrieve the info.=20 Just for my understanding, what drawback do you see in dumping the informat= ion to a file? Because on peer side It is very convenient to read the information from dumped file and use it. Thanks Harman