From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23FA7A0509; Wed, 30 Mar 2022 12:58:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 011C440685; Wed, 30 Mar 2022 12:58:30 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D85334013F for ; Wed, 30 Mar 2022 12:58:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648637909; x=1680173909; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=koZzBdO7M3hGTUxOX0syYpYN1YzlwBLYCg21t7Fn8jw=; b=HnM8ksve7TJeIu1ViO89BUFPs3f+g56LH51YUUBCVcJlmjebz7XxmNAW MWPwWag0D4XnHWalhm+EK3z+W/vDVFRRFVyE3YhWQ4w6E2fB89FcOKgN6 dvNGXoB+lrN/3VpyOu9MDzYO0HRpam/3T3w5Ci3l6IiPFB/8irsKQQOIO JmG14/pr+HsUG0EnsNc12RrG/xMSNw3nGNLcUoGfjZa0eu5cS2aZZzSpP DzFWRWfzIQZZyeLVeQ1ppVBVXIWIJKmYt3GpF3jRHKKCc0jPk1/7tQRmY a7wWoXe673xPEdUaZWsfS9wiRkKdzvqsU8TNQw4VXtKJLn6/wAyvUmbz/ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="284420670" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="284420670" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 03:58:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="546813344" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 30 Mar 2022 03:58:27 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 30 Mar 2022 03:58:26 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 30 Mar 2022 03:58:26 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 30 Mar 2022 03:58:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+j+mdoKmj9r9Oq3T/u9FFy8fQsZXG+xtnwg37662Hpx0TJ4IGRf3a0dJUKu9NSVIijVyV3U6RKuPSVBmv2hagQvaXbSlSrhB5VIFtHXqJbcIuEJm4RsJEp1ysxkWjaRK5d19WsUMRfix6oFr7+dzYqTc+FwwQSOavVBaKTTkQnlEODs0IEjXH1FiO87IBYlkPhTkmjZSVfjzcgrB/1HdhPL1Jey8UnZod/+zCo29q+OfVT/h01D/QPfD1xm9Ew3gKykoS+A2/jPvwRsNDv1uHGLnXqBNMJ2NBS8noh1IkFFF73lJdFEd5LZ9+jqoto7dNues9gPmoC+bRorA4jZpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=631lroqNPg7bJl5NGRHQt0rYfQT2oHr6aE4a+fsQgok=; b=Ma6dwRe3oddu7UPqxjtoW3e8J/6N+JdxmlBZWKUp3h/HyfUMWz4/U+K6oqjJplR2fwPXsnXtWGhD9+7DDldRXJKHLv+ydYlm3GqPqttHdREueTjUbwVYmI1jw0F9hKG8amgpEt3iAlWNleVdWyj7INSLrO7hUpn/Tr1z8hyno4x2AQnb0E818I/Xp9aVWAY2s3JysyjK9YneLbzYT2eYAtrc/pEU8oYuwqwhlNzyx1ENlBJmYD7Pzqh0BJaRgHws6kWOz0igvXRMA1LO/evMoZdUBgIFLtVRJGlVDPBtFFvpvHS0J1TI5eBeXBQfyhRKl6vPCzY5lpIyrm0hPtUOCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL3PR11MB5699.namprd11.prod.outlook.com (2603:10b6:208:33e::8) by SJ0PR11MB5599.namprd11.prod.outlook.com (2603:10b6:a03:3af::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19; Wed, 30 Mar 2022 10:58:25 +0000 Received: from BL3PR11MB5699.namprd11.prod.outlook.com ([fe80::4899:cbb6:3b15:bdc0]) by BL3PR11MB5699.namprd11.prod.outlook.com ([fe80::4899:cbb6:3b15:bdc0%4]) with mapi id 15.20.5123.019; Wed, 30 Mar 2022 10:58:24 +0000 From: "Van Haaren, Harry" To: Shijith Thotton , "dev@dpdk.org" , "jerinj@marvell.com" CC: "pbhagavatula@marvell.com" , Ray Kinsella Subject: RE: [PATCH 1/6] eventdev: support to set queue attributes at runtime Thread-Topic: [PATCH 1/6] eventdev: support to set queue attributes at runtime Thread-Index: AQHYQ26mmHitl78UWES4UDePcz2CK6zXweOg Date: Wed, 30 Mar 2022 10:58:24 +0000 Message-ID: References: <159a14ece2480a3704ee34ee0d81dda331c16957.1648549553.git.sthotton@marvell.com> In-Reply-To: <159a14ece2480a3704ee34ee0d81dda331c16957.1648549553.git.sthotton@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b293d64-89f0-4438-548f-08da123c36c3 x-ms-traffictypediagnostic: SJ0PR11MB5599:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IU9f6V/3d0RcVpyD6qpyCI78UEsRcPWY8ovkJI3Ahe8OH3oi76OCkpZhIQbMh+4QcqpTyoDV9quK4+yRGPGdl7mkDNJQsG0TSppFEIviIDVqrg9/ACGoyCGomcKEOrUVinO2d76tv6XY9LMedXI7+/h5wRxdCWNCDdZ3OuYksID2dFSSwvNc9sUXwCnnRRnhDn4WF4ESB8EaZ9Y2MH+NmTwuInvNYgzDKUlvQR/33XEoK16L0GX81L2ML8D+dQVoEfEwp/EKqaBeTnK2aTnaBgr3s9dyko2RjEhPWoVCAUE3m4Hap7odzsD5TzG07/ESsFvth/gfuinsuyk4hI29xqwLGQuLhD7DA9jWSdvK6EbBTUWw5Y0Xp6TtSAGUafeRmnntN8EU6ueIf9PLDD2V/f4gXlwzBhzgoClM1bF6Yu2Hixs4QnaJQsNSoqZm7hoT/gohYxfziiXov3YV4ovTXdLQ/YNa1sYrGunC3FfmBDRqaNzXHH3AQoYgU8/AHQ0LZ6DtCnYT9bwS8cnOrApZL5vbb70QqhK644at/PUjC2bkbfxx7vLCyCPCArlU+5HRVkTCP5Hi+S3oB3zd/RJntvF/DFBKicHkeg2fFMCKyiVxwm1SrTf1vD427OD0XAgmEECToODHPskqz5mg2GTslZA+S+YtMTAALRJ75vPZDjF1x0xHGpAWSA7aoFX+sKRKblemQR7oaatKq1YFtC334A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL3PR11MB5699.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(110136005)(2906002)(71200400001)(54906003)(316002)(38070700005)(26005)(8936002)(83380400001)(55016003)(82960400001)(52536014)(66946007)(38100700002)(53546011)(86362001)(122000001)(5660300002)(9686003)(4326008)(508600001)(6506007)(7696005)(64756008)(8676002)(186003)(76116006)(66446008)(66476007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+9lhcw63YEB9D8qCVUZxrDM3KTj6/YtJka5GOfhMsikJLC1GUyfS6UKdIayR?= =?us-ascii?Q?v/oAC08U9avYiOByXL8ygV+Ontt1fLGzZ0xgRPXSgnWDCYNu16N3x5QEPim1?= =?us-ascii?Q?HsdSP6yZIG+Fdxz/thfQ94ktvpAzu2PEzyzEZTiNXpdRrMg5H6UShAiYjUY/?= =?us-ascii?Q?GBC9anTgF8DFjBhbCNcaWHhTzXIDdboiP2zyM+KEt9tuqv7RVkKjdboJqgPX?= =?us-ascii?Q?KEHTX1J0d1HiCAoFEH0ThvyYeBfPR7xrjhOmb4KVok7I31asu+IjrHF3DQdJ?= =?us-ascii?Q?U1uirpuIc/Tyt9wQYXv7xO4xS80VnzvMuVsSDr1aHyt4v4qwvCSlPksZYHnK?= =?us-ascii?Q?vuuGy5LxWACbw/sqkLCEirr73jv4tsl3indlQV3I4W0tdED85BpD8hKz0hCu?= =?us-ascii?Q?+69sh3cPDD3oOIPFKWDeyLjEbzs7pV1/zCL+yEH+AQaMYoaJ0wEWt46My3qR?= =?us-ascii?Q?ZqsjoD+wfrbpDRzWV7Rv9KXvTdi/NXs4mgMQDBQQnwlG4wmnvPpwWXYAhlnM?= =?us-ascii?Q?Y5ljMgIWIT5DSjp0uv6vbwGNjukoMNB6QkzkTB2Ml6/xqwTyg8L1e1lOK6Vj?= =?us-ascii?Q?+S/DoTIOQcrPh2LvCJ3hYj1tQcMndBmPqx+bABrYbNtpUHRQtTBzDvNueE6d?= =?us-ascii?Q?ZigkmxJHE3FBcFSbRxhiPfMGsh2zkxCGj7MlEHPvIgEwRfvrjYUfxMiPG0Zd?= =?us-ascii?Q?6uvAzom/ATNE/1ytVWPitRZ8AYO2VhCjEs6CGtGWfmpr0yum5f12828EXZT+?= =?us-ascii?Q?R5WBSbrw4FTpSjTzzKxn8YFo4DMXNwPfF9BaJpkF0ZpBI2aREbJq3BY5WWfK?= =?us-ascii?Q?yMX44Zrvm8JD/a+wEZEXGuBNXvcLyjLA0aPxPWKTIFr5/3v7zfukvACTFzsi?= =?us-ascii?Q?4+72TZ9pWGO1Fa3/nFQkXOO3OhM2aq7BU6wLaxD3MTzd486i9vhGNdRaxmFn?= =?us-ascii?Q?UePi3iSNzItGL3nh/VYYa0IrOUPOIoZeyPOxpv0tB74DJTORNsffrE4QOCbY?= =?us-ascii?Q?/li5zd8SVdFktaw5fmHFkVWb5PdJSP3cdbTzrsVL6uBQ5+K+GCuZu5H4h1Rz?= =?us-ascii?Q?WA/lgIed1NtrOMLG4YFU/mvPeAbh+K4SAjckysuGxiFoBm8s1aRSk1f3bvi2?= =?us-ascii?Q?TUEOymjQLRCJYdaUrWHB9q5s1H6ZVTIm3HvwAgjBYWN/38e+vmp6mvl1Jumd?= =?us-ascii?Q?eEmmgK5fOnAVS4AW3fw8Y/LRJqcjHJfpVn+P0OLH69inF5rS/RoXweBHrcwy?= =?us-ascii?Q?43lwrVBz7N/NwMuGBrG9uyuKDJ2u5mp48n3JJ5p6ln3tWSGmuc+QPwJE+MX0?= =?us-ascii?Q?7VKXsDOjuR/MNobd/m0+ANWX08y4PBliaYawBOPNp+aoaD3DT22qxbwr83YN?= =?us-ascii?Q?WiGyPNNvQC7bMREQ3RJEoXUGN6B2r+dXIb21uU1FHHf7Sq4tUnGOFYvBOhav?= =?us-ascii?Q?TXd39lrIr2IyGghqBZc3aXiZum4eRANZ/P2OPMJ+Vvb/rSYfMpdmYlSW+xnq?= =?us-ascii?Q?2GdOc+CgqvAS7299derdNj5YyfDu7t7OKTTC8GS24BMBCXftf6ID/MnO+Zvx?= =?us-ascii?Q?PbZ1ftPFl0UIqxSDR6EIbh4Lx2JNusAThpDSeF2vDWpvFsW8B1QS/CuFB42K?= =?us-ascii?Q?8h8pr0yLmG85jh5cYVxzgRpgoXRPdkoghMkdE0CWB6mIFVEHriQLOz5IDyNd?= =?us-ascii?Q?RUCqt/3U/ay099mUGTQmgk0ZY4XZKVDjUSgQDniiFG9KYXOEs5r+bU2slHKx?= =?us-ascii?Q?bsetvcpKd9oxBw91hZfJjbVeEXEtm0E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5699.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b293d64-89f0-4438-548f-08da123c36c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2022 10:58:24.8090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zqS89s1csrTBCJbh0t5NokDZMOv6pxXNHZoOsDCRqyLmnFOhyRzzwjsfo36kA1tuWunykPUyBAxHQ0aVIAfnUNCtigaCm2t+v14G5Fw+Jns= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5599 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Shijith Thotton > Sent: Tuesday, March 29, 2022 2:11 PM > To: dev@dpdk.org; jerinj@marvell.com > Cc: Shijith Thotton ; pbhagavatula@marvell.com; Ray > Kinsella > Subject: [PATCH 1/6] eventdev: support to set queue attributes at runtime > +/** > + * Set an event queue attribute at runtime. > + * > + * @param dev > + * Event device pointer > + * @param queue_id > + * Event queue index > + * @param attr_id > + * Event queue attribute id > + * @param attr_value > + * Event queue attribute value > + * > + * @return > + * - 0: Success. > + * - <0: Error code on failure. > + */ > +typedef int (*eventdev_queue_attr_set_t)(struct rte_eventdev *dev, > + uint8_t queue_id, uint32_t attr_id, > + uint32_t attr_value); Is using a uint64_t a better type for attr_value? Given there might be more= in future, limiting to 32-bits now may cause headaches later, and uint64_t doesn't cos= t extra? I think 32-bits of attr_id is enough :) Same comment on the _get() API in patch 2/6, a uint64_t * would be a better= fit there in my opinion.