DPDK patches and discussions
 help / color / mirror / Atom feed
From: WangDong <dong.wang.pro@hotmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] ixgbe:Add write memory barrier for recv pkts.
Date: Sat, 11 Apr 2015 23:33:35 +0800	[thread overview]
Message-ID: <BLU436-SMTP1791A6BD70260D97089EDBFBFF90@phx.gbl> (raw)

Like transmit packets, before update receive descriptor's tail pointer, rte_wmb() should be added after writing recv descriptor.

Signed-off-by: Dong Wang <dong.wang.pro@hotmail.com>
---
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index 9da2c7e..d504688 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
@@ -1338,6 +1338,9 @@ ixgbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 		 */
 		rx_pkts[nb_rx++] = rxm;
 	}
+
+	rte_wmb();
+
 	rxq->rx_tail = rx_id;
 
 	/*
@@ -1595,6 +1598,8 @@ ixgbe_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 		first_seg = NULL;
 	}
 
+	rte_wmb();
+
 	/*
 	 * Record index of the next RX descriptor to probe.
 	 */
-- 
1.9.1

             reply	other threads:[~2015-04-11 15:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-11 15:33 WangDong [this message]
2015-04-14 22:50 ` Ananyev, Konstantin
2015-04-15 13:46   ` Dong.Wang
2015-04-15 16:06     ` Stephen Hemminger
2015-04-16 11:29       ` Wang Dong
2015-04-15 22:52     ` Ananyev, Konstantin
2015-04-16 11:36       ` Wang Dong
2015-04-16 15:14         ` Ananyev, Konstantin
2015-04-16 15:55           ` David Marchand
2015-05-05 15:52           ` Dong Wang
2015-04-16 15:55 Dong Wang
2015-04-16 15:58 Dong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU436-SMTP1791A6BD70260D97089EDBFBFF90@phx.gbl \
    --to=dong.wang.pro@hotmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).