DPDK patches and discussions
 help / color / mirror / Atom feed
From: WangDong <dong.wang.pro@hotmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] eal:Introduce rte_dma_wmb/rte_dma_rmb.
Date: Sun, 28 Jun 2015 23:23:17 +0800
Message-ID: <BLU436-SMTP81994005EFD015E8B339BDBFAB0@phx.gbl> (raw)

These macro can be used to replace current PMD's compiler memory barrier (volatile varible) and rte_wmb.
In x86, they implement to compiler memory barrier.
In power, they implement to processor memory barrier.

---
 .../common/include/arch/ppc_64/rte_atomic.h        |  4 ++++
 .../common/include/arch/x86/rte_atomic.h           |  4 ++++
 lib/librte_eal/common/include/generic/rte_atomic.h | 25 ++++++++++++++++++++++
 3 files changed, 33 insertions(+)

diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
index fb7af2b..8f4129d 100644
--- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
@@ -72,6 +72,10 @@ extern "C" {
  */
 #define	rte_rmb() {asm volatile("sync" : : : "memory"); }
 
+#define rte_dma_wmb() {asm volatile("sync" : : : "memory"); }
+
+#define rte_dma_rmb() {asm volatile("sync" : : : "memory"); 
+
 /*------------------------- 16 bit atomic operations -------------------------*/
 /* To be compatible with Power7, use GCC built-in functions for 16 bit
  * operations */
diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic.h b/lib/librte_eal/common/include/arch/x86/rte_atomic.h
index e93e8ee..7cfbe8f 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_atomic.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_atomic.h
@@ -53,6 +53,10 @@ extern "C" {
 
 #define	rte_rmb() _mm_lfence()
 
+#define rte_dma_wmb() rte_compiler_barrier()
+
+#define rte_dma_rmb() rte_compiler_barrier()
+
 /*------------------------- 16 bit atomic operations -------------------------*/
 
 #ifndef RTE_FORCE_INTRINSICS
diff --git a/lib/librte_eal/common/include/generic/rte_atomic.h b/lib/librte_eal/common/include/generic/rte_atomic.h
index 6c7581a..a51eeee 100644
--- a/lib/librte_eal/common/include/generic/rte_atomic.h
+++ b/lib/librte_eal/common/include/generic/rte_atomic.h
@@ -72,6 +72,31 @@ static inline void rte_wmb(void);
  */
 static inline void rte_rmb(void);
 
+/**
+ * Write memory barrier for DMA.
+ *
+ * Be used in PMD, unlike rte_wmb() which use processor memory barrier,
+ * this memory barrier focus on performance, if compiler memory barrier
+ * is sufficient for guarantee memory ordering, this function will
+ * use compiler memory barrier.
+ *
+ * This function is architecture dependent.
+ */
+static inline void rte_dma_wmb(void);
+
+/**
+ * Read memory barrier for DMA.
+ *
+ * Be used in PMD, unlike rte_rmb() which use processor memory barrier,
+ * this memory barrier focus on performance, if compiler memory barrier
+ * is sufficient for guarantee memory ordering, this function will
+ * use compiler memory barrier.
+ *
+ * This function is architecture dependent.
+ */
+static inline void rte_dma_rmb(void);
+
+
 #endif /* __DOXYGEN__ */
 
 /**
-- 
2.1.0

             reply	other threads:[~2015-06-28 15:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-28 15:23 WangDong [this message]
2015-07-02 15:51 ` Ananyev, Konstantin
2015-07-06 15:48   ` Wang Dong
2015-07-02 16:51 ` Ananyev, Konstantin
  -- strict thread matches above, loose matches on Subject: below --
2015-06-28 15:19 WangDong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLU436-SMTP81994005EFD015E8B339BDBFAB0@phx.gbl \
    --to=dong.wang.pro@hotmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git