From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0051.outbound.protection.outlook.com [104.47.41.51]) by dpdk.org (Postfix) with ESMTP id DFAFFCF7A for ; Tue, 28 Mar 2017 23:18:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E8MmQlD5d59RmPSVfbfb6WnI2y+OF0UXuniStaEW+cg=; b=dp0ogsP5s3YA00Ks836fqCkQ3+MDWQob/UrpP2zTT/b4Qx1lZtwMJVNfAEQwuKqs/7Kn3nuQbaC7BJlD5TMkI+YTgvZ0h/PcXK/n2tNUN/hh2ZyLmgYIVW/vnzUJUvS8IMqiQJ6CLHfeSkypsbL5TC7DcoilBe3CGefIs2ypDus= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1569.namprd07.prod.outlook.com (10.163.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Tue, 28 Mar 2017 21:18:15 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0991.020; Tue, 28 Mar 2017 21:18:15 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs Thread-Index: AQHSp7Wk/j3EvJsHcEqyYrDAoyz5VaGqmOBA Date: Tue, 28 Mar 2017 21:18:14 +0000 Message-ID: References: <798af029-9a26-9065-350b-48781c1d3c55@intel.com> <1490683952-24919-32-git-send-email-rasesh.mody@cavium.com> <575911f6-467b-4153-1ac3-a452989a8ce5@intel.com> In-Reply-To: <575911f6-467b-4153-1ac3-a452989a8ce5@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1569; 7:zjAPSviMg1gCOhTV0XDOfQFtIIEEYeeZf4WVkZHMDGKE1C+qdQHB6r1GcT/PX5siNOhRpn5LhCpmhKKq20EFNTSMQSoQZFlpfIognsre9gz46l+pmiecfMfbBj+sGIjnV3TWrhMrpXdBXWht2J0C0doFpykjGnGHooNhfF/6uVoGBKOJ0PkxGSs0kOJNx0/OnesvKGxDzgMtw0YvTD9gD2WSi7Y9HRnItGMsLIJc5rnyPvKvAOVqwtHlaih25MTFcWx/UtuKqiTQelnDpRp0wZDMpUuwuoQWxOdySlmivqs3x541IKr37JYNlDUZVmAXgKX3AR6nmoPJRIhC9vgufw== x-ms-office365-filtering-correlation-id: 224594d4-c901-4bce-e053-08d4761ff276 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423066)(201703031133072)(201702281549066); SRVR:BLUPR0701MB1569; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040441)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(201703131423066)(201702281528066)(201703061421066)(201703061406066)(20161123562025)(20161123564025)(20161123558025)(20161123555025)(20161123560025)(6072148); SRVR:BLUPR0701MB1569; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1569; x-forefront-prvs: 0260457E99 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39450400003)(39400400002)(39850400002)(39410400002)(24454002)(76104003)(377454003)(102836003)(3846002)(6116002)(6506006)(3280700002)(2950100002)(2906002)(3660700001)(74316002)(38730400002)(77096006)(86362001)(4326008)(189998001)(5660300001)(7696004)(33656002)(25786009)(7736002)(53546009)(66066001)(229853002)(81166006)(55016002)(2501003)(6436002)(6246003)(305945005)(9686003)(99286003)(2900100001)(122556002)(8936002)(50986999)(76176999)(54356999)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1569; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2017 21:18:14.8992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1569 Subject: Re: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 21:18:18 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, March 28, 2017 4:23 AM >=20 > On 3/28/2017 7:52 AM, Rasesh Mody wrote: > > Revise tunnel APIs/structs. > > - Unite tunnel start and update params in single struct > > "ecore_tunnel_info" > > - Remove A0 chip tunnelling support. > > - Added per tunnel info - removed bitmasks. > > > > Signed-off-by: Rasesh Mody >=20 > I hate to say this, but this patch gives build error with clang [1], it s= eems it is > fixed in next patch. We also observed this error on clang, however, the fix got wrongly applied = to the next patch, sorry about that. >=20 > This patchset is big, and takes time to review / validate it, and a small= error > requires whole patchset done again. I am not suggesting updating this one= , > but for further patchsets, what do you think making multiple smaller > patchsets? Please let us know if we need to refresh the current v4 patchset to address= the clang issue. It's good suggestion, for further patchsets, we can do multiple smaller pat= chsets. Thanks! -Rasesh >=20 > Thanks, > ferruh >=20 >=20 > [1] > Building x86_64-native-linuxapp-clang ... > .../drivers/net/qede/base/ecore_sp_commands.c:141:25: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->vxlan.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:143:26: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->l2_gre.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:145:26: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->ip_gre.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:147:29: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->l2_geneve.tun_cls =3D type; > ~ ^~~~ > .../drivers/net/qede/base/ecore_sp_commands.c:149:29: error: implicit > conversion from enumeration type 'enum tunnel_clss' to different > enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum-conversion] > p_tun->ip_geneve.tun_cls =3D type; > ~ ^~~~ > 5 errors generated. > make[10]: *** [base/ecore_sp_commands.o] Error 1 > make[10]: *** Waiting for unfinished jobs.... > .../drivers/net/qede/qede_ethdev.c:1724:45: error: variable 'p_tunn' is > uninitialized when used here [-Werror,-Wuninitialized] > rc =3D ecore_sp_pf_update_tunn_cfg(p_hwfn, p_tunn= , > ^~~~~~ > .../drivers/net/qede/qede_ethdev.c:1711:34: note: initialize the variable > 'p_tunn' to silence this warning > struct ecore_tunnel_info *p_tunn; > ^ > =3D NULL > .../drivers/net/qede/qede_ethdev.c:1877:5: error: variable 'p_tunn' is > uninitialized when used here [-Werror,-Wuninitialized] > p_tunn, ECORE_SPQ_MODE_CB, NULL); > ^~~~~~ > .../drivers/net/qede/qede_ethdev.c:1822:34: note: initialize the variable > 'p_tunn' to silence this warning > struct ecore_tunnel_info *p_tunn; > ^ > =3D NULL > 2 errors generated.