From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0064.outbound.protection.outlook.com [104.47.41.64]) by dpdk.org (Postfix) with ESMTP id E5F05914; Mon, 6 Mar 2017 21:02:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=y4xmOA2/s69O6Sw6q50PieVInEg0C7YzHnVVVBdY8tc=; b=DgHYotMf/N/np4rhqvinXqOcKbY9hL2x6iv/35nFrj++pGIQe4c50h6SoaYRmUei8DFMstaBJrWUIv7vk8ajx5pxg/0a3W5hG76TRptlVdPkdtQO1ATK87kUyWMTwg/0fpuKsDucNmu4kqFkynFkdVjZ009hVhHnbMDEYkwsScA= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Mon, 6 Mar 2017 20:02:48 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0947.018; Mon, 6 Mar 2017 20:02:48 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev , dpdk stable Thread-Topic: [dpdk-dev] [PATCH 01/21] net/qede/base: fix incorrect typecasting of flag Thread-Index: AQHSkM5nasMQVRGOdECYjDf7x0XCdaGBiVSAgAa4PDA= Date: Mon, 6 Mar 2017 20:02:47 +0000 Message-ID: References: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> <2152c44b-3013-b709-16c0-cdef9c20fce2@intel.com> In-Reply-To: <2152c44b-3013-b709-16c0-cdef9c20fce2@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 5de82652-de9b-4d9f-987f-08d464cbc31d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1572; x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1572; 7:UJvBE9iSTvVqxTe/aEfsvUZ/Xgr4Ep/Wrshf1Mb/qVlEAP2FQwnJSopeXoaGleAgZhu/qi0VSiFvkZyFrq972KLjHxXObcAe8M2YpkjpuYfRkzfkg7yW9WFwzciVqKDZmXqx3FEAiWiwclGGkKv8iKB1snE8cCmcd8VMfK8RpBhgV7iIQ7xNfaSqkfw4/a5G3kyJF9nx9JfAgqNtlVIqM81YUUfozpfTVHzhnngDdT0+pA5emh4fwSKqLS82KVGZuQpu9Kj4zDwUm6AD6xYTAZmZx5+X4J5icSbP+6VUviE7yeTIoFSbth3SNTP+ObMpIhrIMtLqYRBa+9GMh4hIEg== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(6072148); SRVR:BLUPR0701MB1572; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1572; x-forefront-prvs: 0238AEEDB0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(377454003)(24454002)(6116002)(66066001)(102836003)(81166006)(54906002)(6506006)(3846002)(2950100002)(54356999)(25786008)(55016002)(8676002)(9686003)(77096006)(6436002)(2501003)(86362001)(229853002)(106116001)(5660300001)(33656002)(345774005)(3280700002)(3660700001)(8936002)(50986999)(76176999)(7736002)(7696004)(122556002)(305945005)(92566002)(4326008)(2900100001)(189998001)(2906002)(6246003)(74316002)(38730400002)(53546006)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1572; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2017 20:02:47.8999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1572 Subject: Re: [dpdk-dev] [PATCH 01/21] net/qede/base: fix incorrect typecasting of flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 20:02:50 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Thursday, March 02, 2017 5:04 AM >=20 > On 2/27/2017 7:51 AM, Rasesh Mody wrote: > > dcbx-update-flag is incorrectly converted to boolean before assigining > > it to ramrod data, fix this typecasting. Also, added more debug > > messages in the dcbx code paths. > > > > Fixes: 26ae839d06e9 ("qede: add DCBX support") > > > > Signed-off-by: Rasesh Mody > > --- > <...> >=20 > Not to this patch, but for the whole patchset, thank you for splitting fi= xes into > small chunks, this makes review easier. >=20 > And for patches you want them in stable tree, please > - CC those patches to stable mail list (stable@dpdk.org) > - and add a new tag in commit log just below "Fixes: " line, like: Thanks for the feedback. We'll address this and rest of the feedback on thi= s patch set in v2 series submission. >=20 > " >=20 > Fixes: xxxxxxxxxxxx ("...") > Cc: stable@dpdk.org >=20 > Signed-off-by: .... > Acked-by: .... > "