From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0062.outbound.protection.outlook.com [104.47.40.62]) by dpdk.org (Postfix) with ESMTP id 335C2330D; Thu, 4 May 2017 02:14:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uwVNoOnHtKHFSKpz4ZFLM/dUrejd1nDmtDHLObudN/I=; b=BEuq7QMW759G78SVlFj+qVVMATtMEXJgrNhRjKosMtcFSFZRKFCmIQAGsOXDWIoSf3GU8ZWUulyBhO5cQieYvtgfh8/tF2nyoZkAJ3qr1CLMCaSuEFIoU1G1LCCWkjiMw/ajTMJFavH6vbILsGCWAF8pyVThP465E8QL7VwEAZI= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1570.namprd07.prod.outlook.com (10.163.84.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Thu, 4 May 2017 00:14:30 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.1075.010; Thu, 4 May 2017 00:14:30 +0000 From: "Mody, Rasesh" To: Yuanhan Liu CC: "dev@dpdk.org" , Dept-Eng DPDK Dev , "stable@dpdk.org" , Ferruh Yigit , Thomas Monjalon Thread-Topic: [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files Thread-Index: AQHSvZWuiejF3cX2kUS5aELX8XzxEaHgm9CAgAK+b7A= Date: Thu, 4 May 2017 00:14:30 +0000 Message-ID: References: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> <1493105326-31984-11-git-send-email-rasesh.mody@cavium.com> <20170502061527.GB3005@yliu-dev.sh.intel.com> In-Reply-To: <20170502061527.GB3005@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.intel.com; dkim=none (message not signed) header.d=none; linux.intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1570; 7:t8nE9TxabUyL5GxRnWDCEa/S+3Xn4lpxn4+UgI1zC/rWZfuuru0voV/6jXUlhJj4W1k3mZcxXPLGal7SQORjj8l/2/9rwHE9tCXEjBOBg+8mZa1/ututhdnDqsVNp8e2gCXsAr+/LN2Yf14EX+LcDv9jibe29BfFEdWxWfuydodeyJTsiTdN3JZM94SWLOCbRbwgt8bk5h4Un598rGukQia+UF3+3vwTbFYlmTvBDYerQT1UCbza9QTvYJ11LRs7si4l9NPwAmhO6B0r5d2nLX6vEYE2Nwzp96INf+9waFNZzHa7ln6r5fh5ph9fT+2H4KJk7PFf9M49GHgtPa5hQQ== x-ms-office365-filtering-correlation-id: 507731e3-7e7d-4e4b-1e0f-08d4928288f9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0701MB1570; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(6072148); SRVR:BLUPR0701MB1570; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1570; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39850400002)(39450400003)(39410400002)(39840400002)(377454003)(24454002)(33656002)(2900100001)(2950100002)(6916009)(54356999)(50986999)(76176999)(8676002)(8936002)(81166006)(229853002)(305945005)(7736002)(74316002)(66066001)(478600001)(5660300001)(7696004)(122556002)(6506006)(77096006)(6246003)(189998001)(38730400002)(110136004)(6436002)(2906002)(86362001)(53936002)(54906002)(3846002)(4326008)(55016002)(102836003)(3660700001)(25786009)(99286003)(9686003)(6116002)(3280700002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1570; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2017 00:14:30.4391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1570 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 May 2017 00:14:34 -0000 > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Monday, May 01, 2017 11:15 PM >=20 > On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote: > > From: Rasesh Mody > > > > Changes included in this fix > > - limit CFLAGS to base files > > - fix to remove/mark unused members > > - add checks for debug config option > > - make qede_set_mtu() and qede_udp_dst_port_del() static and others > > non-static as appropriate > > - move local APIs qede_vlan_offload_set() and > > qede_rx_cqe_to_pkt_type() > > - initialize variables as required >=20 > When there are so many items in one single patch, it basically means it's > done wrongly. Generally, we should make one patch for each item. >=20 > > Fixes: ec94dbc57362 ("qede: add base driver") > > Cc: stable@dpdk.org >=20 > It's also not a good idea to put "Cc: stable" tag in a huge fix patch. > It's very likely it won't apply cleanly to a stable/LTS release. For inst= ance, I > failed to apply it to 16.11.2 (LTS). >=20 > > > > Signed-off-by: Rasesh Mody > > --- > > drivers/net/qede/Makefile | 32 ++++----- > > drivers/net/qede/base/ecore.h | 4 +- > > drivers/net/qede/base/ecore_int_api.h | 4 +- > > drivers/net/qede/qede_ethdev.c | 120 ++++++++++++++++++-------= - > ------- > > drivers/net/qede/qede_ethdev.h | 32 ++++----- > > drivers/net/qede/qede_fdir.c | 13 +--- > > drivers/net/qede/qede_if.h | 4 ++ > > drivers/net/qede/qede_main.c | 8 +-- > > drivers/net/qede/qede_rxtx.c | 118 +++++++++++++++++--------= ----- > -- > > 9 files changed, 171 insertions(+), 164 deletions(-) >=20 > It's also a clear sign of bad patch: too many changes for a single bug fi= x patch. >=20 > Most of them look like minor fixes to me. So my question is are there any > important items really should be picked for stable and LTS release? > More specifically, do they really fix any (fatal) issues? If no, I will d= rop it. If > yes, please send a (or some) patch with the real fixes backported only to > stable ML, so that I could pick them. The patch is a Makefile change to restrict the CFLAG only to the base files= . Once Makefile was changed it exposed few issues with PMD. Hence, we thoug= ht of putting all the changes in single patch since they were relevant chan= ges. As you stated most of them are minor fixes. We'll evaluate the patch if any= thing specifically need to go into the stable release and get back.=20 Thanks! -Rasesh >=20 > Thanks. >=20 > --yliu