From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id CBF30282; Sun, 7 May 2017 07:15:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CXZO6gOHI5wIO4K99LzIWSGhyiGrhV8PN1HGhxlJ3SA=; b=EQM14oQe3ZSkcMypQJpDglGtAsJyP7NP+km5qtRELrLXC6LYk9G3U8qAWGXiHW+e3nWKzo51e9UodOr36bj90reEqSykUYwokshdK8tKndDgN3iOHUCT42EexvVPZ38DM31TuISrjzyQQFJ+QK8f5taF2Ihg/qTMP0/YLN4Ui+g= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1569.namprd07.prod.outlook.com (10.163.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Sun, 7 May 2017 05:15:47 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.1075.019; Sun, 7 May 2017 05:15:47 +0000 From: "Mody, Rasesh" To: Yuanhan Liu CC: "dev@dpdk.org" , Dept-Eng DPDK Dev , "stable@dpdk.org" , Ferruh Yigit , Thomas Monjalon Thread-Topic: [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files Thread-Index: AQHSvZWuiejF3cX2kUS5aELX8XzxEaHgm9CAgAK+b7CAACIAgIAA+uRA Date: Sun, 7 May 2017 05:15:47 +0000 Message-ID: References: <1493105326-31984-1-git-send-email-rasesh.mody@cavium.com> <1493105326-31984-11-git-send-email-rasesh.mody@cavium.com> <20170502061527.GB3005@yliu-dev.sh.intel.com> <20170504021115.GD3005@yliu-dev.sh.intel.com> In-Reply-To: <20170504021115.GD3005@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.intel.com; dkim=none (message not signed) header.d=none; linux.intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1569; 7:Z6CQ0ikRWW1zN7BB68NzDSwILuPAXbhvt8pEow75oCGPuuLSwp4yZsfoBaYXByv4wqSAdEjAsbvV3q1iaMQarYi9Jmz3YNCI70DK7H5HKHt+LoYP5XVt64hrbQdrd+woYyFFXRq0d8BcFZMofvJ22cUh69tSQ2aIDrXfxT9BieeXguon1bs9fn6t9yHMpw3C3k4G+4egCPY8SPtl2Q2V1ocuA0qYIJB06bMhh2cHj4kWgnccFn2P1+zWJ9cSYweMQvjymIL4ASBdbqR18lAjgm70SzvBVw6zCbIWmJDcSyHNw9uO3iqAS5GBQgk1Qd3ISNrrSEb3eH+5+0aAXNrZRw== x-ms-office365-filtering-correlation-id: 7637c0a1-5c37-4872-55c4-08d495081eea x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0701MB1569; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(20161123558100)(20161123562025)(6072148); SRVR:BLUPR0701MB1569; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1569; x-forefront-prvs: 03008837BD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39840400002)(39850400002)(39400400002)(39410400002)(377454003)(24454002)(5660300001)(189998001)(77096006)(122556002)(7696004)(6506006)(93886004)(74316002)(229853002)(66066001)(2950100002)(25786009)(6916009)(2900100001)(6436002)(9686003)(305945005)(53936002)(2906002)(6246003)(86362001)(6116002)(3846002)(102836003)(110136004)(38730400002)(50986999)(3660700001)(33656002)(478600001)(3280700002)(55016002)(99286003)(54906002)(76176999)(54356999)(4326008)(8676002)(8936002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1569; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2017 05:15:47.4501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1569 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 May 2017 05:15:50 -0000 > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, May 03, 2017 7:11 PM >=20 > On Thu, May 04, 2017 at 12:14:30AM +0000, Mody, Rasesh wrote: > > > > > > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > > Sent: Monday, May 01, 2017 11:15 PM > > > > > > On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote: > > > > From: Rasesh Mody > > > > > > > > Changes included in this fix > > > > - limit CFLAGS to base files > > > > - fix to remove/mark unused members > > > > - add checks for debug config option > > > > - make qede_set_mtu() and qede_udp_dst_port_del() static and > others > > > > non-static as appropriate > > > > - move local APIs qede_vlan_offload_set() and > > > > qede_rx_cqe_to_pkt_type() > > > > - initialize variables as required > > > > > > When there are so many items in one single patch, it basically means > > > it's done wrongly. Generally, we should make one patch for each item. > > > > > > > Fixes: ec94dbc57362 ("qede: add base driver") > > > > Cc: stable@dpdk.org > > > > > > It's also not a good idea to put "Cc: stable" tag in a huge fix patch= . > > > It's very likely it won't apply cleanly to a stable/LTS release. For > > > instance, I failed to apply it to 16.11.2 (LTS). > > > > > > > > > > > Signed-off-by: Rasesh Mody > > > > --- > > > > drivers/net/qede/Makefile | 32 ++++----- > > > > drivers/net/qede/base/ecore.h | 4 +- > > > > drivers/net/qede/base/ecore_int_api.h | 4 +- > > > > drivers/net/qede/qede_ethdev.c | 120 ++++++++++++++++++---= - > ---- > > > ------- > > > > drivers/net/qede/qede_ethdev.h | 32 ++++----- > > > > drivers/net/qede/qede_fdir.c | 13 +--- > > > > drivers/net/qede/qede_if.h | 4 ++ > > > > drivers/net/qede/qede_main.c | 8 +-- > > > > drivers/net/qede/qede_rxtx.c | 118 +++++++++++++++++----= ---- > ----- > > > -- > > > > 9 files changed, 171 insertions(+), 164 deletions(-) > > > > > > It's also a clear sign of bad patch: too many changes for a single bu= g fix > patch. > > > > > > Most of them look like minor fixes to me. So my question is are > > > there any important items really should be picked for stable and LTS > release? > > > More specifically, do they really fix any (fatal) issues? If no, I > > > will drop it. If yes, please send a (or some) patch with the real > > > fixes backported only to stable ML, so that I could pick them. > > > > The patch is a Makefile change to restrict the CFLAG only to the base f= iles. > Once Makefile was changed it exposed few issues with PMD. >=20 > In such case, you could make patches to fix those issues first, one patch= for > one issue, and then put the CFLAG change to the last. >=20 > > Hence, we thought of putting all the changes in single patch since they > were relevant changes. > > > > As you stated most of them are minor fixes. We'll evaluate the patch if > anything specifically need to go into the stable release and get back. >=20 > Thanks. The answer seems to be "NO" to me though. We can skip this patch for stable release backport. Thanks! -Rasesh >=20 > --yliu