From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0082.outbound.protection.outlook.com [104.47.33.82]) by dpdk.org (Postfix) with ESMTP id 174BA58CB for ; Sat, 29 Oct 2016 00:49:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=17lVsnZC1SuR0q4oo5STdEcIq1dfptqyMQUX0ZQ5Cps=; b=ZAT/oHAB+pA/agZwmDSdUI/MJ7uLFF1gfRuYFAllkO02+T/KXvYePNorfAcU/ZG98wx83xmm2dMmFzTyCQyGfngWQY/qVXug110dGdRP3Szf1NkM+s/ckuQsMBrJ9QVP6267tV+cbr6DNTabgKKIMkHfUy3AZRdyRY+xTCU3UXM= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1571.namprd07.prod.outlook.com (10.163.84.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.12; Fri, 28 Oct 2016 22:49:40 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0679.018; Fri, 28 Oct 2016 22:49:40 +0000 From: "Mody, Rasesh" To: Stephen Hemminger , Rasesh Mody Thread-Topic: [dpdk-dev] [PATCH] net/qede: fix gcc compiler option checks Thread-Index: AQHSMOXgmpn32eLYJUmgOJo0W/NPE6C+btOAgAAHSkA= Date: Fri, 28 Oct 2016 22:49:40 +0000 Message-ID: References: <4958892.sIoVxbTeGS@xps13> <1477636677-18041-1-git-send-email-rasesh.mody@qlogic.com> <20161028151203.1a47d895@xeon-e3> In-Reply-To: <20161028151203.1a47d895@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: c8effae8-a592-4596-931f-08d3ff84b3cc x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1571; 7:4yHufkzwOFggA06c97EuRE57+Ym4lsz3cHD5/7L3MaabxXsOQlRIGjojmL/ugT2IEwzvFyiT5tu+7cz+XEKmFlK0LIjNmRlpwJn/ct0PVzsMbAKWyWLqnjfQAPgKbBXx7Zsbe9Lagra2yTSzNGgu7p0hKlnCHPONB47saXtoFUQR9SqxN3W/fuwYw3d4QMwPOqJlMltkKiwURojAfRQQYc0X/F5sU0abdQVlA++AsbarZ31uN5kC4FuDRoIxyTiLueUnKRyleeyi9XLfS+8b2PkduBESR+b5XZZMU8DmJ31v4S5SJD3z7rUTcaflAioOY1ROtV7aeTe8oqdimYVme5KGMTOKwBYRFa6rzS0ifME= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1571; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BLUPR0701MB1571; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1571; x-forefront-prvs: 0109D382B0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(24454002)(199003)(189002)(5002640100001)(77096005)(19580405001)(9686002)(102836003)(2900100001)(7736002)(106116001)(106356001)(7846002)(105586002)(99286002)(8936002)(33656002)(19580395003)(6116002)(8676002)(81166006)(81156014)(86362001)(76576001)(305945005)(87936001)(10400500002)(74316002)(189998001)(5001770100001)(68736007)(97736004)(2906002)(101416001)(4326007)(586003)(5660300001)(11100500001)(2950100002)(50986999)(76176999)(122556002)(3846002)(66066001)(3280700002)(3660700001)(7696004)(54356999)(92566002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1571; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2016 22:49:40.4478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1571 Cc: "dev@dpdk.org" , "Dept-EngDPDKDev@qlogic.com" , "thomas.monjalon@6wind.com" Subject: Re: [dpdk-dev] [PATCH] net/qede: fix gcc compiler option checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 22:49:43 -0000 Hi Stephen, > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Friday, October 28, 2016 3:12 PM >=20 > On Thu, 27 Oct 2016 23:37:57 -0700 > Rasesh Mody wrote: >=20 > > From: Rasesh Mody > > > > Using GCC_VERSION to check gcc version and decide whether to include > > that compiler option. > > > > Fixes: ec94dbc57362 ("qede: add base driver") > > Fixes: ecc7a5a27ffe ("net/qede/base: fix 32-bit build") > > > > Signed-off-by: Rasesh Mody > > --- > > drivers/net/qede/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile > > index 39751e4..29b443d 100644 > > --- a/drivers/net/qede/Makefile > > +++ b/drivers/net/qede/Makefile > > @@ -46,11 +46,11 @@ endif > > endif > > > > ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) > > -ifeq ($(shell gcc -Wno-unused-but-set-variable -Werror -E - < > > /dev/null > /dev/null 2>&1; echo $$?),0) > > +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > > CFLAGS_BASE_DRIVER +=3D -Wno-unused-but-set-variable endif > > CFLAGS_BASE_DRIVER +=3D -Wno-missing-declarations -ifeq ($(shell gcc > > -Wno-maybe-uninitialized -Werror -E - < /dev/null > /dev/null 2>&1; > > echo $$?),0) > > +ifeq ($(shell test $(GCC_VERSION) -ge 46 && echo 1), 1) > > CFLAGS_BASE_DRIVER +=3D -Wno-maybe-uninitialized endif > > CFLAGS_BASE_DRIVER +=3D -Wno-strict-prototypes >=20 > Does this mean that less compiler checking is done or more? With higher version of compilers more compiler checking is done, for older = compilers less checking is done. As some of the older compiles do not have = newly added checking capabilities. Testing with latest compilers ensures we= do lot more checking. Thanks! -Rasesh > It seems lots of drivers make the excuse: > "the base driver comes from another group and is known buggy but can't b= e > fixed" > That doesn't reflect well on the quality of the DPDK.