From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0057.outbound.protection.outlook.com [104.47.34.57]) by dpdk.org (Postfix) with ESMTP id 5851BCFD8 for ; Sat, 18 Mar 2017 08:18:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MsW6nDI/xHZFWLQUn0Xys1Z92EFjMxSLkPpJUrtJ/IU=; b=ixopqkY/hQj+OKWrakRYd56HepsSxqweEM3cb7Ncksv7UiwETSF0nWhIs89Zg+x0eWygqbUB9UGnqU20cJ1MwBqjL12Vm9M6PIZueHYH3e8HczSO1wC6qhRlfaDezd5iV4TYW8gb6n6B0b1LJA7BtH2kcZwZ2nRMUyPKCIYghyg= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Sat, 18 Mar 2017 07:18:09 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0977.017; Sat, 18 Mar 2017 07:18:09 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev Thread-Topic: [dpdk-dev] [PATCH 00/61] net/qede/base: qede PMD enhancements Thread-Index: AQHSkM8jPVHFtUD//UqmQ2l5YrgbIaGC71EAgAD3d8A= Date: Sat, 18 Mar 2017 07:18:09 +0000 Message-ID: References: <1488182237-10247-1-git-send-email-rasesh.mody@cavium.com> <162b5be7-d8a5-0e89-a32f-b1a992aef2a3@intel.com> In-Reply-To: <162b5be7-d8a5-0e89-a32f-b1a992aef2a3@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1572; 7:ShWghsLDnHlTSbqEqk0VuzBJracEUpVfxGqxL2qFfyKxRnkjTPx9F9Wr+p0oWqhYrgvILbVKJZ+ZnMOiVAO2FH5l5ssQi5/+FguMYjFyreHl8oQloTBXH4NRxTPfRpr0j1yE6z6EkYhZve8+yeDLHfVIyKfXLpGZztfQ3dthZcEJI0acNqnbFhprMVFyX7H5pxwUkyrBQhk1//xNlBB8+H5nF8blxsvDgpjQrtmggZSiEjTfVv2ia0vh1TBRdRw5Kl3JeNjYHxauKAU/QBFI3qX5YHK0T+e13Kdt7A9T/LWl37H2ObEmXrdvxplNrnHjs5XexKzndPadxomU03I+Dw== x-ms-office365-filtering-correlation-id: 1b1c696b-fbd0-4b34-57f2-08d46dceee3f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254060); SRVR:BLUPR0701MB1572; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123558025)(20161123560025)(6072148); SRVR:BLUPR0701MB1572; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1572; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(24454002)(377454003)(99286003)(2906002)(8936002)(50986999)(5660300001)(6306002)(76176999)(25786008)(54356999)(2900100001)(3846002)(6116002)(102836003)(6506006)(2501003)(6436002)(33656002)(86362001)(53546008)(55016002)(74316002)(81166006)(8676002)(3660700001)(66066001)(77096006)(122556002)(3280700002)(38730400002)(7736002)(7696004)(229853002)(53936002)(189998001)(4326008)(107886003)(53376002)(6246003)(305945005)(966004)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1572; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2017 07:18:09.2651 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1572 Subject: Re: [dpdk-dev] [PATCH 00/61] net/qede/base: qede PMD enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Mar 2017 07:18:12 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, March 03, 2017 2:25 AM >=20 > On 2/27/2017 7:56 AM, Rasesh Mody wrote: > > Hi, > > > > This patch set adds support for new firmware 8.18.9.0, new features > > and bug fixes. >=20 > This looks like depends other qede driver patchset [1], can you please > confirm? If so, it helps to mention from it here. Yes, this patch set depended on [1]. Note added in v2 submission. >=20 > Also I am getting following build errors [2]. A part of if..else got in into our final submission unintentionally, sorry = about that.=20 [2] addressed in v2 submission. >=20 > And there are some checkpatch and check-git-log.sh [3] errors. [3] addressed in v2 submission. Thanks! -Rasesh >=20 > Thanks, > ferruh >=20 > [1] > http://dpdk.org/dev/patchwork/patch/20816/ [patchset with 21 patches] >=20 >=20 >=20 > [2] > .../drivers/net/qede/base/ecore_dev.c:1703:4: error: use of undeclared > identifier 'ECORE_E5_MISSING_CODE' > ECORE_E5_MISSING_CODE; > ^ > 1 error generated. > make[7]: *** [base/ecore_dev.o] Error 1 > make[7]: *** Waiting for unfinished jobs.... > .../drivers/net/qede/qede_rxtx.c:1202:21: error: variable 'pad' is uninit= ialized > when used here [-Werror,-Wuninitialized] > rx_mb->data_off =3D pad + RTE_PKTMBUF_HEADROOM; > ^~~ > .../drivers/net/qede/qede_rxtx.c:997:14: note: initialize the variable 'p= ad' to > silence this warning > uint16_t pad; > ^ > =3D 0 > 1 error generated. >=20 > .../drivers/net/qede/qede_fdir.c: In function 'qede_config_cmn_fdir_filte= r': > .../drivers/net/qede/qede_fdir.c:126:44: error: format '%lx' expects > argument of type 'long unsigned int', but argument 4 has type 'uint64_t {= aka > long long unsigned int}' [-Werror=3Dformat=3D] > snprintf(mz_name, sizeof(mz_name) - 1, "%lx", rte_get_timer_cycles()); >=20 >=20 >=20 > [3] > Wrong headline format: > send FW version driver state to MFW > net/qede/base: decrease MAX_HWFNS_PER_DEVICE from 4 to 2 > net/qede/base: add a printout of the FW, MFW and MBI versions > net/qede/base: set the drv_type before sending load request Wrong > headline prefix: > send FW version driver state to MFW > drivers/net/qede: upgrade the FW to 8.18.9.0 Wrong headline > uppercase: > net/qede/base: L2 handler changes > net/qede/base: Add support to set max values of soft resoruces Wr= ong > headline lowercase: > net/qede/base: use default mtu from shared memory > net/qede/base: update MFW when default mtu is changed > net/qede/base: add non-l2 dcbx tlv application support > net/qede/base: allow PMD to control vport-id and rss-eng-id Headl= ine > too long: > net/qede/base: remove attribute field from update current config > net/qede/base: add support to read personality via MFW commands > net/qede/base: allow only trusted VFs to be promisc/multi-promisc > net/qede/base: add a printout of the FW, MFW and MBI versions > net/qede/base: update bulletin board with link state during init > net/qede/base: Add support to set max values of soft resoruces > net/qede/base: add multi-Txq support on same queue-zone for VFs > net/qede/base: fix race cond between MFW attentions and PF stop > Missing 'Fixes' tag: > net/qede/base: fix to set pointers to NULL after freeing > net/qede/base: fix race cond between MFW attentions and PF stop >=20 >=20 >=20 > > > > Please apply to dpdk-net-next for 17.05 release. > > > > Thanks! > > Rasesh > > > > Harish Patil (3): > > net/qede/base: add support for arfs mode > > net/qede: add ntuple and flow director filter support > > net/qede: add LRO/TSO offloads support > > > > Rasesh Mody (58): > > net/qede/base: return an initialized return value > > send FW version driver state to MFW > > net/qede/base: mask Rx buffer attention bits > > net/qede/base: print various indication on Tx-timeouts > > net/qede/base: utilize FW 8.18.9.0 > > drivers/net/qede: upgrade the FW to 8.18.9.0 > > net/qede/base: decrease MAX_HWFNS_PER_DEVICE from 4 to 2 > > net/qede/base: move mask constants defining NIC type > > net/qede/base: remove attribute field from update current config > > net/qede/base: add nvram options > > net/qede/base: add comment > > net/qede/base: use default mtu from shared memory > > net/qede/base: change queue/sb-id from 8 bit to 16 bit > > net/qede/base: update MFW when default mtu is changed > > net/qede/base: prevent device init failure > > net/qede/base: add support to read personality via MFW commands > > net/qede/base: allow probe to succeed with minor HW-issues > > net/qede/base: remove unneeded step in HW init > > net/qede/base: allow only trusted VFs to be promisc/multi-promisc > > net/qede/base: qm initialization revamp > > net/qede/base: add a printout of the FW, MFW and MBI versions > > net/qede/base: check active VF queues before stopping > > net/qede/base: set the drv_type before sending load request > > net/qede/base: prevent driver laod with invalid resources > > net/qede/base: add interfaces for MFW TLV request processing > > net/qede/base: fix to set pointers to NULL after freeing > > net/qede/base: L2 handler changes > > net/qede/base: add support for handling TLV request from MFW > > net/qede/base: optimize cache-line access > > net/qede/base: infrastructure changes for VF tunnelling > > net/qede/base: revise tunnel APIs/structs > > net/qede/base: add tunnelling support for VFs > > net/qede/base: formatting changes > > net/qede/base: prevent transmitter stuck condition > > net/qede/base: add mask/shift defines for resource command > > net/qede/base: add API for using MFW resource lock > > net/qede/base: remove clock slowdown option > > net/qede/base: add new image types > > net/qede/base: use L2-handles for RSS configuration > > net/qede/base: change valloc to vzalloc > > net/qede/base: add support for previous driver unload > > net/qede/base: add non-l2 dcbx tlv application support > > net/qede/base: update bulletin board with link state during init > > net/qede/base: add coalescing support for VFs > > net/qede/base: add macro got resource value message > > net/qede/base: add mailbox for resource allocation > > net/qede/base: add macro for unsupported command > > net/qede/base: Add support to set max values of soft resoruces > > net/qede/base: add return code check > > net/qede/base: zero out MFW mailbox data > > net/qede/base: move code bits > > net/qede/base: add PF parameter > > net/qede/base: allow PMD to control vport-id and rss-eng-id > > net/qede/base: add udp ports in bulletin board message > > net/qede/base: prevent DMAE transactions during recovery > > net/qede/base: add multi-Txq support on same queue-zone for VFs > > net/qede/base: fix race cond between MFW attentions and PF stop > > net/qede/base: semantic changes >=20 > <...>