From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0052.outbound.protection.outlook.com [104.47.36.52]) by dpdk.org (Postfix) with ESMTP id A29C3CFD6 for ; Fri, 24 Mar 2017 08:45:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hZLBckLcjoOHUeRrt0ncGIYaSKkpkZ6OUx9qZexI9SY=; b=AMnxP8hMp/9qMqKnot5wT3FxCtfdzmtlYZt6ophhVLtfC03/mnrlRzlVzYW9Nh0ovFbpwarjprBX0vOQKgUARAugccw93tExkva1pYHO38kDK19urOpL9UJbrSQMGw1YapYcMvAxxRhB0kmfd96e3jO74EkwGJkPoTK/pq5xi14= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Fri, 24 Mar 2017 07:45:03 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0977.021; Fri, 24 Mar 2017 07:45:03 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev Thread-Topic: [PATCH v2 00/61] net/qede/base: qede PMD enhancements Thread-Index: AQHSn7YvY7ZTWuIcA0msetSmQHOosaGd9ycAgACC32A= Date: Fri, 24 Mar 2017 07:45:02 +0000 Message-ID: References: <162b5be7-d8a5-0e89-a32f-b1a992aef2a3@intel.com> <1489820786-14226-1-git-send-email-rasesh.mody@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1572; 7:Gzb+EJYJcTyOOibC4uZonwVgLaOUSet38BOjhxvjsCzfKqBKr9Cyqy8cYYq6BU2ZgVYKzhe4EIXzKOa7K0wucNjxqH6yqSX5OlEZCQo1Zavnt3qoIxANQGDlLWuBlbT0Ja+UJGlLBEj2xVvTXur83MoKYv9YEA5tpHG1naZq31H1NAWiknvOFb2ma+L4u6D7A75II19rdnumqyR7WABw+hwuvzxpLzwYNSKGgafuLnNC5RbnShHHdfwSjcTcHcIqCi2VkiR1cbStbj3rgpGxvYlnZ582gEaxT84hB3+01XltSp277X9Frdths8T3mFgmAWyKrXveYV4rzFzQiWaICQ== x-ms-office365-filtering-correlation-id: a9b2aa17-b0fe-400f-1584-08d47289aea8 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075); SRVR:BLUPR0701MB1572; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(20161123558025)(6072148); SRVR:BLUPR0701MB1572; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1572; x-forefront-prvs: 0256C18696 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(377454003)(24454002)(6436002)(77096006)(6506006)(74316002)(25786009)(50986999)(6246003)(4326008)(53376002)(8676002)(38730400002)(107886003)(53546009)(2900100001)(8936002)(229853002)(76176999)(54356999)(5660300001)(2501003)(2950100002)(7696004)(66066001)(53936002)(86362001)(33656002)(966004)(99286003)(6306002)(3660700001)(9686003)(55016002)(3280700002)(7736002)(305945005)(189998001)(6116002)(122556002)(3846002)(102836003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1572; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2017 07:45:02.8756 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1572 Subject: Re: [dpdk-dev] [PATCH v2 00/61] net/qede/base: qede PMD enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 07:45:09 -0000 Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Monday, March 20, 2017 9:59 AM > To: Mody, Rasesh ; dev@dpdk.org > Cc: Dept-Eng DPDK Dev > Subject: Re: [PATCH v2 00/61] net/qede/base: qede PMD enhancements >=20 > On 3/18/2017 7:05 AM, Rasesh Mody wrote: > > Hi, > > > > This patch set adds support for new firmware 8.18.9.0, new features > > and bug fixes. > > > > Please apply to dpdk-net-next for 17.05 release. Note that this patch > > set depends on http://dpdk.org/dev/patchwork/patch/21896. > > > > v1..v2 > > - address all the review comments received so far > > > > Thanks! > > Rasesh > > > > Harish Patil (3): > > net/qede/base: add support for arfs mode > > net/qede: add ntuple and flow director filter support > > net/qede: add LRO/TSO offloads support > > > > Rasesh Mody (58): > > net/qede/base: return an initialized return value > > net/qede/base: send FW version driver state to MFW > > net/qede/base: mask Rx buffer attention bits > > net/qede/base: print various indication on Tx-timeouts > > net/qede/base: utilize FW 8.18.9.0 > > net/qede: upgrade the FW to 8.18.9.0 > > net/qede/base: decrease maximum HW func per device > > net/qede/base: move mask constants defining NIC type > > net/qede/base: remove attribute from update current config > > net/qede/base: add nvram options > > net/qede/base: add comment > > net/qede/base: use default MTU from shared memory > > net/qede/base: change queue/sb-id from 8 bit to 16 bit > > net/qede/base: update MFW when default MTU is changed > > net/qede/base: prevent device init failure > > net/qede/base: read card personality via MFW commands > > net/qede/base: allow probe to succeed with minor HW-issues > > net/qede/base: remove unneeded step in HW init > > net/qede/base: allow only trusted VFs to be promisc > > net/qede/base: qm initialization revamp > > net/qede/base: print firmware MFW and MBI versions > > net/qede/base: check active VF queues before stopping > > net/qede/base: set driver type before sending load request > > net/qede/base: prevent driver laod with invalid resources > > net/qede/base: add interfaces for MFW TLV request processing > > net/qede/base: code refactoring of SP queues > > net/qede/base: make L2 queues handle based > > net/qede/base: add support for handling TLV request from MFW > > net/qede/base: optimize cache-line access > > net/qede/base: infrastructure changes for VF tunnelling > > net/qede/base: revise tunnel APIs/structs > > net/qede/base: add tunnelling support for VFs > > net/qede/base: formatting changes > > net/qede/base: prevent transmitter stuck condition > > net/qede/base: add mask/shift defines for resource command > > net/qede/base: add API for using MFW resource lock > > net/qede/base: remove clock slowdown option > > net/qede/base: add new image types > > net/qede/base: use L2-handles for RSS configuration > > net/qede/base: change valloc to vzalloc > > net/qede/base: add support for previous driver unload > > net/qede/base: add non-L2 dcbx tlv application support > > net/qede/base: update bulletin board during VF init > > net/qede/base: add coalescing support for VFs > > net/qede/base: add macro got resource value message > > net/qede/base: add mailbox for resource allocation > > net/qede/base: add macro for unsupported command > > net/qede/base: set max values for soft resoruces > > net/qede/base: add return code check > > net/qede/base: zero out MFW mailbox data > > net/qede/base: move code bits > > net/qede/base: add PF parameter > > net/qede/base: allow PMD to control vport and RSS engine ids > > net/qede/base: add udp ports in bulletin board message > > net/qede/base: prevent DMAE transactions during recovery > > net/qede/base: multi-Txq support on same queue-zone for VFs > > net/qede/base: prevent race condition during unload > > net/qede/base: semantic changes > > >=20 > Hi Rasesh, >=20 > Getting following build errors, one with clang [1] and other with 32bit [= 2], I > have not investigated which patch cause the error, just copy-pasting the > build errors. We've addressed clang and 32bit errors in our v3 submission. Thanks! -Rasesh >=20 > These looks like same build errors with previous version of the patchset. >=20 >=20 > [1] > .../drivers/net/qede/qede_rxtx.c:1202:21: error: variable 'pad' is uninit= ialized > when used here [-Werror,-Wuninitialized] > rx_mb->data_off =3D pad + RTE_PKTMBUF_HEADROOM; > ^~~ > .../drivers/net/qede/qede_rxtx.c:997:14: note: initialize the variable 'p= ad' to > silence this warning > uint16_t pad; > ^ > =3D 0 >=20 >=20 > [2] > .../drivers/net/qede/qede_fdir.c: In function 'qede_config_cmn_fdir_filte= r': > .../drivers/net/qede/qede_fdir.c:126:44: error: format '%lx' expects > argument of type 'long unsigned int', but argument 4 has type 'uint64_t {= aka > long long unsigned int}' [-Werror=3Dformat=3D] > snprintf(mz_name, sizeof(mz_name) - 1, "%lx", rte_get_timer_cycles()); > ^