From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0042.outbound.protection.outlook.com [104.47.41.42]) by dpdk.org (Postfix) with ESMTP id E066BF927 for ; Thu, 5 Jan 2017 08:16:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=o6BOEiYUaGFjIo7g5c6dRFbO28TQs236WEeiQkg51us=; b=JdwLHp4HVezEL/XziKXkUttM68XTNrxyoz+1d2ETxdvOaeutj0Fp4wlcTGmhmg4PwQ4c8SLsculESTMFIvGIn0Ng7psV090wXl2KKUFtQTN4OceXc+Ka1XlxPk0X7bsM3FhH/bpkx8hW/fOvTlbFg2lRwfoenF0dfrRyNnMEkb0= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1569.namprd07.prod.outlook.com (10.163.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11; Thu, 5 Jan 2017 07:16:16 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0803.021; Thu, 5 Jan 2017 07:16:16 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev Thread-Topic: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes Thread-Index: AQHSTUVksJIhsuHEOkCk7B5ZOoZZm6EVy8kAgAwE5uCABURTgIAClrlg Date: Thu, 5 Jan 2017 07:16:16 +0000 Message-ID: References: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com> <1480756289-11835-24-git-send-email-Rasesh.Mody@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [2601:646:8180:be50:b045:1c15:cfec:4a42] x-ms-office365-filtering-correlation-id: efedb4b8-7d81-4cce-3e54-08d4353abd41 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1569; x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1569; 7:Hq+OX9VryHqH0gOnkxKSgSxooIU2SUikb5C3RsVXujYRKDKdDAwgdNweWmCeWCwvLJheuuBSszxN2yHMikwDnnvGTCYkgOzBuDqJyQlUR+x51Y7Bn9ObQcnpfjqUslSMONNvK5v8QAXrkUm5n8zkUVA170h1ee98rmTpgrV/g1fc4hHLieWhJhvjYrVuBq0nMV+ULlxha6lR3X3eFxxvce2RR74wcA4r3VunVkwNtDhvwpFUPTwDT52Hs1wXt/pozFaQC1g6rOrBKjlRG31yJHP+GPqSeJ7c6Bg0Zgtn8qvWf26wBUT/g7AlZbiG6AdsevTLsu9h/DT1fbYDTZGAq8ZAT37lRKKxyaOCNM+gukyIlzAYQtRBFyvAbh0xH+1oJXYzDCEUZRSCAdQ+GPLmtup5E5n7X2D0B+/Qp/h+N12bexeuXvDPQ22AaA68k0K1VvBJucmygODfPsYbDtA+3g== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123558021)(20161123562025)(20161123560025)(6072148); SRVR:BLUPR0701MB1569; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1569; x-forefront-prvs: 0178184651 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(377454003)(24454002)(189002)(199003)(2950100002)(3660700001)(305945005)(81156014)(9686002)(77096006)(102836003)(99286003)(97736004)(33656002)(101416001)(6506006)(6116002)(229853002)(107886002)(68736007)(54356999)(189998001)(4001430100002)(5660300001)(2501003)(106116001)(38730400001)(7696004)(105586002)(7736002)(8676002)(122556002)(86362001)(25786008)(6436002)(106356001)(5001770100001)(50986999)(2906002)(4326007)(76176999)(55016002)(74316002)(81166006)(3280700002)(8936002)(92566002)(93886004)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1569; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2017 07:16:16.3845 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1569 Subject: Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 07:16:18 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Tuesday, January 03, 2017 7:41 AM >=20 > On 12/31/2016 7:41 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > >> Sent: Friday, December 23, 2016 7:42 AM > >> > >> On 12/3/2016 9:11 AM, Rasesh Mody wrote: > >>> This patch consists of semantic/formatting changes. It also includes > >>> comment additions. > >> > >> As far as I can see majority of the changes are formatting, but not al= l. > >> > >> Functional changes are hard to detect in this patch, what do you > >> think separating formatting/comments patches into another patch, so > >> functional changes can become more visible? > > > > There are few of places(ecore_hw_bar_size(), ecore_get_hw_info() and > ecore_init_cmd_*), where there is a bit of code refactoring. However, the= y > are not a major change. We have tried to isolate most of the functional > changes and made them part of the separate patches as fit. I think, we ca= n > include a bit of description in commit message to cover it in this patch.= Please > let me know if you think otherwise. >=20 > I believe it is good to separate code refactoring into different patch if > possible, instead of covering this in commit log. >=20 > This makes functional changes easy to find in the future. In this patch h= ard to > spot them. V2 series has been submitted to separate code refactoring changes and addre= ss few other comments received for this patch set. Thanks! -Rasesh =20 > Thanks, > ferruh >=20 > > > >>> > >>> Signed-off-by: Rasesh Mody > >>> --- > >> <...>