From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0056.outbound.protection.outlook.com [104.47.40.56]) by dpdk.org (Postfix) with ESMTP id 449CDF8AA for ; Sat, 25 Mar 2017 07:28:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=txcu/mupoKA1JDZgVj3P4R/Rpx7XrBhh4vgdT4xkkKE=; b=EvAxeM5GZpH0Bm/X/1BhVaT+ZtIa/i89pccCk91FwgQVoUOS1sYE1K14OOD+MN5jdJlRa8o07jYjasJMsUMB1FvYcVABm6F6uDkp/EuixauAmLOlWeYxVvAj4bFm6F0QA1UAorrXqyzdiYsMDaFLFpZet5g68+iztVgo/5yJKNA= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1570.namprd07.prod.outlook.com (10.163.84.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Sat, 25 Mar 2017 06:28:02 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0977.021; Sat, 25 Mar 2017 06:28:02 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Harish Patil , Dept-Eng DPDK Dev Thread-Topic: [PATCH v2 61/61] net/qede: add LRO/TSO offloads support Thread-Index: AQHSn7cAwkv9D3doy02fCoRAk0p4yaGj7JiAgAE1vZA= Date: Sat, 25 Mar 2017 06:28:02 +0000 Message-ID: References: <162b5be7-d8a5-0e89-a32f-b1a992aef2a3@intel.com> <1489820786-14226-62-git-send-email-rasesh.mody@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1570; 7:kbTfjSKfdBVALz6Pj1Q4qowM/KiSNwO0wF4Yw5MdHDMV8RxsAffeKosSleRDl1WbgCISm9y/FyoM4gF4AoGvKAB2FDe9I9JciAc6+QCwhI/mh1gBW+P4M1MbC0BnusDf/j7VtqFWD1QZKvrmMiwx1oY55Aphp/PZdz4nFxsWIVxPdeUFtiuDbwSEl1pIwM6hnB19GjLLHGiUxAnin0Jg3KC3c7NkdvFujwckeNIslLZVeEwMI9ev28WSn/NNGrCE/VQ/Y9ja18bjmL7hpq4iylPOk10ASNvgg6E+MvN+diW7cQzdXdpWygT1MWlCvhMYNcfoRoc8VlfH6fSoiAEoSw== x-ms-office365-filtering-correlation-id: 2fb123dc-9f56-44b3-0cc9-08d4734816f9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075); SRVR:BLUPR0701MB1570; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(20161123558025)(6072148); SRVR:BLUPR0701MB1570; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1570; x-forefront-prvs: 025796F161 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39830400002)(377454003)(24454002)(38730400002)(6116002)(189998001)(102836003)(53936002)(107886003)(2906002)(2501003)(25786009)(8936002)(5660300001)(4326008)(8676002)(7696004)(2900100001)(2950100002)(81166006)(74316002)(6506006)(6246003)(53546009)(7736002)(55016002)(50986999)(54356999)(76176999)(305945005)(99286003)(54906002)(3846002)(3660700001)(3280700002)(33656002)(77096006)(6436002)(66066001)(122556002)(86362001)(9686003)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1570; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2017 06:28:02.3189 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1570 Subject: Re: [dpdk-dev] [PATCH v2 61/61] net/qede: add LRO/TSO offloads support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2017 06:28:05 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, March 24, 2017 4:59 AM >=20 > On 3/18/2017 7:06 AM, Rasesh Mody wrote: > > From: Harish Patil > > > > This patch includes slowpath configuration and fastpath changes to > > support LRO and TSO. A bit of revamping is needed in order to make use > > of existing packet classification schemes in Rx fastpath and for SG > > element processing in Tx. > > > > Signed-off-by: Harish Patil >=20 > This patch is giving following checkpatch errors [1], I can see the reaso= n of > the multiline dereference is to fit into 80 column line limit, and those = lines are > not easy to escape from line limit. >=20 > But eventually if we get a checkpatch warning, I prefer it to be from lon= g line, > multiline dereference makes code harder to read. >=20 > What do you think? Will try to address this more efficiently. =20 >=20 >=20 > [1] > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->len_on_first_bd' > #450: FILE: drivers/net/qede/qede_rxtx.c:1045: > + rte_le_to_cpu_16(cqe_start_tpa-> > + len_on_first_bd), >=20 > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->ext_bd_len_list[0]' > #453: FILE: drivers/net/qede/qede_rxtx.c:1048: > + rte_le_to_cpu_16(cqe_start_tpa-> > + > + ext_bd_len_list[0]), >=20 > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'rxq->tpa_info[cqe->fast_path_tpa_end.tpa_agg_index].mbuf' > #465: FILE: drivers/net/qede/qede_rxtx.c:1060: > + rx_mb =3D rxq-> > + > + tpa_info[cqe->fast_path_tpa_end.tpa_agg_index].mbuf; >=20 > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->pars_flags.flags' > #512: FILE: drivers/net/qede/qede_rxtx.c:1087: > + parse_flag =3D rte_le_to_cpu_16(cqe_start_tpa-> > + > + pars_flags.flags); >=20 > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'cqe_start_tpa->tunnel_pars_flags.flags' > #541: FILE: drivers/net/qede/qede_rxtx.c:1108: > + tunn_parse_flag =3D > + cqe_start_tpa-> > + > tunnel_pars_flags.flags; >=20 > WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - > prefer 'fp_cqe->tunnel_pars_flags.flags' > #544: FILE: drivers/net/qede/qede_rxtx.c:1111: > + tunn_parse_flag =3D fp_cqe-> > + > tunnel_pars_flags.flags; >=20 >=20 > <...>