From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0083.outbound.protection.outlook.com [104.47.40.83]) by dpdk.org (Postfix) with ESMTP id 27EFCD332 for ; Sat, 25 Mar 2017 07:25:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DUFFrHuy0o1KKo0OGI382EMfECEphLEOjUdFvvfmYsQ=; b=BFB+QPLMPl8XAZ1NU+bgqszQ7toh/93Ss+dapE8q7226cXjCHi06lUYUzkT8sxlsZ/pgdnpP6FjqtpmrsxfU2NzE8lx22Bzh67QasrEMo2cN3kVyhVinPW3C2FEj1WsZyW1ubnltpebqD2NcJi1po6RocWITyYlmkOS20UzjD0w= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1570.namprd07.prod.outlook.com (10.163.84.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Sat, 25 Mar 2017 06:25:32 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0977.021; Sat, 25 Mar 2017 06:25:32 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev Thread-Topic: [PATCH v3 41/61] net/qede/base: add support for previous driver unload Thread-Index: AQHSpHCV/pSZ8UOA50Ou7Fe5Kp3TgKGj0uaAgAFEqkA= Date: Sat, 25 Mar 2017 06:25:32 +0000 Message-ID: References: <1490340531-11403-42-git-send-email-rasesh.mody@cavium.com> <1cabe096-47c2-401f-de66-524590fede83@intel.com> In-Reply-To: <1cabe096-47c2-401f-de66-524590fede83@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1570; 7:reuV4BPFv1gml1mbSkYh79AfRWXL302kVpGhrdiEDlm8NYsCRWCXuTIXEwU9R5rdVSzpCyjNjc1KfeJTbYCmizrw3uh2KjqR5yNX0VXmCO6gKIWZEJ7N3Cf3dBK5TlLrwTajW5bmd9MvsaBVy3K2soYtCYMjK+6TzicLsWSWxzh6uMkyntHdMqrYrlxgnownadUyxTF+e9Lplot3fWMHkzNHwbek4s9rAmsVV1N2n5HIDbF1CHy7Wg5hbKLjoWIx9upb7tTAa6Vo+ditIxWtArRz/2uEsNJmn0IVNmGOuz84asi2iCHQUaEAHQ8MLggoMeg2aWEDXeHv4yUupIkrbw== x-ms-office365-filtering-correlation-id: ed960e3f-2b01-4d24-b2c4-08d47347bd87 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075); SRVR:BLUPR0701MB1570; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148); SRVR:BLUPR0701MB1570; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1570; x-forefront-prvs: 025796F161 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39830400002)(377454003)(24454002)(38730400002)(6116002)(189998001)(102836003)(53936002)(107886003)(2906002)(2501003)(25786009)(8936002)(5660300001)(4326008)(8676002)(7696004)(2900100001)(2950100002)(81166006)(74316002)(6506006)(6246003)(53546009)(7736002)(55016002)(50986999)(54356999)(76176999)(305945005)(99286003)(3846002)(3660700001)(3280700002)(33656002)(77096006)(6436002)(66066001)(122556002)(86362001)(9686003)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1570; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2017 06:25:32.2638 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1570 Subject: Re: [dpdk-dev] [PATCH v3 41/61] net/qede/base: add support for previous driver unload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2017 06:25:35 -0000 Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, March 24, 2017 4:01 AM >=20 > On 3/24/2017 7:28 AM, Rasesh Mody wrote: > > New driver/management fw load request sequence for handling previous > > driver unload. > > > > Signed-off-by: Rasesh Mody >=20 > Hi Rasesh, >=20 > Patch by patch build broken with this patch with following build error, a= nd > fixed back with patch 50/61: >=20 > .../drivers/net/qede/base/ecore_mcp.c:624:2: error: signed shift result > (0xF00000000) requires 37 bits to represent, but 'int' only has 32 bits [= - > Werror,-Wshift-overflow] > ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FORCE, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > .../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro > 'ECORE_MFW_SET_FIELD' > (name) &=3D ~((field ## _MASK) << (field ## _SHIFT)); = \ > ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~ > .../drivers/net/qede/base/ecore_mcp.c:626:2: error: signed shift result > (0xF0000000000) requires 45 bits to represent, but 'int' only has 32 bits= [- > Werror,-Wshift-overflow] > ECORE_MFW_SET_FIELD(p_load_req->misc0, LOAD_REQ_FLAGS0, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > .../drivers/net/qede/base/ecore.h:107:31: note: expanded from macro > 'ECORE_MFW_SET_FIELD' > (name) &=3D ~((field ## _MASK) << (field ## _SHIFT)); = \ > ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~ <...> We observed the same issue with patch 41, unfortunately the fix was uninte= ntionally added only in patch 50 whereas it was candidate for patch 41. We'= ll address this and resubmit. Thanks! -Rasesh