From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0065.outbound.protection.outlook.com [104.47.33.65]) by dpdk.org (Postfix) with ESMTP id CEFAE2C66 for ; Wed, 29 Mar 2017 22:48:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RG1npwWRNSizLz4cHlneBSYcRo9n0ns/KeYkBQWsCmg=; b=lDXXGbt1X7QBjWI0X2P1K7/L0LtR9elbU106GcEQCqa1QzO0HBXbujwrq6CcG/oMtOSlf6mzkvM1HUGNcHhDV8ELjH6PCMAV0mX04I4gSNAHhu+GR02nMFBfDdYOkw5A942L3O2/vr7ZJZRt+s2yp4oKEd44uXRe/LPOBw12oKM= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Wed, 29 Mar 2017 20:48:09 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.1005.013; Wed, 29 Mar 2017 20:48:08 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs Thread-Index: AQHSqG4gjLstlg9/2UGz6h5RAukMK6GsSLiw Date: Wed, 29 Mar 2017 20:48:08 +0000 Message-ID: References: <798af029-9a26-9065-350b-48781c1d3c55@intel.com> <1490683952-24919-32-git-send-email-rasesh.mody@cavium.com> <575911f6-467b-4153-1ac3-a452989a8ce5@intel.com> <12f2f80f-85b0-bd88-695b-82004c1ad9ba@intel.com> In-Reply-To: <12f2f80f-85b0-bd88-695b-82004c1ad9ba@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cavium.com; x-originating-ip: [173.186.134.106] x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1572; 7:lOFVhsFVWhU7tzpdC0e0tjeJqgdEDB23De5aOtrpoEL2hz14D1iygivPaXOdWPKwc0QyS0vPb8w1wPXE7zB95bQAE16wo3x/zLB1wrCf2X731Wvt6uc7H6tDVhW4eLLr3dgCyAqH/cjxR8WpkWZC4ydep8aQU/9wN81UvxrjoVhaLNpHQVpjvxodvfBxrQkpEMO6x1nrkHBtVbKzFpNaHtl/OctnvLD97JtG2hdQjA7P0LDG5z0ec6aXrZGSvAjdafrxl/I/YCq1gC826ZGJte6FZcThpFFJ81R96agyMJbgAo4bZZGiCiIT0u50dtRrwNxW2DeZoSoWVP35odsG0A== x-ms-office365-filtering-correlation-id: 149d584e-d7dd-4e41-277d-08d476e4e864 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR0701MB1572; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406075)(20161123558025)(20161123562025)(6072148); SRVR:BLUPR0701MB1572; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1572; x-forefront-prvs: 0261CCEEDF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39410400002)(39830400002)(39400400002)(76104003)(377454003)(24454002)(99286003)(9686003)(55016002)(53936002)(6246003)(25786009)(53546009)(2501003)(77096006)(229853002)(7696004)(4326008)(38730400002)(2950100002)(3846002)(102836003)(6116002)(5660300001)(54356999)(3660700001)(93886004)(3280700002)(2906002)(50986999)(74316002)(76176999)(7736002)(305945005)(33656002)(189998001)(6436002)(8676002)(2900100001)(8936002)(6506006)(86362001)(81166006)(122556002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1572; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2017 20:48:08.8018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1572 Subject: Re: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 20:48:11 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Wednesday, March 29, 2017 2:23 AM >=20 > On 3/28/2017 10:18 PM, Mody, Rasesh wrote: > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > >> Sent: Tuesday, March 28, 2017 4:23 AM > >> > >> On 3/28/2017 7:52 AM, Rasesh Mody wrote: > >>> Revise tunnel APIs/structs. > >>> - Unite tunnel start and update params in single struct > >>> "ecore_tunnel_info" > >>> - Remove A0 chip tunnelling support. > >>> - Added per tunnel info - removed bitmasks. > >>> > >>> Signed-off-by: Rasesh Mody > >> > >> I hate to say this, but this patch gives build error with clang [1], > >> it seems it is fixed in next patch. > > > > We also observed this error on clang, however, the fix got wrongly appl= ied > to the next patch, sorry about that. > > > >> > >> This patchset is big, and takes time to review / validate it, and a > >> small error requires whole patchset done again. I am not suggesting > >> updating this one, but for further patchsets, what do you think > >> making multiple smaller patchsets? > > > > Please let us know if we need to refresh the current v4 patchset to add= ress > the clang issue. >=20 > Yes, can you please send a new version of the patchset. We have addressed clang build error in appropriate patch and resent the pat= chset. We have tested the patchset on latest dpdk-next-net d1f78e9696cd ("d= oc: detail new tap features in release note"). Thanks! -Rasesh =20 > > It's good suggestion, for further patchsets, we can do multiple smaller > patchsets. > > > > Thanks! > > -Rasesh > > > >> > >> Thanks, > >> ferruh > >> > >> > >> [1] > >> Building x86_64-native-linuxapp-clang ... > >> .../drivers/net/qede/base/ecore_sp_commands.c:141:25: error: implicit > >> conversion from enumeration type 'enum tunnel_clss' to different > >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum- > conversion] > >> p_tun->vxlan.tun_cls =3D type; > >> ~ ^~~~ > >> .../drivers/net/qede/base/ecore_sp_commands.c:143:26: error: implicit > >> conversion from enumeration type 'enum tunnel_clss' to different > >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum- > conversion] > >> p_tun->l2_gre.tun_cls =3D type; > >> ~ ^~~~ > >> .../drivers/net/qede/base/ecore_sp_commands.c:145:26: error: implicit > >> conversion from enumeration type 'enum tunnel_clss' to different > >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum- > conversion] > >> p_tun->ip_gre.tun_cls =3D type; > >> ~ ^~~~ > >> .../drivers/net/qede/base/ecore_sp_commands.c:147:29: error: implicit > >> conversion from enumeration type 'enum tunnel_clss' to different > >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum- > conversion] > >> p_tun->l2_geneve.tun_cls =3D type; > >> ~ ^~~~ > >> .../drivers/net/qede/base/ecore_sp_commands.c:149:29: error: implicit > >> conversion from enumeration type 'enum tunnel_clss' to different > >> enumeration type 'enum ecore_tunn_clss' [-Werror,-Wenum- > conversion] > >> p_tun->ip_geneve.tun_cls =3D type; > >> ~ ^~~~ > >> 5 errors generated. > >> make[10]: *** [base/ecore_sp_commands.o] Error 1 > >> make[10]: *** Waiting for unfinished jobs.... > >> .../drivers/net/qede/qede_ethdev.c:1724:45: error: variable 'p_tunn' > >> is uninitialized when used here [-Werror,-Wuninitialized] > >> rc =3D ecore_sp_pf_update_tunn_cfg(p_hwfn, p_t= unn, > >> > >> ^~~~~~ > >> .../drivers/net/qede/qede_ethdev.c:1711:34: note: initialize the > >> variable 'p_tunn' to silence this warning > >> struct ecore_tunnel_info *p_tunn; > >> ^ > >> =3D NULL > >> .../drivers/net/qede/qede_ethdev.c:1877:5: error: variable 'p_tunn' > >> is uninitialized when used here [-Werror,-Wuninitialized] > >> p_tunn, ECORE_SPQ_MODE_CB, NULL); > >> ^~~~~~ > >> .../drivers/net/qede/qede_ethdev.c:1822:34: note: initialize the > >> variable 'p_tunn' to silence this warning > >> struct ecore_tunnel_info *p_tunn; > >> ^ > >> =3D NULL > >> 2 errors generated. > >