From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0080.outbound.protection.outlook.com [104.47.38.80]) by dpdk.org (Postfix) with ESMTP id 86A222B94 for ; Mon, 17 Oct 2016 20:04:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bPPRdp2w8FpCyF74wLNyzwFG7XHwW/7kvVr/zmIRnoA=; b=M6eyC3AUhICrMgQMdz3my9zRV7jlRqDnfhd/Pq1+s2So+LgNiwt5RIU76buiMiA7BBErKE3mAtULxSbZdi8ADgbendr0X0tfrvWyXqo5d+u7aVjD5lG6XuUA4SGR/VgrwlQw93MK62KHdsVYjgtmDBgF53Yqr9CSHewvG0BPv5E= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1569.namprd07.prod.outlook.com (10.163.84.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Mon, 17 Oct 2016 18:04:32 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0659.025; Mon, 17 Oct 2016 18:04:32 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Sony Chacko , Harish Patil , Rasesh Mody Thread-Topic: [dpdk-dev] [PATCH] net/bnx2x: fix icc build error Thread-Index: AQHSKG+fhGosEtPVc0ub8ZNB2aNcOaCs7/Tw Date: Mon, 17 Oct 2016 18:04:32 +0000 Message-ID: References: <20160930144515.1770-1-ferruh.yigit@intel.com> <12674be5-bed0-6e61-7506-b6bb19460c97@intel.com> In-Reply-To: <12674be5-bed0-6e61-7506-b6bb19460c97@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: ba3b064f-2e55-4370-cc27-08d3f6b80bdc x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1569; 7:i3Rkb5TII+ggtwYOkX9prSAWajkIwARclZuyPd7mEfVqu0yWZvV2m5A6ysZ+d5aT19/1OPT6k3WOlvGl75JYSzNmjmSRYMxgNrlB0+4K4IahNfKknFJ5GMRaTN84dgjbnAK3UHgVvuIBAlHanz3mgxng7vFPV/TV0p8MvyXOsXynp5V9QVAyQSZllTQE2AqD5F8MJ0wxZNspR26+f4LUB+WiTgaOwvu+KEdU7EOyq+qHV4/Bkw47000Aawe0sKfFWDsAPLVS2b72Z5JHaMBFSlhtFmDGyUMzRZFOU//P/4jApy9LoaFBHKGLpWDneXbyb/Y8u2zyB+RNCOjG0SGSL7KKifAbGAp20v1ju4Y3qy4= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB1569; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:BLUPR0701MB1569; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1569; x-forefront-prvs: 0098BA6C6C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(189002)(199003)(24454002)(11100500001)(3280700002)(305945005)(77096005)(122556002)(6116002)(3846002)(102836003)(68736007)(5660300001)(7696004)(586003)(66066001)(7846002)(8936002)(87936001)(2950100002)(10400500002)(3660700001)(7736002)(5002640100001)(92566002)(19580405001)(5001770100001)(105586002)(33656002)(106356001)(8676002)(2906002)(189998001)(50986999)(81166006)(76576001)(9686002)(86362001)(74316002)(4326007)(76176999)(54356999)(106116001)(2501003)(99286002)(81156014)(19580395003)(97736004)(101416001)(2900100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1569; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2016 18:04:32.1715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1569 X-Mailman-Approved-At: Tue, 18 Oct 2016 10:03:23 +0200 Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix icc build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 18:04:33 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Monday, October 17, 2016 5:12 AM >=20 > On 9/30/2016 3:45 PM, Ferruh Yigit wrote: > > When bnx2x debug config enabled, icc (ICC) 17.0.0 20160721 gives the > > following compilation error: > > > > .../drivers/net/bnx2x/elink.c(6682): > > error #3656: variable "fw_ver1" may be used before its value is set > > PMD_DRV_LOG(DEBUG, > > ^ > > > > According logic in the code, this error is a false positive, but since > > this is not in the fast path, fixing compiler error by assigning > > initial value to variable. > > > > Signed-off-by: Ferruh Yigit > > --- > > drivers/net/bnx2x/elink.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c > > index 149cc97..d9a72f0 100644 > > --- a/drivers/net/bnx2x/elink.c > > +++ b/drivers/net/bnx2x/elink.c > > @@ -6645,7 +6645,7 @@ static elink_status_t > elink_8073_8727_external_rom_boot(struct bnx2x_softc *sc, > > uint8_t port) > > { > > uint32_t count =3D 0; > > - uint16_t fw_ver1, fw_msgout; > > + uint16_t fw_ver1 =3D 0, fw_msgout; > > elink_status_t rc =3D ELINK_STATUS_OK; > > > > /* Boot port from external ROM */ > > >=20 > Since this is an compilation fix, I believe it is good to have this in th= e release, > can you please review the patch? Thanks! Acked-by: Rasesh Mody =20 > Thanks, > ferruh