From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0052.outbound.protection.outlook.com [104.47.34.52]) by dpdk.org (Postfix) with ESMTP id D96DA591E for ; Sat, 31 Dec 2016 08:42:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WNLzUHwlgL2R8w+oZSGsAC0Gsgka/FGUlW348XdiHHE=; b=cq9P4iG6EldoYnG3kKSrnMmX9wkdhYHCUIAbIG27mxHLAreyoJp+xQ9WTasxXFoIJ8ZkWoos4aWSA68lecExI0dtUlvJhGCYwiMKegWqG46w1O80fey0KWCboHbzJRL1Usm6D9kSvrrQ6sewOUF/XryHbjOGmbl9Zvn7Wg7OZ+s= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1570.namprd07.prod.outlook.com (10.163.84.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.11; Sat, 31 Dec 2016 07:41:59 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0803.021; Sat, 31 Dec 2016 07:41:59 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev Thread-Topic: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes Thread-Index: AQHSTUVksJIhsuHEOkCk7B5ZOoZZm6EVy8kAgAwE5uA= Date: Sat, 31 Dec 2016 07:41:59 +0000 Message-ID: References: <1480756289-11835-1-git-send-email-Rasesh.Mody@cavium.com> <1480756289-11835-24-git-send-email-Rasesh.Mody@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [2601:646:8180:be50:a927:9241:1cbf:1dc2] x-ms-office365-filtering-correlation-id: fe5d55eb-3306-469d-a883-08d4315080aa x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1570; x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1570; 7:0h19VBK4T24+2D/snXZC5qC5a1c1+tNW6YI8fowsom4zIybJnDL49KjNZA0ap2YEZPGf+dwsLXETkftcnrLflQpKMTHDOSbosj5MI239fn8uXQSjfK44pYuhXHZbLNijmJpSaaJFspFfsNKkwMQXLGy1k6QaqNSj7s8wzID98rlY+PIePxlNX+oUknsppcTQpk21AhwBJKE5jWNmtoDNM9turfZQU+gqCrsw5Gy4pdW1iOvKC5mu4gLOy17KBRflICBxZGmQMnW79XkMOx8KlmSErQ9Z53ckb9necd/jAZw5F/vTLd+CgAKFlHYTjMhg2WNypKsIUr7MpIb4T2AHy2vnP9vntZA9YBPYU/CUYH+9N19Q6Dpe1SdulzQb1zkDB8+U7XKjReYuKRLpJQBHU4h7+jcNN1da6UgDOJ+lIORkCZBMG1zUyZjOkaVcdzd0h40ZAUtqKNy0fcc79oUEOQ== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123558021)(20161123564025)(20161123562025)(6072148); SRVR:BLUPR0701MB1570; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1570; x-forefront-prvs: 0173C6D4D5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(189002)(377454003)(24454002)(76104003)(199003)(2906002)(50986999)(77096006)(8936002)(107886002)(81166006)(9686002)(81156014)(74316002)(122556002)(8676002)(189998001)(76176999)(54356999)(4326007)(6116002)(99286003)(102836003)(68736007)(38730400001)(229853002)(6506006)(2501003)(3660700001)(105586002)(5001770100001)(2900100001)(7696004)(6436002)(92566002)(305945005)(101416001)(106356001)(33656002)(4001430100002)(55016002)(3280700002)(25786008)(97736004)(5660300001)(86362001)(106116001)(2950100002)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1570; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Dec 2016 07:41:59.0393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1570 Subject: Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Dec 2016 07:42:01 -0000 > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, December 23, 2016 7:42 AM >=20 > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > This patch consists of semantic/formatting changes. It also includes > > comment additions. >=20 > As far as I can see majority of the changes are formatting, but not all. >=20 > Functional changes are hard to detect in this patch, what do you think > separating formatting/comments patches into another patch, so functional > changes can become more visible? There are few of places(ecore_hw_bar_size(), ecore_get_hw_info() and ecore_= init_cmd_*), where there is a bit of code refactoring. However, they are no= t a major change. We have tried to isolate most of the functional changes a= nd made them part of the separate patches as fit. I think, we can include a= bit of description in commit message to cover it in this patch. Please let= me know if you think otherwise. > > > > Signed-off-by: Rasesh Mody > > --- > <...>