From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0085.outbound.protection.outlook.com [104.47.34.85]) by dpdk.org (Postfix) with ESMTP id 1D980FBEB for ; Wed, 21 Dec 2016 00:25:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kDn5LyzhbL1J1sMq9nU5hVbyFBA1NfhX78zaopVkyTQ=; b=VoTOUAyfyOLzFiE70f63lQ19jmnQpOnq6tB38ye9cRT6Rsi5//bvy6Hx/ZSkMiN0LucA0tZLhpMeDrjLlphlyXaBz4bvT4In+cEfw2KA6l3iQVjhNIwgDdnVeEf18+aAFp7LpVThW/S/3Cw4uIQxf0vafCDYZw2AOCa/b/f+FSY= Received: from BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) by BLUPR0701MB1572.namprd07.prod.outlook.com (10.163.84.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Tue, 20 Dec 2016 23:25:44 +0000 Received: from BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) by BLUPR0701MB1572.namprd07.prod.outlook.com ([10.163.84.146]) with mapi id 15.01.0789.018; Tue, 20 Dec 2016 23:25:44 +0000 From: "Mody, Rasesh" To: Ferruh Yigit , "dev@dpdk.org" CC: Dept-Eng DPDK Dev Thread-Topic: [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info Thread-Index: AQHSTS9vpIt7Qkr1Xk6WAFViFPAF1KD/p98AgAocMSA= Date: Tue, 20 Dec 2016 23:25:44 +0000 Message-ID: References: <1480746909-25686-1-git-send-email-Rasesh.Mody@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 4c5c1af4-0955-4a24-dc90-08d4292f8585 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1572; x-microsoft-exchange-diagnostics: 1; BLUPR0701MB1572; 7:NWz3IIXz+4dOKTAnY6/NxyFes1ZvUMfl6P3cppEoITyG9L4XiRN36/Agf7yZIFYSwN1or8gciqTx6yKJuIh8hUW+TjC15jbJop9zN3q2AfnRwxnhrXgMGuSJvmZJHA/hm/F+UJj3U74ZwflB2XspFQBGXzQa+B2Xa9Ev8m/B8uIH2mc9kxto6BqYzWAtkgAM6ir/wBbdFXkzMQAPwZGDfkUs2KT/g5URbYFgq0PK1UlxB+jd6RsRnh0O1akm6tlVW4HIBh7tq3wayh9fQ3Lv03CoSoLczDr7+FKstZFLU3ARxoAyTp7OwbgBodwIe6sumt5Pv+SvFQUXS4ft6xyOzMxKGg6VWVvjpX9rOD3tkAh87TyP0024Z24wHkX3SbW+gM8Hb/Ds/cedeQYTApK0w6OtERQxpZrPkg97Lk9JqhgZG2LN2gRbq/uOG8Q67H8ej2hlx4AVDb3bQ4wsJ8xOWw== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(6072148); SRVR:BLUPR0701MB1572; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1572; x-forefront-prvs: 0162ACCC24 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39450400003)(43544003)(377454003)(129404003)(24454002)(189002)(199003)(189998001)(2906002)(92566002)(3846002)(3660700001)(6116002)(2900100001)(107886002)(6506006)(229853002)(6436002)(76576001)(102836003)(38730400001)(105586002)(99286002)(5001770100001)(97736004)(77096006)(86362001)(106356001)(106116001)(54356999)(9686002)(25786008)(101416001)(68736007)(5660300001)(122556002)(305945005)(8676002)(7696004)(66066001)(8936002)(2950100002)(3280700002)(2501003)(7736002)(33656002)(4001430100002)(76176999)(50986999)(81156014)(4326007)(74316002)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1572; H:BLUPR0701MB1572.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2016 23:25:44.4595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1572 Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to get vendor/device id info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 23:25:47 -0000 Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Friday, December 09, 2016 5:36 AM >=20 > Hi Rasesh, >=20 > On 12/3/2016 6:35 AM, Rasesh Mody wrote: > > Fixes: ec94dbc5 ("qede: add base driver") > > > > Signed-off-by: Rasesh Mody >=20 > Related to the commit logs of this patchset. Many people, including me, > won't know technical details of your driver as you do. >=20 > From below patch, I also can see vendor_id and device_id get, which were > not there before. But I have no clue why? Or what happens when you don't > have them, or what works fine when you have them. > Overall a little context helps a lot to understand what is really fixed, = and what > happens if not fixed. The vendor_id and device_id are used to determine device type. If you don't= have them, then check for determining device type fails and is always set = to default device type. Hope this helps. > For example in patch 8/8, it is a one line easy modification :), but ther= e is no > way that I can understand what really it does, but commit log comes to he= lp > there, and describes it really fixes VF over legacy PF, by VF asking a FW > overwrite instead of failing on PF reject msg. So patch subject can be he= re: > fix VF over legacy PF. Sounds good, will reword the subject. > Please trying to provide more context on fixes. >=20 >=20 > Also you need to add CC:stable@dpdk.org to commit log, so that git send- > email ensures this fixes also sent to stable trees. Will take care of this in v2 submission. Thanks! Rasesh >=20 >=20 > Thanks, >=20 > > --- > > drivers/net/qede/qede_ethdev.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/qede/qede_ethdev.c > > b/drivers/net/qede/qede_ethdev.c index 9c2a5eae..b9a325df 100644 > > --- a/drivers/net/qede/qede_ethdev.c > > +++ b/drivers/net/qede/qede_ethdev.c > > @@ -2071,6 +2071,10 @@ static int qede_common_dev_init(struct > > rte_eth_dev *eth_dev, bool is_vf) > > > > rte_eth_copy_pci_info(eth_dev, pci_dev); > > > > + /* @DPDK */ > > + edev->vendor_id =3D pci_dev->id.vendor_id; > > + edev->device_id =3D pci_dev->id.device_id; > > + > > qed_ops =3D qed_get_eth_ops(); > > if (!qed_ops) { > > DP_ERR(edev, "Failed to get qed_eth_ops_pass\n"); > >