From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0136.outbound.protection.outlook.com [104.47.36.136]) by dpdk.org (Postfix) with ESMTP id 795D039EA for ; Fri, 8 Jul 2016 01:00:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qlgc.onmicrosoft.com; s=selector1-qlogic-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NJCDCqQY5iG/8h2XZjB1xSof9PNT+dHIZwlI0c185T0=; b=NprAJ6J1r3pM95SDAJqlOpUeJrc1fLzMjIZOhoLu1omkgcy61UeP5waTI+jJRifRDB8jDwFphMQ9VE68YGum8H6xrhmSeG2uI1vf+6zahLuegVc4s3Bhra0T4I3iFAxCBX8iQcSDoMU7+9sK1BxYzxpfpCwPkHh130tyl8QaFnw= Received: from BLUPR11MB0370.namprd11.prod.outlook.com (10.162.91.11) by BLUPR11MB0372.namprd11.prod.outlook.com (10.162.91.13) with Microsoft SMTP Server (TLS) id 15.1.534.14; Thu, 7 Jul 2016 22:59:59 +0000 Received: from BLUPR11MB0370.namprd11.prod.outlook.com ([10.162.91.11]) by BLUPR11MB0370.namprd11.prod.outlook.com ([10.162.91.11]) with mapi id 15.01.0534.020; Thu, 7 Jul 2016 22:59:59 +0000 From: Rasesh Mody To: Remy Horton , Thomas Monjalon CC: "dev@dpdk.org" , Olivier MATZ Thread-Topic: [dpdk-dev] xstats performance Thread-Index: AQHR0hyDgcdo+/1aRkGeWCiordEWf6AAm18AgAAKMgCAAqhsgIABAemwgAbAIICAAO140A== Date: Thu, 7 Jul 2016 22:59:59 +0000 Message-ID: References: <5773EB79.1090509@6wind.com> <8870166.MVVViF2IlQ@xps13> <99e03d76-b896-2146-274c-2f3d83eee899@intel.com> <2488e9da-d0a2-598f-25e3-e68293c082fe@intel.com> In-Reply-To: <2488e9da-d0a2-598f-25e3-e68293c082fe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasesh.mody@qlogic.com; x-originating-ip: [173.186.134.106] x-ms-office365-filtering-correlation-id: 2011e655-a988-4c23-71c4-08d3a6ba6c29 x-microsoft-exchange-diagnostics: 1; BLUPR11MB0372; 20:m6/ClQxz1ppw5sMRQ9BFqBQ3X2jNOoXg0ZuJ85d4zMI3WMOvRa6R1vMEWSBWi1wTA7PRKm8B7GsBMRvjueHIKdRK1yKcjHYLHxeWr7yGHp5MHubT8wey1JKOo+H5hWOHZjNfY5o3owjnTWYfocsjYNukPq4zHnRThh4C8Vx1xYE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR11MB0372; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BLUPR11MB0372; BCL:0; PCL:0; RULEID:; SRVR:BLUPR11MB0372; x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(199003)(24454002)(189002)(377454003)(81166006)(5003600100003)(93886004)(8676002)(66066001)(7736002)(4326007)(77096005)(7846002)(81156014)(122556002)(54356999)(76176999)(2906002)(7696003)(305945005)(68736007)(86362001)(76576001)(8936002)(99286002)(9686002)(92566002)(105586002)(97736004)(5002640100001)(10400500002)(87936001)(11100500001)(3660700001)(3846002)(6116002)(3280700002)(5001770100001)(19580395003)(19580405001)(106356001)(106116001)(189998001)(50986999)(2900100001)(2950100001)(101416001)(586003)(33656002)(102836003)(74316002); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR11MB0372; H:BLUPR11MB0370.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: qlogic.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2016 22:59:59.5262 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR11MB0372 Subject: Re: [dpdk-dev] xstats performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2016 23:00:01 -0000 > From: Remy Horton [mailto:remy.horton@intel.com] > Sent: Wednesday, July 06, 2016 12:44 AM >=20 >=20 > On 05/07/2016 19:10, Rasesh Mody wrote: > [..] > >> For all the current drivers xstats_names[idx].id=3D=3Didx so it would > >> just involve removing the references to the id field and updating the > >> documentation. Complication is coordinating with QLogic for the bnx2x > >> & qede xstats patches. > > > > We could incorporate this change in our re-submission. >=20 > The changes mentioned above have been merged in, so go ahead.. :) We have submitted the QEDE and BNX2X PMD xstats patches with recent API cha= nges. During the xstats change verification, it was observed that the order in wh= ich xstats names are fetched don't seem to match the order in which xstats = values are fetched. When populating the xstats names, we order them as driv= er specific xstats names and then standard stats names. Whereas, while popu= lating the xstats values, we populate the standard stats values and then th= e driver specific xstats values. In rte_eth_xstats_get_names(): xcount (or cnt_used_entries) + cnt_used_entr= ies/count (RTE_NB_STATS + (dev->data->nb_rx_queues * RTE_NB_RXQ_STATS) + (d= ev->data->nb_tx_queues * RTE_NB_TXQ_STATS)) In rte_eth_xstats_get (): count (RTE_NB_STATS + (dev->data->nb_rx_queues * = RTE_NB_RXQ_STATS) + (dev->data->nb_tx_queues * RTE_NB_TXQ_STATS)) + xcount Could you take a look? Thanks! Rasesh