From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5E6DA0548; Thu, 11 Aug 2022 17:34:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A9B4427F2; Thu, 11 Aug 2022 17:34:00 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id DED01410FC for ; Thu, 11 Aug 2022 17:33:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660232039; x=1691768039; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=y620qLNMcORBMA5/yo6K4uEUcpg4kvPJwA0OmTy7kHM=; b=UBN/uxhxjOwcmlAKO2HztORmRNB3agCLp0Y8S0DEPc9R2FZb8kYQU9sI S3ILZR0QduuyIbwuEj9DucgiWwJPuqjOJv1Zcn70GoMFAB5RqZQdVVQcP R62XZqp6+mOIn6kBaPDJ7tEzOdPo4+2YNgg7a5lF8WksteXzYybTZQZdT FVw/u4rL5qs2FI3JOvBoyu1TXzy0t/zMf1NReOZ5LybDt62lL/r3e8+QT 587EdtOPPOEj+IxkpMZnrgKVgnusw8293TxR/lkYyeOvYmV6O6ODljr5+ 8sJhARwuRGGNwt9ZPD8HmVgBAamj8SSQW2fw1a2GOfYJr+0XwETs99uxL Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10436"; a="271765245" X-IronPort-AV: E=Sophos;i="5.93,230,1654585200"; d="scan'208";a="271765245" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 08:33:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,230,1654585200"; d="scan'208";a="605586646" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 11 Aug 2022 08:33:57 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 08:33:57 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 08:33:56 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 11 Aug 2022 08:33:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 11 Aug 2022 08:33:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OidD/ZUyvdGfYH42K3qqG35FmGOKoLvW+VJF74xl6q4Z7GUyu2nHIwRBdWuJu41MZH3wvVLpZreGVvcs/uDJpm6BYf9Oh609WALAJ2qO/Ff/cBgIMk5jY4FilhnxNYS1YpGLwT4E95CGF23yvCIT60AD8U/V2hSx2GVOIlLUiDKElVWxvfZgId1UeP2i9iDjMFWHFPUJgXuLU9240oARz/HwtXBXhyLsWC+yB/f4Z04Z3RISj0vLrTZr3qLDHetyoIMmID2+x1Tl+kskmYlNQlnN5S0m0UJYC+DPZaVRBo/nofOOICfwaJFP2G5y3WA57U2MHJJhdKMAhFn2Nn6Z3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8lfeFBX8VFV1ZbZNyhbwBf8nUhfdeRm3lPYn1AhVH/8=; b=RQHqOowbSj4GirIWWyRsSKjt6CD3WTHF8gjwEjolpH9rX0HCjyKWxgU17oD3vfSvAl6OyidxiSMC7kEkbeNO9nYSefQfepcrXDjRuBDh3f5GsKV4OXda3KxFKXmTZTnkjQTutkan3mncDfklTvyXyIwTSNYMVB3oV2pAOAfHjmIx/kR/18jV+H7e4nvavMkhsWKaxkEPQpYVsy2QXJupRJsjGOuXikmEbpDg3vYY9yplHYVhIZHSjgx/fbz9YdkyWyML4YsqcVriRjTUvxze49cMgBRxkh452EhIkee3XCcwCLod1pPBFABCKRr1WKahTv5E1XEHbXQIe4v385Ms7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by DM6PR11MB4506.namprd11.prod.outlook.com (2603:10b6:5:205::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Thu, 11 Aug 2022 15:33:52 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::5439:a46a:461e:56df]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::5439:a46a:461e:56df%3]) with mapi id 15.20.5504.023; Thu, 11 Aug 2022 15:33:51 +0000 From: "Van Haaren, Harry" To: "Carrillo, Erik G" , "Naga Harish K, S V" , "jerinj@marvell.com" CC: "dev@dpdk.org" Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capability Thread-Topic: [PATCH v2 2/4] event/sw: report periodic event timer capability Thread-Index: AQHYrIg2K0ycNlZTu0egz4wq36+laq2onRGAgAE4u2A= Date: Thu, 11 Aug 2022 15:33:51 +0000 Message-ID: References: <20220803162634.3145885-1-s.v.naga.harish.k@intel.com> <20220810070943.3111058-1-s.v.naga.harish.k@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de11d0fc-769c-4666-8a07-08da7baee4ad x-ms-traffictypediagnostic: DM6PR11MB4506:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6NEOcSYVS83abZfPbqzyVAtQMSDYSl+cqPM4PNRM0jPJw0sptbNuE4/9Y4ubQoHSDVo3ASMAwDoIjaIuvIscbHCQRfCXimfm8KGy6Q8A75advYcXzQnwc7RuKOuI4VTnG83BKtw7RHkeyvJjcV8s5P3SJLmOjQoopGSEHSig9mtoixYkDvck6mveshFfupcoaYTGRfvUBhlTVlu2iUU+wGELmmfejDehJGXb4tLag1I5ncsiJwRMw0CEaUDl0xQ370m3L31+73lIW6u+OoGBuYpOH0H/XM5kTPm9rPyYqq2aBsbz+rzBWyEnry96v++P6H7uyuRLY8ByN7Ny4gaOOF41QI67chstZP5BRnJHbpdllMWva34JQI9OKCAiDzFtrWSJgYJv+qX2OZdokeHhCRzlDssBZM+nO4DWsi12KbnezTBk3ZmOJYqiSV0g0ikdIGHRKUKY1mMUaa1bKGeGfMNSsjkgK/ZIQbwTa3o2lp+hnaJYm3lW2DavmAsCUqHqtOlrRdPdgPMMDP2QwFTy7xC4qOc9PhqO+/ZWKQFxNi+25G5itU4g0RkS/sn4Njh1ieMayhNNdB3KMm21j5xCJ6BFDZdug8zbGZj2NaSB+Wf/s5p6cCzyryoU8KpK1wlhmtS4eO3VGueTfm7Pe98iAJ5oLkTGEk42AdZ9iStlO1CTFdkBqltYdYdiO1UdVYnI83n/Rj68zM5nyUQvPEtW1godmgY8nmmyg6YV+nb90uTBuS0I5daTe8j2Q28NmFfRBPSqoSCNl8IXZcy3DEw8djIHHqJNZ4s6sKilRXielPDVCAccsM7RWN6aB6eKnXf1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(136003)(39860400002)(396003)(376002)(83380400001)(64756008)(66476007)(66446008)(8676002)(38100700002)(66556008)(82960400001)(4326008)(76116006)(2906002)(38070700005)(66946007)(122000001)(52536014)(8936002)(71200400001)(41300700001)(110136005)(316002)(9686003)(5660300002)(26005)(478600001)(186003)(7696005)(55016003)(86362001)(6506007)(53546011)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IdyYo7fRABANxVrTjMyC6FGqNj22IJfR0vJIPwrb9j8YUfY9mutL3FjGiz2g?= =?us-ascii?Q?5wBHRzFr7TCZqTSCnZ8ro6Kx5GMTqgJr9g3m5T+scaA8fxcQHWP7uYaB7eAL?= =?us-ascii?Q?ymyUnUAljpCBTS7pYPNHv05Mttl1DBNn5GrN1peTwMx0zxEsQ+Fd20rSda/2?= =?us-ascii?Q?RL4R9Hsys2D/tPkhswOqOJcvXpi/if/Eu6FGhuzZaI7w43ge2H81eP2OaAZi?= =?us-ascii?Q?PlC3nBFhVfstiPBD8mNCOFvYn9m7z0U+LT30TlVZpx7yAD3v7lqkOAkAG5oK?= =?us-ascii?Q?kFbwu1It2wfafOmSWbJqMVc3no8tRdAnHohkwS8TUIstuLHlbGcuKB5YML+e?= =?us-ascii?Q?rWjw4vkqSYDDWjUArqme8zdoog5tAI7eFtpTpDTsfknscbJu+H92njLpiaCA?= =?us-ascii?Q?Q1/A80nQp9RkjkVHaH3YreIqcpSsiW6bD3ZRfx8BK1bGkVEQMqBYgxT/cyVM?= =?us-ascii?Q?VSULnl5IExVd7PZIohDTqPma5869gRKHJVjbzZB5QuLdwQDuT6l3cOKxKtoV?= =?us-ascii?Q?uTrDJr2ncAlM6wf/xcA2VZL95SjDJMdDp/lP4Qw8xNnr9e8GD4tKzD8obVAS?= =?us-ascii?Q?ccX9eixuL+UmDscdwleZWVqMC25OFKpl5qcavLIegiDQPjwm0glW+fXIm6rO?= =?us-ascii?Q?/rQgFWKmk4KfprRSi7Ou3TMbKTqsf5Wo82DtCG09YPbbFiGCcECyyWsHmKkj?= =?us-ascii?Q?x2YSbmvAo4rUz1oZtGJ2qyeiHcKnL2k/znC047xUaBXo2PZY/MSy6KMUp1a+?= =?us-ascii?Q?lw7yDYMhXHcIvDWZDNbhg7ycuq7tr6Cgdq/nWKlwOlon/vcJ3XgGZzOGx2CN?= =?us-ascii?Q?9sY0kDqDQdHs3e2QiMAeouRWq9pcNnyDe80lRMxJ8wF8/y6RBFw5v5S2NAiC?= =?us-ascii?Q?k84lRgVnzjJbX6S/PURP2eHKzDV0N2RfEcPiHDZWWvLvUrkHL6zfgQKeDwww?= =?us-ascii?Q?WNTz3/zjmaEU8Z4eBmHddgDZCEXKW2uuRXOynJ+RiN2ZS45/m5B1tJQyYPIM?= =?us-ascii?Q?ZQTL5FShJ/TghmqGkIlHAj9XwDH1AhlTyD1oo+wMK1n+jr/ZYHCfk32Sbw1/?= =?us-ascii?Q?Q05fxkd1kXEz49gzxT/WdIgAdk8M5fy/COR2mmBL4OoqvXxSLFLc/ZKVvRCs?= =?us-ascii?Q?7cyw4gP8iDeLnlM9LsPUD56tqs23j0EQs5CxtldXyiQNT4fnnA2ALJXk89td?= =?us-ascii?Q?0gcqVge8q7rTYiSTcBq8kC/MFAhthOxsCGqWsp3DOVqTjGWAo3cOmkjGOlsb?= =?us-ascii?Q?Rpf317mW2lllODaUvEQMijSDggBcbQLkX6P2i6tt3s0Gz3UMHwls2Nh2a9wR?= =?us-ascii?Q?Wbz0Wdmsp68/lCFWiIDfrsvd30JgPpk/1IWw0zboxjFn/ITuHC2ApdF/hUK7?= =?us-ascii?Q?UFIKaG9+TA43htuCKzLtEkKpUHQbDNKgY7MQXXtRlSOzyDQPCZ4TloTLI9EQ?= =?us-ascii?Q?IhM+O+mCnxY2wNCyikeuDZm/qIH4tkw5jkSvNfJNwA3E/gRXOdv3N9G+hUr9?= =?us-ascii?Q?+s7c2igUDfm96B1sSRnZY3FaWuRKzzUyNgrEkvO6zQYuvohVOJDJQlEgjMD7?= =?us-ascii?Q?oWUl++Arau50380dQHSnzDOEX0jerOp1OK8CiAzggRBmNs+CVYmtBMOB1SUZ?= =?us-ascii?Q?gQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de11d0fc-769c-4666-8a07-08da7baee4ad X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2022 15:33:51.7138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MjVo9AXf9WxbxK2m+jTclhJeA1Wsd29cCbQJTy+wAlW5WaQ8d5x24Gc7LWtUL8896HjMTpO9unzuw84n7F9UeOlLbNOdanVap27EGVS/Gs4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4506 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Carrillo, Erik G > Sent: Wednesday, August 10, 2022 9:52 PM > To: Naga Harish K, S V ; jerinj@marvell.com;= Van > Haaren, Harry > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capabil= ity >=20 > Hi Harish, >=20 > > -----Original Message----- > > From: Naga Harish K, S V > > Sent: Wednesday, August 10, 2022 2:10 AM > > To: Carrillo, Erik G ; jerinj@marvell.com; V= an > > Haaren, Harry > > Cc: dev@dpdk.org > > Subject: [PATCH v2 2/4] event/sw: report periodic event timer capabilit= y > > > > update the software eventdev pmd timer_adapter_caps_get callback > > function to report the support of periodic event timer capability > > > > Signed-off-by: Naga Harish K S V > > --- > > drivers/event/sw/sw_evdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c > > index f93313b31b..89c07d30ae 100644 > > --- a/drivers/event/sw/sw_evdev.c > > +++ b/drivers/event/sw/sw_evdev.c > > @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct > > rte_eventdev *dev, uint64_t flags, { > > RTE_SET_USED(dev); > > RTE_SET_USED(flags); > > - *caps =3D 0; > > + *caps =3D RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC; Thanks Harish for the explanation as to why caps are exposed in the Eventde= v PMD, for related timer/etc features, makes sense. > It looks like we can add: >=20 > #define RTE_EVENT_TIMER_ADAPTER_SW_CAP \ > RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC >=20 > to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP, for > example), >=20 > and use that definition here, and in rte_event_timer_adapter_caps_get(). >=20 > Thanks, > Erik Erik, I like the suggestion of a standardized set of "generic SW" caps flag= s at the Eventdev level, and then all SW based PMDs can use that #define, avoids each new cap needin= g changes in multiple drivers. Good work, -Harry