From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E6E2A00C2; Thu, 13 Oct 2022 10:59:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB33410F2; Thu, 13 Oct 2022 10:59:11 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 308F040C35 for ; Thu, 13 Oct 2022 10:59:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665651550; x=1697187550; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=M4aOypdmqRTAZLRddEUAy9uH7GOvnYnvqkDGsQWlSOc=; b=DQVIiNAex1Ao2HEVf9u8HwlSPaFT9gW6ylkEMAc3BdJOT20gcZx5W3SJ QsTBOQmlQYOssOxDqkAB4ic6oxM/WQDAHbnm7sAUCLZ1CINlfv/loSIFU 0bA4Kiny3O98qu40WWqvXFkcUVR8OA2LThovDo/mEz7J/WqGsFqFBuojm P6V4oC8NITKXuhziURqjj55DDWOmOMqDQFySc/yLWJP7iIuU4Vo+PCcby a78KZvwr6nhcxfOnIr1qT4bbycJB/TwG9NiFayqVfBhJerUtBqu326ReM prbyDn1VUlMggX4xUCzuoNiIBeTO2HMvr8h1cJksLth0e5jJREPcoWsdH Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="369193212" X-IronPort-AV: E=Sophos;i="5.95,180,1661842800"; d="scan'208";a="369193212" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2022 01:59:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10498"; a="769538246" X-IronPort-AV: E=Sophos;i="5.95,180,1661842800"; d="scan'208";a="769538246" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2022 01:59:08 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 13 Oct 2022 01:59:07 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 13 Oct 2022 01:59:07 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 13 Oct 2022 01:59:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aELT+vkyqOlc4S0rQFK6+LlPcysI7MgBeHSGTQ5kuudDXxSKkOEweHO1MPHbcVKUhhQyOI9x/tO/Yy3IHWQrWjkEFkrUnhI5MG6lbw14yFDTMGTEfcV1MqrFeOqLesRe4j1Pob34wdFl1bI1V9ftFBEOiUGJO70+g/osjGvwi3xUy4o2+zeneCvg+3DTe4w36MaIUNnVKm9NOdoIfY6wLDF7DwlEML1YKQyZKgMrrwbhe2vrKY0kZKEjcpIkalVjLm6V1LrbYChW/2vRsQRKIe3iNuCBWErlLBYI9RbtMccaRaLersaUK4C4JsVS+2GqTAUyf+uDG+94tEOcmlTBSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DajG2vbojpiOMFpQnsqw4iB+JwD5Mv/+2oijEkm09gQ=; b=JSKWUMM0Tg7tPjzdAKarX3v7dLwOFeDeWxuVYqgeq+TzT+FuKw2NbkWANZIXfWrs9LuZkwELuQzXVmKsc7deG9pIKA03Xp58ZUWrTjv8stYzqQGOtE3qiqsAwcQy31f68DBnojrWHVokDTdzsXRLu3wiw/QdyAFCKNX3yk1TSrBQEgcAljnaWkVRYGJEFN9HB1UZ8el+jHxYWBOFt60jQRn9ep1lqvHDWiQfPg67UjyU1cwdrpDv2YDc64wNa/RmKvZkPHoiIkCLNEQf0P5BE+Dgu9rAX5D0jMjqrOeL37SYmgR2+fR2Qo2C5BQ3vN9RdVF6qq/w/9tYntYZ/Nsrkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by BL1PR11MB5272.namprd11.prod.outlook.com (2603:10b6:208:30a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct 2022 08:59:05 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::8938:3719:8c0f:ff97]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::8938:3719:8c0f:ff97%6]) with mapi id 15.20.5709.022; Thu, 13 Oct 2022 08:59:05 +0000 From: "Van Haaren, Harry" To: Pavan Nikhilesh Bhagavatula , =?iso-8859-1?Q?Morten_Br=F8rup?= , Thomas Monjalon , Jerin Jacob , Sachin Saxena , Hemant Agrawal , Ori Kam , Liron Himi CC: Jerin Jacob Kollanukkaran , "dev@dpdk.org" , "Li, WeiyuanX" , Ferruh Yigit , Andrew Rybchenko , "david.marchand@redhat.com" Subject: RE: xstats id type Thread-Topic: xstats id type Thread-Index: AQHY3tB8di3q73x98kCsOkV+XPhOja4L6LWAgAAaZiA= Date: Thu, 13 Oct 2022 08:59:05 +0000 Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk> <6614700.R56niFO833@thomas> <8405275.Sb9uPGUboI@thomas> <98CBD80474FA8B44BF855DF32C47DC35D873DA@smartserver.smartshare.dk> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN0PR11MB5712:EE_|BL1PR11MB5272:EE_ x-ms-office365-filtering-correlation-id: bdbb3e83-dcf7-40fe-4943-08daacf92eb8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dAExcOxkV92Ghs1YynwKgM9iiw2j1bvZ6jpmOdatNYXG25wXb1X8uEVyN4kkRmHTz7cxVPsS60/kGz59b8iyT3EAW3Hm7xIRyXDLeXYqIYPDJtuXkoYym0BdHNuKpPkd9HPW9nVJK/cUmXVQAE34KzGrP1EAD2nsCyNYZiqObM6FYxZHmN0oJdDrJErPqQobyAUU2PmlUrZ6WCATAcWuxF8sW/x1KRO9kpH8CpWa5FHVqgTdBmLa27jF2vq58El2WYavB5TPAsd96v5H13cus7DPsOvYCK/aLCuDZlEzxGa1zzC5YQ8pOSPXtN3GMkMwJUM6Lp3I7YI6zO/nnQJPQDuYeYZ8YxfnaHw/P6tdkyHyVnug4MzzaGpD6dxg4AeWTdsrswS/SPXj2bwOjbB21T72ZNFhLcAKFuKrawSxVso69caV8xyx8tPxrymRII6MYyGFjCKx4k+tEHGiuwxmmOdcSsOjhPsDEGJMGnkKA5l9GFEJarsrD2Ex5fDIxOXnVuLusul+HnGQE3BMipXlujtMOs8v9r5Ycp7oNWxa2ZjisL4G7wh0K+KMqttws4dPsEbSNlSCDb51kooXNbFkDRROJWhfalAPNCZIjWA0LvXdG0I6uQLeVJOLMsD4ufPIB9InzhxWhFwQeDGruhpUqu+dD2kU1VWAQkZ8oAZRO8/uSBQnmwlNMi8o3q3AhBW/uwMx0356DkLWMsbdRi17kcKJv2eF2JExBXoFpqySCMcX2WccAt8wZrMK/XcquZteH6n5JnBnzMigOTP8eo397Rpol2mnwmisShnGiDiOc0VkEFPD9w45oArR6VZSpLftrzcBG2UDokVDT0BdqXfVd07U8+szLMS8vMjSiBfM9IQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199015)(66574015)(26005)(53546011)(6506007)(83380400001)(54906003)(86362001)(38100700002)(7116003)(110136005)(41300700001)(7696005)(8676002)(64756008)(66446008)(66476007)(76116006)(66946007)(66556008)(7416002)(4326008)(82960400001)(2906002)(186003)(33656002)(5660300002)(52536014)(9686003)(8936002)(19627235002)(55016003)(316002)(71200400001)(478600001)(122000001)(966005)(3480700007)(38070700005)(69864005)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?enNan0dD5VdFEmcDMcRdd03f37HbrvccgK+Fc9UmK3c+r0Nu0YgOf1YG1d?= =?iso-8859-1?Q?XkgeBhMOWmfGy9XTKTc5mn12SAWgZSwcQe7oJMWvPT7/vfqKNAvqTJZlJN?= =?iso-8859-1?Q?QEuZOYM4b8zsUIGjdUP4QN7zjyKMuax8reccIfPMSbIpmFmUU/WLlT90QI?= =?iso-8859-1?Q?IsyUywu+IFuZClGiFnXNpG2AOT47qFWRSbNvflqmFdZX5BSmM/6wBhgeHd?= =?iso-8859-1?Q?tKIZgCR9gO4aaHJEnw3Oeg9Mbnyj3dkIF85TreP1pFj04D8oqkVzaH6Sy7?= =?iso-8859-1?Q?ukPMsNKmAuaJ9Xs+hIGzs5gWktQAssn4WQz5OfhmzlBr16Ou4qJPNRR/+R?= =?iso-8859-1?Q?xCzNmTVrGYPp07RKZ2paIUGwd0aTH3brRnUVQ7MlZqneWxucmSy2hxh8s6?= =?iso-8859-1?Q?5Ji3SHhLXbghV732cFNyRBI9+dWlHejtwaz/oinJ54P/lMxhQuNMSX+KOr?= =?iso-8859-1?Q?48c3/Uf2n/MDOg2I8jH3ClskTJdcXZU5Vcl5ukHRfM2NnhQkZL2uJ3kNou?= =?iso-8859-1?Q?3u39sg82x3azZQ4fyZcpBAluzh36OKSN4JjC5z8MU+gVGUZYg6CVTChxy0?= =?iso-8859-1?Q?dAxYMZcOMY/sDF4BuwMYq/VnOldHFCfoRsxkCirYdcB90OGw6eDGMvXRvy?= =?iso-8859-1?Q?bIp9K+wCar07jZtFqk2poSK8veUTLuxx+cc5Al9EMkjfTWUi7f/pPxfIV7?= =?iso-8859-1?Q?yGDVBqHJ6yL4lF/pvr5WD6buA2aeGRzidFOrNFgL72Z3+VzLaOFDQqYC/j?= =?iso-8859-1?Q?VsnRgQrW7W20l6QGwo/5Ksj8pdu2Qx7dP3+AJalOU7/mOS72U4/1QwcoIl?= =?iso-8859-1?Q?LViVXf2uzD0EYVPCkdpXbgdVhMg4/isemuyevjWJlzMhjeXdWqBTqYEYbl?= =?iso-8859-1?Q?1ous31xSa2WHRs87/EOhq0HsD3J+SKRfrjWqiqEoJYcpQnUs/oF8JkAhMS?= =?iso-8859-1?Q?e84J3peIbYQKVCJIzb5Sp/g7v+bLcXd9+qipOqNlPKWCC0cXS44JoQYliX?= =?iso-8859-1?Q?sxVo2QTcILLGZUh3YXURP+nfg2NrOObTPvU8a/LJoj3QF4qZ3FhmBZH0Mf?= =?iso-8859-1?Q?CsGo2gqD52Ha3iNcX0+SOA8S8odYnmiIDvINMdOI9nj1xCVz2EOksbSSYK?= =?iso-8859-1?Q?si9fzaTDtQVdo0TjuSnvli/ldqapS9P8Ils8R3QgWGoVrF0YwQHQYjm+rv?= =?iso-8859-1?Q?8TbAyoDnj7kH50Hz1TdDPCCgh0DarjXLK02a3ewFhzQb+KpeDJwMnCjMpX?= =?iso-8859-1?Q?YhPPuReJYMNhGUR1e3QLMv2b3BL6Aj4wr+4Nt9+u4NnAlZH65DBQkoxLNB?= =?iso-8859-1?Q?PayTnbwvK6aaaQ/1Iw9+Ip6MBipqvlkSRsJXjOjYMaDAuN4K9PfoYbb8O7?= =?iso-8859-1?Q?hg4zbf+h59XGjkO6xsKc9wgKh0WZe3mvy7p9MMEwmnJtg9AJgpQq2tibUG?= =?iso-8859-1?Q?B90N11+ie+JDbt1huNAh+Nfg5H6eQg64MZsrvvG/xaN8pq5vVO13zalxqH?= =?iso-8859-1?Q?G+lvS/a5Yym7Xy8mCgBA+gTTaBtwf2MtJ8ZJwwRxJvzuietMz8LYqyRHMm?= =?iso-8859-1?Q?Khuk9ZvnunysYx1NfX6IATnCecRNaFylfM7TH8xRQFu0sd/L9+1I2lKdsK?= =?iso-8859-1?Q?/jvlXlzsLPMw3NjrP3GlLm3y1iWO1A1FDU7Xdn0ABoBPPmBoFcOdQFOQ?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdbb3e83-dcf7-40fe-4943-08daacf92eb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 08:59:05.6697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0P2O8O7uLmgEXYURIuagJbAy5U+NB5TTdQSLzKs+GH+t54MF8crMnDESvDC9bm7cCtkqhJbMjrY8gRw3VQ83w7Q/CEOvl1dMZkJAjBE55ek= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5272 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, October 13, 2022 8:13 AM > To: Morten Br=F8rup ; Thomas Monjalon > ; Jerin Jacob ; Sachin Saxena > ; Hemant Agrawal ; Ori > Kam ; Liron Himi > Cc: Van Haaren, Harry ; Jerin Jacob Kollanukk= aran > ; dev@dpdk.org; Li, WeiyuanX ; > Ferruh Yigit ; Andrew Rybchenko > ; david.marchand@redhat.com > Subject: RE: xstats id type >=20 >=20 >=20 > > -----Original Message----- > > From: Morten Br=F8rup > > Sent: Thursday, October 13, 2022 12:22 PM > > To: Thomas Monjalon ; Jerin Jacob > > ; Sachin Saxena ; > > Hemant Agrawal ; Ori Kam > > ; Liron Himi > > Cc: Van Haaren, Harry ; Jerin Jacob > > Kollanukkaran ; dev@dpdk.org; Li, WeiyuanX > > ; Ferruh Yigit ; Andrew > > Rybchenko ; > > david.marchand@redhat.com > > Subject: [EXT] xstats id type > > > > External Email > > > > ---------------------------------------------------------------------- > > +TO: rawdev maintainers, regexdev maintainers > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Wednesday, 12 October 2022 22.44 > > > > > > 12/10/2022 18:47, Jerin Jacob: > > > > On Wed, Oct 12, 2022 at 9:58 PM Thomas Monjalon > > > > > wrote: > > > > > > > > > > 12/10/2022 18:16, Jerin Jacob: > > > > > > On Wed, Oct 12, 2022 at 9:05 PM Morten Br=F8rup > > > wrote: > > > > > > > > > > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > Sent: Wednesday, 12 October 2022 17.13 > > > > > > > > > > > > > > > > 12/10/2022 14:14, Van Haaren, Harry: > > > > > > > > > From: Morten Br=F8rup > > > > > > > > > > From: Van Haaren, Harry > > > [mailto:harry.van.haaren@intel.com] > > > > > > > > > > > From: Jerin Jacob > > > > > > > > > > > > On Wed, Oct 12, 2022 at 1:40 PM Morten Br=F8rup wro= te: > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Jerin (eventdev maintainer), > > > > > > > > > > > > > > > > > > > > > > > > + harry.van.haaren@intel.com as the changes in > > > > > > > > drivers/event/sw. > > > > > > > > > > > > > > > > > > > > > > Thanks Jerin. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > While looking into bug #1101 [1], I noticed a mix > > > of unsigned > > > > > > > > int > > > > > > > > > > > and uint32_t in > > > > > > > > > > > > the test code, which will fail on 64-bit big endian > > > CPUs. > > > > > > > > > > > > > > > > > > > > > > Aha; that we can fix. I am curious why this isn't fou= nd > > > in > > > > > > > > CI/reported > > > > > > > > > > > before. > > > > > > > > > > > > > > > > > > > > We probably don't test any 64-bit *big endian* > > > architectures. Just > > > > > > > > a guess. > > > > > > > > > > > > > > > > > > Seems so yes. > > > > > > > > > > > > > > > > > > > > > > Specifically, rte_event_dev_xstats_reset() is > > > called with the > > > > > > > > "ids" > > > > > > > > > > > parameter > > > > > > > > > > > > pointing to an unsigned int [2], but that parameter > > > is a > > > > > > > > pointer to > > > > > > > > > > > an uint32_t. > > > > > > > > > > > > > > > > > > > > > > > > > > I think the type of the ids array parameter to > > > > > > > > > > > rte_event_dev_xstats_reset() should > > > > > > > > > > > > be changed to unsigned int array, like in the other > > > > > > > > > > > rte_event_dev_xxx() functions. > > > > > > > > > > > > > > > > > > > > > > In this case, we have the option to change the type o= f > > > a variable > > > > > > > > in a > > > > > > > > > > > test-case, or change API and cause API/ABI breakage. > > > > > > > > > > > > > > > > > > > > Well.. yes, but I would phrase that last option: Change > > > the > > > > > > > > API/ABI, so related > > > > > > > > > > functions consistently use the same type for the same > > > variable, > > > > > > > > instead of randomly > > > > > > > > > > mixing uint64_t, uint32_t and unsigned int, depending o= n > > > function. > > > > > > > > > > > > > > > > > > Aah ok; I see your point now; there is inconsistent usage > > > of > > > > > > > > uint32_t/unsigned int > > > > > > > > > between the Eventdev APIs itself. Agree this is sub- > > > optimal, and > > > > > > > > would have been > > > > > > > > > nice to have spotted before the Eventdev API was > > > stabilized. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Unfortunately, these functions are not marked > > > experimental, so > > > > > > > > breaking API/ABI is > > > > > > > > > > hard to do. :-( > > > > > > > > > > > > > > > > > > Agreed again. > > > > > > > > > > > > > > > > 22.11 is a breaking release, > > > > > > > > and changing type in the API is not much impactful, > > > > > > > > so that's something you can change now, > > > > > > > > or be quiet forever :) > > > > > > > > > > > > > > Question: > > > > > > > 1. Only change the "xstats id" type in the one eventdev > > > function, which deviates from other eventdev functions, or > > > > > > > 2. Change the "xstats id" type for all xstats functions acros= s > > > all device types, for consistency across device types? > > > > > > > > > > > > > > If 2, then what would be a good type? > > > > > > > > > > > > +1 for second option and the type as uint32_t > > > > > > > > > > > > > > > > > > > > Ethdev uses uint64_t for xstats id, and (speaking without > > > knowledge about its internals) that seems like overkill to me. Arrays > > > of these are being used, so size does matter. > > > > > > > > > > uint64_t is not overkill if you consider having stats per queue > > > with a predictable scheme. > > > > > That's an improvement I would like to work on, > > > > > > > > You mean to use a bitmask hence uint64_t. > > > > Currently it is mapped as arrays so 2^64 stats may not be needed. > > > > > > > > No strong opinion, I was just curious to understand "stats per queu= e > > > > with a predictable scheme" and how uint64_t helps with that. > > > > > > Yes I mean some bits are used for the queue number. > > > Something like in slide 11 of this presentation: > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp- > > 3A__fast.dpdk.org_events_slides_DPDK-2D2019-2D09-2DEthernet- > > 5FStatistics.pdf&d=3DDwIFAw&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3D1cjuAHrGh74 > > 5jHNmj2fD85sUMIJ2IPIDsIJzo6FN6Z0&m=3DApdcbroZzSNlcY1t4c8iv9HZk6YSJOA > > Hpg93zuyIEEWa6xkViBTdoCA3iir_FCtW&s=3DwEMA0lnyrTmxmmDINhzOagGvV > > Z3TcIrzfK5NbJHafdM&e=3D > > > > With this presentation in mind, I strongly agree with Thomas that uint6= 4_t is > > the best choice of type for xstats id. > > > > A quick search shows that both eventdev and rawdev use "unsigned int", > > except rte_event_dev_xstats_reset() and rte_rawdev_xstats_reset(), whic= h > > both use uint32_t. And regexdev uses uint16_t. Other device APIs don't = have > > xstats. >=20 > Harry, > Are you working on a patch for this change? If not I will do it. Please go ahead - I won't find time in the short term. Thanks Pavan. > Thomas, > Are you ok to break the ABI without deprication notice i.e. make ID as u6= 4 for > eventdev? >=20 > Thanks, > Pavan.