From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC8CCA04A4; Wed, 2 Mar 2022 09:34:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64CA64014E; Wed, 2 Mar 2022 09:34:06 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id A54C840141 for ; Wed, 2 Mar 2022 09:34:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646210043; x=1677746043; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4NqjuqD5jAsB+BZIrxIQ6BYffjOmbbLwP6XB+h9SLyw=; b=NRdYoaUbT+K3ee1rJV4GZF9tpYcszMzEnRlA/8qzJ+X3H09KBChPsn1L D9g/hTCd0Hnasj9qIshWSg6pfaALez1h65N20Hwl+5ImKXKp0V9o+N12U wnVoVq615hX5XXtPrnJsLLe4ow9U+XtSXI0bt59WxzmRUJr5AkZ8kf3tR UQ0LS+njJi3EcRkiLSGLNuGFOm3H5pbcXPUfs4VyUZh2jm1iImz5uI1LR DRA0DAQXGQCC32Kv27PDPg9tiOOV27VhNFQd3ewNi0CS+4mzhdnJXCnJ0 XTy8rheaUBw/Wju33Q07sr5NSAjwcWkjEWo18TuTd156EYclpyr5lwyvF A==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="278016326" X-IronPort-AV: E=Sophos;i="5.90,148,1643702400"; d="scan'208";a="278016326" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 00:34:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,148,1643702400"; d="scan'208";a="508123487" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 02 Mar 2022 00:34:02 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 00:34:02 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 2 Mar 2022 00:34:02 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 2 Mar 2022 00:34:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nv6zIbWMVx9CkKt6+EfEC3qeFosrRrUSh57B52xpQ0nD4NqyxWDFUBesUufrEwQ58cOKhbd0Hlp9AY0/J4sqkIkkFe6YYdIc5tfQ6CIVpND0k73bJAEx0aI88mtttZLChFn9ZJQf392qKMKB5knsglwI755F1qKQvmimxyMD5+rwkDZxqloXavuKt2Sh375WBvTKN6DSL0Om75+0Cv+uZ0UOXD8ZN8gTFO+pcatH7mIU+bdkULrV1f9vqc7lRPWHQz2dEi/qygdTs0MvCYqtMrPMQBiIovLchhcfp4VLlJWd0OcRiiIo7u5HYbzyvwj+qZldLHtyfHNAn/Ow+58H8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C5rh8NhHpIBP6VnMx4oweJ4FpYNCk7hq3xdCl/Nzysg=; b=YYUnwLqcl4mOxQt0Ae5oRfQPe3U6EhirJJlcPzLxakZTHakpikXtIg5zPzRyKAwmrsQpGEN5z3UilXWq1YjrFjo0Q7l+ySTVmKDxuBFMLnBUFC4EDhE3/ea2MC0V96oH33ul4x/sJ13P4Lw6cTxhqgizV8rCyddsVxPc8KTKEcxNv8PnTEnCbRY800iKPkTvmZz41WbGAztxUuAOF4EAcymQaehgaSws0KtdPhgFULGFtvBgahkqD7vUJw8zoxDede7a+fFVWYgX/OCPCqvtM74fRtd8hsbo4djRm7Umiwp/PN9UGZRo3TsJBJT/fRvfxzRGWuEaAkqRYScqaG7Ucw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by DM8PR11MB5719.namprd11.prod.outlook.com (2603:10b6:8:10::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Wed, 2 Mar 2022 08:33:59 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::345c:23ac:1aa3:5b4c]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::345c:23ac:1aa3:5b4c%4]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 08:33:59 +0000 From: "Huang, ZhiminX" To: Ori Kam , Alexander Kozyrev , "dev@dpdk.org" CC: Suanming Mou Subject: RE: [PATCH] app/testpmd: fix flow creation parsing Thread-Topic: [PATCH] app/testpmd: fix flow creation parsing Thread-Index: AQHYLb53wAJjgRATWUyXC8TuS3laUayrvyoAgAAFQ6A= Date: Wed, 2 Mar 2022 08:33:59 +0000 Message-ID: References: <20220301224739.3072563-1-akozyrev@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3445d48b-0341-4bd2-3486-08d9fc276637 x-ms-traffictypediagnostic: DM8PR11MB5719:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rm0aa6pb0MbRvengFMaNZAwV+dHe8b3k7QZTkTZ8vgjuRhj2+8ZgL5ZRuN5X/oWcxi3BYLucm9UKyrfstJdoXR8/wcY5ufIDT4rFmmgcL+q1GtBHopkNakzy3qxpwOqTQAgZjG9QdO34XG3zrc6m+JKYTdNNgb3ch4R/rfq2p6qKM/cFQLX+uyS/eULSTwvpe609hK0hu63IygG0VV/HoX9FhuZEwHCXAqjAa8E/9XjvHgZZOWmqGDx8bvzNEUfTlfWywr5DWP5mh7MNW/749Wvcsi0HLSV4OXl1rV05SZ5Spbfi15C9xMNpKADbkLdkX2S3vqTt2m76tysKX7gKe2W523WNjJN4Stib5jNnC9e/ODcYrmSHu9f4aKRE5Sk+GOYzaOLWH3rUc/Y1nDFcGd7qG3jYeAuApUDXBNeWX69slKklYRIur7p9zODnG4Lr4iK4xovRW7V/Aorip9GJp3gv6KWG0h5bahIbXI4iqAGUkIg3kWxvhb9wBsrj8EH8aHjQjFI70oPxkTfsY3/y9bm2xsWgzQ7pAM8c43P9jkPy4EAlPvsZW4/rl2WXjfkaI/Vehau/eCIvuci2EGxzgmqA2obBEVqfF79i2Kah4K+6pSRe01269UFZf3UlHTwkdyIfNGLDHS9hie0FAWM6dFn7iZrgnvHoUlxVBpQJEcAilqiBClOdAr79i3OWVIXGLbM1Xw/C4I9YtuP9XnkrBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(71200400001)(4326008)(53546011)(38100700002)(82960400001)(9686003)(122000001)(508600001)(55016003)(83380400001)(110136005)(6506007)(7696005)(52536014)(86362001)(316002)(8936002)(38070700005)(5660300002)(26005)(66946007)(186003)(33656002)(2906002)(66476007)(66556008)(66446008)(64756008)(76116006)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ddZDb0E3zsDC2gyd3y+XPTiRgI+32G6x5dLZoIdlHIEfHQ8Rtba42e8StaY?= =?us-ascii?Q?J0iN/6z0yIX8TfkJe79Loyz2ZEY7ueiJunIPxHWYB5giDidjZqRWF33xyqji?= =?us-ascii?Q?WN9mqXofBVKoy+a0LJYLFF89/1p9MVvuZ29ZyeOwJ/pE8zaJg1IrrsPxhkZb?= =?us-ascii?Q?pZsYC+YAi6dha9huR0TPP6PvJd/WO5lpvOGs+2ad5yXg5mqSfLnwI7eH54TE?= =?us-ascii?Q?eqMGvNcQX0ScVGzH5ArCu/70bT4o0D8t2QXJMhEM+XcFhHMBqndMly6ICBrk?= =?us-ascii?Q?dplvMBq0tLwG0w68CsvHSbpNDaX7zAyN6gd3A8t9iwKK/lAqmuEy12MTO6p4?= =?us-ascii?Q?ovIeS37oPHpnXio06EmRucrH9UBuht6/iHtXWW5jxv8QqEyIy+u9bTF1R70/?= =?us-ascii?Q?4e/w6GHq54VchqUvnvjGwLwHiUaHr+d7ffatJOgUu6JZg7CGUsZ2uUXbvV+e?= =?us-ascii?Q?q5KYsS4NwZNFmGs05C5RXPDvy25D9CKH9irAhrOLUtsYdsmVRA79ciS3u775?= =?us-ascii?Q?PZfKAt2ujefqXK/h7WKQbMjUYBDb6A48JevltHzZXAXPBBSwTtIJp2FTmT73?= =?us-ascii?Q?dGOPNCv20uikqgvDEur2oFCysUNd6DdCNjtqh66verU78AMcFYWyZfrVa1d6?= =?us-ascii?Q?bxbsF+kDU6LxPcdb4DdsqyNYK0oicaijmoU7CGSSH8MZ1hXYCzk/3AdTbmbw?= =?us-ascii?Q?Yu83A/xY1lVrEKumnI7/4Z/sCQhQEL9eQ+Hypj/6Ktb0aiiNFNtlhRRBDJWd?= =?us-ascii?Q?bneC7YKnM4yNNvh8ZpMdLqQKe8qWYQx1J+/DUtseliPMoSQg3xWjxRd83WCD?= =?us-ascii?Q?uzKRxMJQhkmVga7HNwBIhe1yU/UT4VREIeHcfDESiWwM8n0y3B5tLSwtHGgc?= =?us-ascii?Q?cq1j6AhXRzYOhk8RAN1E240A7KmE9hVyId2En8rgbwMUkyl/X8X3AmZQsBgq?= =?us-ascii?Q?+MuDCc+Qnvt1tXvTARVpxakMRRzDKJWyMQMlJRtgKdSVdGIUwzi51fD1SGoM?= =?us-ascii?Q?WkrxxpDkvBdStViruU9N1sy73MbARLAgHpm7fd3dmena/MZ0V7gZpKNoH9db?= =?us-ascii?Q?utQn7ONH0WS5db8+jLAC7T9jH28o4IoT4sNjfcpmjXcie4YMxM1GwNgXROQc?= =?us-ascii?Q?fyQvv7rCEzufajxUDHOYREyIUGE6jXV4TTKE6cIF1l42qwr6bPCE6mu49got?= =?us-ascii?Q?iCPLN6AoINrjdRkoL1tL0atxcyaw9HKMzVgyZd79o2s4ELVp+/vuar8UAYam?= =?us-ascii?Q?rfPNyO9gMHEXtkvCMkX6tY1g1jv4+4If4j7GE3T5F+lQ3RAsXGBW59PFg2YE?= =?us-ascii?Q?j53pKzg32zJuNGqRThdvUTKGRaNv9RKSFEwJMMiHl9xkrTC6im9ZSi5RUJx1?= =?us-ascii?Q?dtMohnZ+uq1L9Ab11kkHVrtrcmhbmEiyxenpz5SRy8b+zAGK/mLHuUtPOLoY?= =?us-ascii?Q?dpxYfVLVb+wiLm9fvBCqEadYe2o4LL3wzH+F7r1XLZXnXSLeEH87kX2AkihN?= =?us-ascii?Q?MDhr+S3syCQhiyaLks6dWdQBN4NYvo483/0NxZHqBTcbha3kft/vIqlwcd1m?= =?us-ascii?Q?KlFMsbTzxcbJq044ls4WRUvrROjXmDWJKqI5F9+QjVCbMTSBroZiDgGklljA?= =?us-ascii?Q?+w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3445d48b-0341-4bd2-3486-08d9fc276637 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 08:33:59.6578 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OlMvXadLLFrKMPm51Z6FlYHWT8wKAIPIU/VYLjX0Geg4GMChbAF2Oarp3XpaZkE/6Fx5Seron8ZjcLt0sD9FfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5719 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ori Kam > Sent: Wednesday, March 2, 2022 4:13 PM > To: Alexander Kozyrev ; dev@dpdk.org > Cc: Suanming Mou > Subject: RE: [PATCH] app/testpmd: fix flow creation parsing >=20 > Hi Alexander, >=20 >=20 > > -----Original Message----- > > From: Alexander Kozyrev > > Subject: [PATCH] app/testpmd: fix flow creation parsing > > > > A pattern template creation shares the parsing mechanism with a simple > > flow creation. The pattern template creation only consists of pattern > > items while the flow creation continues with actions. > > The parsing mechanism now accommodates both cases and allows to stop > > at the item end token, which should not happen for the flow creation. > > Fix parsing mechanism to differentiate between these two cases. > > > > Bugzilla ID: 941 > > Fixes: 04cc665fab ("app/testpmd: add flow template management") > > > > Signed-off-by: Alexander Kozyrev > > --- > > app/test-pmd/cmdline_flow.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 4f7a9f17f9..fc4a6d9cca 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -6864,6 +6864,14 @@ parse_vc(struct context *ctx, const struct token > *token, > > ctx->object =3D out->args.vc.pattern; > > ctx->objmask =3D NULL; > > return len; > > + case ITEM_END: > > + if ((out->command =3D=3D VALIDATE || out->command =3D=3D CREATE) && > > + ctx->last) > > + return -1; > > + if (out->command =3D=3D PATTERN_TEMPLATE_CREATE && > > + !ctx->last) > > + return -1; > > + break; > > case ACTIONS: > > out->args.vc.actions =3D > > (void *)RTE_ALIGN_CEIL((uintptr_t) > > -- > > 2.18.2 >=20 >=20 > Acked-by: Ori Kam > Thanks, > Ori Tested-by: Zhimin Huang