From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B00A5A04FF; Mon, 4 Apr 2022 11:45:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5445640696; Mon, 4 Apr 2022 11:45:42 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 17C8D4068C for ; Mon, 4 Apr 2022 11:45:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649065541; x=1680601541; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5hMSnu2XXRpiF9v3DuLBW7BGtr/Q8QmMLiQVSBD75Sc=; b=m7bSADY/c+YBCTCGWBVv+XjvMET93NbMqCzZm6pFlmuUx/7/Pa/YtTDO CeJl6U5NQwrh5hzZCCQpvraMYhsAnHR4LmXodAStu44v9WpGCeLc/0YDk pdSal5Ba96xbvAzmLTDV+T1M2JuiCWf8OMjLiRTHE9Xtx1g+Bli8OQy70 jct3fcMpskcKj3rWut1lF98/mhPxZ4IV58Ex+KgNuE71sE0ILYxrqVmph yEbMWeypInRbbWdujtpwuWwgDzLYim6rgWhMaMvrIYZDZytN26cDjqgpV AueoRolzRMbfwrIGZiDSjf6GDTFvN1mWt9gLYL5TLo1CSQf9qXveX7tT+ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10306"; a="258058880" X-IronPort-AV: E=Sophos;i="5.90,234,1643702400"; d="scan'208";a="258058880" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2022 02:45:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,234,1643702400"; d="scan'208";a="721588030" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 04 Apr 2022 02:45:31 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 4 Apr 2022 02:45:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 4 Apr 2022 02:45:30 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 4 Apr 2022 02:45:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EGzFybFaaFpeFWJ+8wEd1JVOICie0cYE70RGhOxs1oRFw+OH5CamaLRabRq4xdnLNkp3eWJrNZ2fr0Pk6nC18Kmo/kKWKGyRiT+CDsyAiQEJnF7bZDrOkDgh3YjCOkqFekzcDGTfth19Rw8E6BDxxBRU8UgKTlRlFciOFLsMQXjZG4LVUMQLkvFnO27nXkJmg/xu9El2PIj+9yJnx5UQNBoGkB3ozQ+hL5SuRbxDhfD5m2Luuj3ZMI1lykw9h3zEjkc1Khz+VfxGBwSbLVymJFR7DCqlr4+aCoRnQlyVGEIC1TVvPi4M69v6ijCCteqhKaQ8brNc6kfr5nGutzxnqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOiqwXdCg860M+ayiBMG0QkP/nje+eP45wWjb7PkfnQ=; b=JDKuZPU+j3Pxd6UU3TxFriOqHc/uA2gy/IJcjsiYQC7fYB0xrC9P9zndzUgJyf6G4Rlvg+OtISszrTU1Dbwb4Af209bqKSCROMytoTxH35lZ8TLYZF8LAzKShXaCCkC1jLyKMgXMZjwRTmcgpEoYzzZbgM484zXSAyvGQhcKt8GHEuPCDDkh15jyJeN+V/zn6fH7AHiA0vYMTnPh07wmziWRdOXPl+QjTM++TURfmzkMcPNoaKHh/PSEH4cfnqxUUHrfOuOOdfL+4LtrL7gz/wII/gHLAmQsBNmgj3Rw+brmCX8C8cD3ev7fuLus3iADrSs9ZrlqY4Mv8O9Xbln21g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by MN0PR11MB6036.namprd11.prod.outlook.com (2603:10b6:208:377::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 09:45:29 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::28cf:55af:8c4b:d4d9]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::28cf:55af:8c4b:d4d9%3]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 09:45:29 +0000 From: "Van Haaren, Harry" To: Shijith Thotton , "dev@dpdk.org" , Jerin Jacob Kollanukkaran CC: Pavan Nikhilesh Bhagavatula , Ray Kinsella Subject: RE: [PATCH 1/6] eventdev: support to set queue attributes at runtime Thread-Topic: [PATCH 1/6] eventdev: support to set queue attributes at runtime Thread-Index: AQHYQ26mmHitl78UWES4UDePcz2CK6zXweOggAfF+YCAAAB9cA== Date: Mon, 4 Apr 2022 09:45:29 +0000 Message-ID: References: <159a14ece2480a3704ee34ee0d81dda331c16957.1648549553.git.sthotton@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6f2331b-0901-48b4-fbb1-08da161fda7e x-ms-traffictypediagnostic: MN0PR11MB6036:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yVf8yYZEFeXsclaxeVMQ6s2JdX8My5NLcYpcVwBRJSqnm75g5TSeBgr1T9GBRkh4frf5fEhBEYRzAvjGaXqGvZQUliZcedmQS0MSUnGhKM2DZGAhs54sN60GJ7RC81KJXzfeZqYXNX9QuQ8Dy9o8jFrJK8AbuWpYUw4XrnhazLNiGiUinsO2v4xmnKekdvymsFWQJ72hiStGv7pLgOz0rHWr8D66Y1nJeAf8bn0RlV0N+yUcidq/+YQfp3byF+DeDCbIi4tj8ZkuMX+X66PPZhgLZxTwSjjM12urJcLgiLj2PQgFRM8uGmCHIc5yCRTLMX1n798DB7CtGlN1imjpF/Oa7qqv7CDqAN7J46ez3+uAH8Nvu4ls1tsM5qoyAqzzUojMzAktOlAlk++ZSE0k7kYQqlvfR8qJAx+qvVXOIFCEA7GTlI7p/FW2k4Oy5kehUX9CHTQrRubcmocAOHqqcpRty/9uq4kXLUT61cdLtzGwIny9MnUiPI6JYardyyrlRVs0sui1dDR4ZPoA/EM4t7FzMu5g7S+ZVDxxDFwJdQu5eOnZQSqcrsyZL8YbAqBnG5QKYzm5NYatx3G4Wq8KrrtcJ5514dyOqvv7WHuG8HmdkNqansKl5J6QukNhQ7RcESBKgnEyXAguPh9Z6b2V5li9VEf5Z9yd6lGiCygC1qkfibViDTDwK7iXRW8nEZbKOlL2ivd2L36eiQipIQehIg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(7696005)(6506007)(26005)(66556008)(66476007)(76116006)(64756008)(186003)(508600001)(8676002)(4326008)(86362001)(2906002)(5660300002)(82960400001)(71200400001)(38070700005)(66446008)(66946007)(122000001)(316002)(54906003)(53546011)(38100700002)(9686003)(52536014)(8936002)(110136005)(33656002)(55016003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uLJjgSZSyBiA85hbkXHia0YbtB0zx7if2DbZMEHU8dKS5aZMUdQWvT8W8Kk4?= =?us-ascii?Q?NwTk6EG6bDNnZzfUFwwuVwWtgAEJCLlW6FFoWMc+2BsgtwzI4Yfyzc8TDxGT?= =?us-ascii?Q?XFApRD1OKIPI1UcgNWGMSJgag7upTnpNcxFOVq57cROV5czeDGE+/yhEJ346?= =?us-ascii?Q?rP6r3DfR77/xTr+znNQT/fm9stogn4urUG+xsADMHzD3vN6pMTb2C3zK9AX+?= =?us-ascii?Q?O68QhvbS4xf42K9qz5T53LgkRx40pjXxBTjIjiKFt/gKt2nofy8YULYAxgZo?= =?us-ascii?Q?T+7jSgI7Vpul4dEWYDaKnTg5B4BRFJzX9KQWXTbe946UviXmZDCKH89yJeiZ?= =?us-ascii?Q?tknZj8MNiJ1WB/yhhSE09p0VqGUB+1s0wgaSI8VxkFSJlzSBJZaoKTfowNJi?= =?us-ascii?Q?IR5iayGHOfnMKM0i0EpIB0Ri7yPTG/NwBLJlN24UMrHl1TDnLyBzSxaWL42u?= =?us-ascii?Q?lWYJBadAnTMYbCc2BSIo9/axVgiCVdsrAQw8rDZvi6CxxcrDZqLU23NYWwce?= =?us-ascii?Q?xlKEx/U1PWGp+TpHH85w5jBGkn49y816sM8u9hlgmoehuq6TFmF8+O61/Oli?= =?us-ascii?Q?AYMSsxp70ZOl82D9RVzHcr8TRNijhddaMWkfnJeyfGNGjTt/XobhyClCbb/Q?= =?us-ascii?Q?YGYyd1UN4KU3x1ANHy7pnsGk+kxhqlFXMyY8oo5igui5ybSvvxblzAO3WfER?= =?us-ascii?Q?jvGcSicN1+jacWK1SeUjo08Nd1fCW4S0U9dcmj1BRX2JfjhZnpEYagqoDyB3?= =?us-ascii?Q?XcmYP90M9Kn0+32LeJYTaht0Q7ghu82mu6QEVfYR8Oj18LEQp/xrV7oYjX6I?= =?us-ascii?Q?da0kIpD02RaHRlICCLxGnjym3sZ7NFv4GUC4KtWzvjBmmFN9vk0FCd5hRU3j?= =?us-ascii?Q?/sI76R8C2TDwYd6fQRdtLFI723kKReAe8xDWKg2+MIys/fVBk6WCjSgMU15A?= =?us-ascii?Q?DAK1w7JDc+b37AhO3WUhYlNKL2AjLdwF4Z4lBPwSukuuMpnWJ3J6WRjQTFuJ?= =?us-ascii?Q?oQCKZa4LzkMZbwV6xb95iHuMXrp4wKXfEKScw3oz0O75QsiMQFWkUTz4jAz1?= =?us-ascii?Q?0dxFxUbKW1Fr9/TFi30CIRcbx/ovJdaLgQZV5FHUbMxiVY55ne2bTT6xqpIX?= =?us-ascii?Q?p1rZpFSMdzfUOZy6ZSOIBgpnBq1kg9AcgsudrhW4YYopyRfTciKEhoHcj6Y4?= =?us-ascii?Q?cNBhc1R+c2LEQ/qIQnlNCNhHbOoWzQJNVVg5cmigCOEOcdiWsVE82mgUFQTl?= =?us-ascii?Q?h/ALI5PmV1tIsapt4cWFUzet8V7JA1jhAjrM6kyki7V39PGZ0UOUpaOMMsOL?= =?us-ascii?Q?gfM11Q3q57DGNXHK8rEYHVCVYCfDph2gjUYTHmMTqQ8dd5YP1kjNaU/HLRpS?= =?us-ascii?Q?g30brpG6lMy0KCMswK0+XTPYI3WgCVR7FSTV436smd08Dj3QAhLj9NLWiwJe?= =?us-ascii?Q?xmzMwr3Z+tkYaDEWylU1Sm0vKwxSClxwrJdOVirpDDJU4NgjPJtnpiQpKg00?= =?us-ascii?Q?vOEkjMclOhyxJPPR6DyNwcGCA6bV4GJ3F6CSsko/bKIBEVOoRXIL+EaPilJT?= =?us-ascii?Q?0U/qU5JL93IdF+F9duGDQ4QSAlNYAMSC1bk1Lukh4jXnZnsmWep8tQYkG30r?= =?us-ascii?Q?5l5Oc+6evOl2RoahwOgQszEO81bBL+QXuKnFX4n2yXobp27DsbkzHx1cpUms?= =?us-ascii?Q?DguO8v+ZxlJSUPq1YP/K0HriXCCF+qyZw4UocIXEhv9qpM/zdbhSmjCab3OB?= =?us-ascii?Q?ZAtw0OuaCf/J6sH7m0L4Y5JWAhN8was=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6f2331b-0901-48b4-fbb1-08da161fda7e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 09:45:29.0961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +9Zu8jtKlaoD7AAERYBk1n//tST4H8TA5wSBdE7iDaKVy/FifTkNE1XyIBogRfmIN6NOB+PD9oqs858H7fy5dKvNu61aCygK8ZZVnruyrlU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6036 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Shijith Thotton > Sent: Monday, April 4, 2022 10:36 AM > To: Van Haaren, Harry ; dev@dpdk.org; Jerin J= acob > Kollanukkaran > Cc: Pavan Nikhilesh Bhagavatula ; Ray Kinsella > > Subject: RE: [PATCH 1/6] eventdev: support to set queue attributes at run= time >=20 > > > > > >> +/** > >> + * Set an event queue attribute at runtime. > >> + * > >> + * @param dev > >> + * Event device pointer > >> + * @param queue_id > >> + * Event queue index > >> + * @param attr_id > >> + * Event queue attribute id > >> + * @param attr_value > >> + * Event queue attribute value > >> + * > >> + * @return > >> + * - 0: Success. > >> + * - <0: Error code on failure. > >> + */ > >> +typedef int (*eventdev_queue_attr_set_t)(struct rte_eventdev *dev, > >> + uint8_t queue_id, uint32_t attr_id, > >> + uint32_t attr_value); > > > >Is using a uint64_t a better type for attr_value? Given there might be m= ore in > >future, > >limiting to 32-bits now may cause headaches later, and uint64_t doesn't = cost > >extra? > > > >I think 32-bits of attr_id is enough :) > > > >Same comment on the _get() API in patch 2/6, a uint64_t * would be a bet= ter fit > >there in my opinion. > > > > >=20 > Changing size of attr_value will an ABI break. Can we wait till a need ar= ises ? Ah, I forgot that the _get() function is already upstream in DPDK today. Its actually an API *and* ABI break, which is worse, as user code would hav= e to change (not just a re-compile against the newer DPDK version...). Any appli= cation attempting source-compatibility with 21.11 and 22.11 would have to #ifdef t= he parameter, switching uint32_t* and uint64_t*... or use some magic void* hac= ks. Yes I suppose that waiting until a u64 is required for a real-world use-cas= e is probably better than breaking existing users code today (or in next ABI breaking rel= ease) with the intent of getting to "perfect" API/ABIs... Suggest to use a u64 for _set() to avoid getting into this same situation a= gain, but leave _get() as is, until it is required to change for a real use-case?