From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Li, WeiyuanX" <weiyuanx.li@intel.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: RE: [PATCH] event/sw: fix selftest xstats reset API usage
Date: Wed, 12 Oct 2022 13:08:45 +0000 [thread overview]
Message-ID: <BN0PR11MB5712B572E92483E18BB046EFD7229@BN0PR11MB5712.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5006490.PYKUYFuaPT@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 12, 2022 2:06 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; Li, WeiyuanX <weiyuanx.li@intel.com>;
> ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; Morten Brørup
> <mb@smartsharesystems.com>
> Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage
>
> 12/10/2022 14:34, Harry van Haaren:
> > The eventdev xstats reset API takes an ID of "uint32_t", while
> > the rest of the xstats APIs require an "unsigned int". On some
> > platforms these might not be the same bitwidth, however this was
> > assumed in the code.
> >
> > Fix by providing a uint32_t to the xstats_reset() function.
>
> Why adding a comment about the type in the code?
> We are not adding /* using the right type */ in each line of code.
Correct; but as the SW PMD was the only selftest code that actually
uses xstats_reset() I err-ed on the side of warning devs that there's
some "funky" or inconsistent API requirements here.
I can respin without if that seems better, but my intention was to
help future readers..?
<snip>
next prev parent reply other threads:[~2022-10-12 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 12:34 Harry van Haaren
2022-10-12 13:05 ` Thomas Monjalon
2022-10-12 13:08 ` Van Haaren, Harry [this message]
2022-10-12 15:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN0PR11MB5712B572E92483E18BB046EFD7229@BN0PR11MB5712.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
--cc=weiyuanx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).