From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F67CA00C4; Wed, 12 Oct 2022 15:08:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFDD243053; Wed, 12 Oct 2022 15:08:55 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id EA64E4303E for <dev@dpdk.org>; Wed, 12 Oct 2022 15:08:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665580134; x=1697116134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fVjAEAc5d9Nzc+KogEdTXEPxf4CTZu9R4V1DKcNbxs8=; b=VpKw9KCLgEfQeU+N7WjuMkNSrBRy20fow2jnr77PcbPwEmXw89nmnb58 wBV3e78l6QSQP1QGjP8EZW1Lbl/5aPCqT4ly6BQBd/1NEO00flNq9ftSd Q2O3ES3QpSnsQhqanUNrbz7EfDwAUr0SUaiwYDxihvBFw0tUSl8ywNup0 vVtqSAp6KWx5WHmp3EVOsTwszGmJJ0Tp8adsy7J8Rd05VrIIz1u6I7OKk AykIDRrAJUUZaF9h9rxQXSwsxNDZe+BxCrX2MEKXff+Pd2u3wSkrPvsNF hsXuvZmAe87uj7WRqmEeJlb1KL7u0tnrTKA3iyMcFz87nnxPYMYbgLemz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="284512869" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="284512869" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2022 06:08:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="715913155" X-IronPort-AV: E=Sophos;i="5.95,179,1661842800"; d="scan'208";a="715913155" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2022 06:08:49 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 06:08:49 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 12 Oct 2022 06:08:48 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 12 Oct 2022 06:08:48 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 12 Oct 2022 06:08:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lV0riXJIHRb7YkU/zdhL/69nxz1WxjU1+XN/eonpYP8bWCL+a4S59Fhjn+H+AhzLGkHl/f9pQIXobrUuYSMFDtifgjv4/dLALUj8jXB3Gb4zmmJZdAeblCimZVYEcTiiyk22GGloIfoA5V6hfroMGsznfDGhyjASxCTxZ0pddOF5P0bpsCV/1+MQhOKUd4kdQRNQExgxQT1RRxTafqnooUuJkFJOtNFkQDLE7R2cNyq0KeSCjz8E6fFvbEatnfNedUC4enMXXhReIKV/KG4GPFRQaFTRocilV/Q5rDcLtry5uCd3FujZjeuQMibxl9ncBJO0gYHGgyK/GqI/TNueEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVjAEAc5d9Nzc+KogEdTXEPxf4CTZu9R4V1DKcNbxs8=; b=YcMJnf4oT0vOfM8J7YqRCRIn3VorwsCQbzMhXRlu3zg0hjE1Buqo9xcjwRLFek2OXbz4UFxpFE7obG/i9EgF9gi3HRqZ8U4g2+djayWF9ZYiD+pAlpVGnXbEXMlqt/rvWXre8FzCX24wS0BCb9/h9UmK8zR4i7I71cNTx0fK35+6FkS7tw0K4rDOXF17QELZFHaiqd5KJa2T5n1f33/+mftPMlE7dTSO4nk/AwAM0cKkMM8TrLe/1eT3f/cKVnRZv2XwZgrJtPM1XqckAxW+389z8hSUrGXYow4faAWnTAE9rnT8N+f41beUbB0KCLY8mMn7T5ifqkJ3upo8P2odZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5712.namprd11.prod.outlook.com (2603:10b6:408:160::17) by PH7PR11MB7099.namprd11.prod.outlook.com (2603:10b6:510:20e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.22; Wed, 12 Oct 2022 13:08:46 +0000 Received: from BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::8938:3719:8c0f:ff97]) by BN0PR11MB5712.namprd11.prod.outlook.com ([fe80::8938:3719:8c0f:ff97%6]) with mapi id 15.20.5709.022; Wed, 12 Oct 2022 13:08:45 +0000 From: "Van Haaren, Harry" <harry.van.haaren@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>, "Li, WeiyuanX" <weiyuanx.li@intel.com>, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com> Subject: RE: [PATCH] event/sw: fix selftest xstats reset API usage Thread-Topic: [PATCH] event/sw: fix selftest xstats reset API usage Thread-Index: AQHY3jb6aKM1iv2Mp0mlrAKk6YMxfK4KujwAgAAAaDA= Date: Wed, 12 Oct 2022 13:08:45 +0000 Message-ID: <BN0PR11MB5712B572E92483E18BB046EFD7229@BN0PR11MB5712.namprd11.prod.outlook.com> References: <20221012123419.182631-1-harry.van.haaren@intel.com> <5006490.PYKUYFuaPT@thomas> In-Reply-To: <5006490.PYKUYFuaPT@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN0PR11MB5712:EE_|PH7PR11MB7099:EE_ x-ms-office365-filtering-correlation-id: a760a9a5-9319-4bc1-b483-08daac52e535 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i50ClcZmROR+PRhQ3IzeQ4tOJySkCM6zpeGPvJrmGj0lFZGNOrllfGiGyyQA+y5mHTM4GsnNI+AO2azJzLZ5vxcVKIzsccaJOTOTyQsYeWfI3Tonjr/2W445D5RCaFsoKdP0LbYksERSFpUn2TTTRjhcpwMqdOBFAeR1oK5LjRlloWy6nAIdQhk4VO40BDbBgJi5PnkPBMRVP5+xDkz9i08prlvCnVZ90crATIcp+HK35Mr9VtVYdWJn82WnyFj2zXxhIIdCQG9FsUe3l9GW24JQouB3ubLOyl6Ru0ui5R8uRi9OsGGv0pUtX71l1dg08eSUPc+WZ52KPm68VhJEAMwudUn2w36f9xbdwAm94NL4D/tLMmXDSluM+UGv4cHiJ6cnNnt/ycghiYSipdJli+PfkWB6mayePvdEdMvbL0zasUCV8pZbdW+Hq44DBTqOxC53R7aaKLe/XLVYU7YG19ty/+z5+o0MUmeDaj363yIZDhQqyPGKVaqVhYtjwvxYg8AcsG/H+t+5WPQKvNG5aSynnVd90VrZ/dZ6wgqelgHaGgFLjjTo/a7GCUI0c9Va3tz8lqx1dhtjJhLzDvs6MZkGmvPvyETKB9at7uHdWfoIHruIEn4KF4ITEJshIKKSdyrA/itIIQjYWVzhk7jfltwuYH7FFlh4BECPcPiDQ6qpdbxHq/uQpBUa4UHO0DJE4SqfcALIogQ/k+e6r/309u6uP/T+gkV6ORNIL61/3uYS5FcdsUxVx6TzqR/Lm+38wySRh4JoxygMpzNnpPhiUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN0PR11MB5712.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(396003)(366004)(376002)(346002)(451199015)(122000001)(86362001)(33656002)(55016003)(38070700005)(82960400001)(38100700002)(316002)(66446008)(8676002)(4326008)(66556008)(66946007)(66476007)(76116006)(64756008)(71200400001)(54906003)(6916009)(2906002)(52536014)(8936002)(41300700001)(5660300002)(66574015)(186003)(83380400001)(478600001)(9686003)(7696005)(6506007)(26005)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?On2io4Jok+9/D9VGUzPQilVccQtt+narD/UYlk79bM66SxqM6vJDjgi64v?= =?iso-8859-1?Q?PisoV0ZO4TcawWigNTFFUGE7FhiZRM9UO2vziCB4Qq2h2NwYcfOrWHo8av?= =?iso-8859-1?Q?xKVtD52+ypfaHCoyGKP/O4IOe6icBgV8NSYgeWIB0oIIPxvDnXkvACscZR?= =?iso-8859-1?Q?HUxE/3RCpCUjBRSbi9cjLAEeUGwtQnyiqRYBUfZRV9i4S8Uw+E1Dq3+5Wx?= =?iso-8859-1?Q?X1QAcuZv40LMZQYWMk6sCJkaWisU1QloPuJ1Cs2vegAFSIZZgOAS+ygU9N?= =?iso-8859-1?Q?fyFu1FvEO9MVXl5o1Urfw0kQ+g8qxvHBSTQWxIIlGPh7UxxAiYRvYsBtdN?= =?iso-8859-1?Q?RmRX2LYo9KP8kck15g9zTUCRKl2Y4sxSQDM39ULq90D6U9h8cv2VSsPvA3?= =?iso-8859-1?Q?Tik9nsQ13a9pcTECyR/7NuANvS0V41WiieiqshDNQA0pIne8wOTPND8Z1a?= =?iso-8859-1?Q?lyyQDwom/29vSMvJ7/rlUSoSmith5ajo3T7tCqW5a62JwO039d2iuVJZ8o?= =?iso-8859-1?Q?UPj0dJV8a61hfxn8169IWG60tH0jyq+8X78lFLXZWIIfVKC+Sllw5S04mw?= =?iso-8859-1?Q?mj2WK8nci8A/42DFh/xa0jovHmFrSgT9KyS1uE7WLvG8JpbcTuAslX7MB2?= =?iso-8859-1?Q?CrLZsxLvLiO3OuhIpsL9937t2B6sOHV2DTgRoMz324ee9KjWo9KfjuG3zc?= =?iso-8859-1?Q?TdzkokyT/deV5gwTusxaDHGH66Hzyomo1dUJ0BO582cqsMYg45Yah1PDRQ?= =?iso-8859-1?Q?GNmCs/IsXKH1CJx/5SaLBAJiA/ifp3R3G5h8WobgfPCiQX+Jz2UQ199jAT?= =?iso-8859-1?Q?jcM5EQGBsmDI2iROYSOMccyPcCL064w+6q6qw2ICgorwmX366c8mHqpObN?= =?iso-8859-1?Q?3Fk91ue5MIGmIr13V6+XTq7dWQLV8ugue8jUKPzGmuqRtGop8Mqw68DI+9?= =?iso-8859-1?Q?OVS2Hz8iL4nX60klhDSpOi96YFJbkGTIr660we3IsKG94UC+PkyqXfXCE1?= =?iso-8859-1?Q?p68WLV9GLRIMLKLHt46zOGwqs2+ugdkBt0AW237nzoYZOCDxxHLqrGOv3t?= =?iso-8859-1?Q?t6yE7P8x9G9Lem9z9yCvr6CwLk//hA+bxrkOS7GG7oOftVYcOWHoW7ceis?= =?iso-8859-1?Q?YZX4mf++Rb5WG8QV4Amc0FjUGrFb+RWO4G1tGJJWcsiNTqVeKHE4bTSQKj?= =?iso-8859-1?Q?3zhwQ4HoiJz1BWW/tTqpaqKzLTPbHpAogtm18fcIHkkqeaum/MsuMpNzxb?= =?iso-8859-1?Q?6xpO0a7anrXMAuMOh9jEYzrwz0xAuFvnJnUayedoXs+5zijb5ThQegPXOr?= =?iso-8859-1?Q?5mZmI/H7Yeplkh4mXEIUEG1o7APsdzwe+iNxNNRa0l6+IlD2M94Pl1+LSY?= =?iso-8859-1?Q?JuS/InPlObYkfYOvEvpwbTV95O85vp7GtOKEWX0cvstdnq7DSiX3jhRLTF?= =?iso-8859-1?Q?MjK66jIyKPgeH5qE17XbXdYy8jZiBIYZLJqqmP0E4FWh8zZMAaU99glQiF?= =?iso-8859-1?Q?tia+8RD82SqPS43tyYfLaSUK6H1S2IIitEIoiEJfN+VpvRhmQ6vAAQK9vl?= =?iso-8859-1?Q?g/0tw1wc82kQzw1/gEDhVw+LZgu4Fn+nOnhM4jQD5m0Gmc1labnESFJmC5?= =?iso-8859-1?Q?EEJfTqRV2KSfDqPc0C0PjgNeqo+JtJ1wJzPcCbIMTLEaUYC1drUcSX6g?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5712.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a760a9a5-9319-4bc1-b483-08daac52e535 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 13:08:45.8676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: otQHwZzT9WUFPgg5PVrbKa7IPraFxzVFF4ohx5AhD9ORu+I55OoGhN0DLcm6CksGGH8k11HRg1GpykGI/c0debrBTsopZ7lwvgfc74+Vt7s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7099 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Wednesday, October 12, 2022 2:06 PM > To: Van Haaren, Harry <harry.van.haaren@intel.com> > Cc: dev@dpdk.org; jerinj@marvell.com; Li, WeiyuanX <weiyuanx.li@intel.com= >; > ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; Morten Br=F8rup > <mb@smartsharesystems.com> > Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage >=20 > 12/10/2022 14:34, Harry van Haaren: > > The eventdev xstats reset API takes an ID of "uint32_t", while > > the rest of the xstats APIs require an "unsigned int". On some > > platforms these might not be the same bitwidth, however this was > > assumed in the code. > > > > Fix by providing a uint32_t to the xstats_reset() function. >=20 > Why adding a comment about the type in the code? > We are not adding /* using the right type */ in each line of code. Correct; but as the SW PMD was the only selftest code that actually uses xstats_reset() I err-ed on the side of warning devs that there's some "funky" or inconsistent API requirements here. I can respin without if that seems better, but my intention was to help future readers..? <snip>