From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0046.outbound.protection.outlook.com [104.47.38.46]) by dpdk.org (Postfix) with ESMTP id EB898292D for ; Wed, 21 Sep 2016 19:09:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=d9SA1zuPS3o10CSiaEe29DHK6ZTesGTDJPmoxy569/s=; b=F4nREqt1gx9Q7Wp8knX/B2c6FzeuZfxZeGV44oJk6wkEGpMKQC2r3EB1GfEpQwH42zJmmlPNjvDRpXVzSRC4l71tTLUUeG4WRnZ+0fsizyPJ5vNcKlzjyVs5YPIKcZ2+ngABoLwy1YRgALDuntRI+0T07ed+l1nhNZZcZB96SKg= Received: from BN3PR03MB1431.namprd03.prod.outlook.com (10.163.34.26) by BN3PR03MB1432.namprd03.prod.outlook.com (10.163.34.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Wed, 21 Sep 2016 17:08:58 +0000 Received: from BN3PR03MB1431.namprd03.prod.outlook.com ([10.163.34.26]) by BN3PR03MB1431.namprd03.prod.outlook.com ([10.163.34.26]) with mapi id 15.01.0629.015; Wed, 21 Sep 2016 17:08:58 +0000 From: Karmarkar Suyash To: "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "rsanford@akamai.com" , "reshma.pattan@intel.com" Thread-Topic: [PATCH v2]:rte_timer:timer lag issue correction Thread-Index: AQHSEDPB2NrTgxc9oUadR+nlImJRw6CENQnw Date: Wed, 21 Sep 2016 17:08:58 +0000 Message-ID: References: <20160916160222.12956-1-skarmarkar@sonusnet.com> In-Reply-To: <20160916160222.12956-1-skarmarkar@sonusnet.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; x-originating-ip: [208.45.178.4] x-ms-office365-filtering-correlation-id: 657d73f4-fd1c-4d48-16a9-08d3e241fa22 x-microsoft-exchange-diagnostics: 1; BN3PR03MB1432; 6:A3f2Chk+YvCtRu9HBTt/r7kE8e4O/5wxcuqOJxMg8UkfBUK48IBQ40OiAamOiAEwNaeoOoSQyPavZ6JxiwTwaEQR1+qJ8LLkJqgs3Z1BCnfiPaWJEqvUv8YZ5ok3+f5CgW7BDSmC0lR2LM7NPwL6TeFDazb2Qm9MojYL33Cr57AOtqb3gBGE3zqACwJrYW0l+t5JD/a/NFBp3s9T2mOR5XgtOH3Y7puPt+AlbIyinI5fnhhqCNsf3yTueBNWytB8Uq9S+7rZjg3G1FEnz0musYEsidhxwUbHnPtCGfDMvRE=; 5:/tYXRaS1v2n3aC4cC01gH86XWQPMJLhheG/v02rGcY5t/Q5cI3QDWxJYwQ+he/5CSYYMpicErYPrHDXpESqi/YV3tcAWU8sUo4RVeuTCCWHmwClJ7ew1k2RQXpXMDqCPdw4bem5FCz21WCXiaH9bnw==; 24:JRFdyKWut92N2uDAigzCiLI5+1C0i0rkr2dMmDj6FLMKZOrUYFbX9fh/HH9HV/IZNq+XnBqZRrqXUFmJodayFzSoFufItptaOOpfQcquEPA=; 7:jhjR4O4l2QFjfE3u0/3K5pH3GuuC55b4Oh3jAYVrGhcqlqa9SWDDzA3REF0gQaeOSc3s+79vJMMD9CyeMCfzBps5/D704oCKd65GFlBS8+hQLD4LuVyDIE0Q0H6mg9BpwDaRji+gEq90HGKg6kpbAoezlAiUJbkxptblH+bHyJ2MJJNo2+bxFOhXz6dPh+xha3zBCZaHfpepS0DvE3Ou0Q0wZk/tJ8EwQpqqQtmyzcJlBvbugUMN5gBG0mCPnV/9zaye81lpUdK6+ZBlugStW0NP0IUovLnzJaXD7Xgfx16rhv9xPQKS6+N4y0AokaQZ x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1432; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:BN3PR03MB1432; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1432; x-forefront-prvs: 007271867D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(13464003)(189002)(199003)(8676002)(92566002)(5640700001)(8936002)(3846002)(586003)(68736007)(102836003)(2501003)(6116002)(87936001)(3280700002)(3660700001)(3900700001)(86362001)(5002640100001)(7736002)(74316002)(33656002)(305945005)(4326007)(2906002)(7846002)(9686002)(10400500002)(66066001)(19580395003)(106116001)(2900100001)(81156014)(77096005)(19580405001)(54356999)(76176999)(101416001)(122556002)(2950100001)(110136003)(99286002)(105586002)(2351001)(106356001)(11100500001)(5660300001)(7696004)(76576001)(97736004)(189998001)(50986999)(81166006)(1730700003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1432; H:BN3PR03MB1431.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2016 17:08:58.4649 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1432 Subject: Re: [dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 17:09:01 -0000 Hello, I corrected the fixes line, Can you please review the change and if no furt= her comments can you please let me know the next steps. Thanks. Regards Suyash Karmarkar -----Original Message----- From: Karmarkar Suyash=20 Sent: Friday, September 16, 2016 12:02 PM To: dev@dpdk.org Cc: thomas.monjalon@6wind.com; rsanford@akamai.com; reshma.pattan@intel.com= ; Karmarkar Suyash Subject: [PATCH v2]:rte_timer:timer lag issue correction For Periodic timers ,if the lag gets introduced, the current code=20 added additional delay when the next peridoc timer was initialized=20 by not taking into account the delay added, with this fix the code=20 would start the next occurrence of timer keeping in account the=20 lag added.Corrected the behavior. Fixes:ba885531ac26 ("rte_timer: timer lag issue") Karmarkar Suyash (1): Signed-off-by: Karmarkar Suyash lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) =20 --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner =3D (int16_t)lcore_id; rte_wmb(); tim->status.u32 =3D status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1); rte_spinlock_unlock(&priv_timer[lcore_id].list_lock); } --=20 2.9.3.windows.1