From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0063.outbound.protection.outlook.com [104.47.36.63]) by dpdk.org (Postfix) with ESMTP id A982B72FA for ; Wed, 7 Sep 2016 06:04:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=B4oUJGFVZJuMWHSsewj9EMrDvF+0zbIMHJASHDwbWfs=; b=TTmNHobtkzx5YIdIgJYhAX3r3yxdaXJjrnhlU3bNY9u9032jyA//sNpZZZdk1nVNSCG0frvXypZ4WBJmM3KkhzeTdTE6T8s4IWatJ345RKtgLMjDnfl2mZzlH/JvTjCwRas3paZrs9WjpMGiWTtz4pXbL4mjuosFpKwhhMtoQHU= Received: from BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) by BN3PR03MB1496.namprd03.prod.outlook.com (10.163.35.147) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Wed, 7 Sep 2016 04:04:47 +0000 Received: from BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) by BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) with mapi id 15.01.0599.016; Wed, 7 Sep 2016 04:04:47 +0000 From: "Dey, Souvik" To: Yuanhan Liu CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio Thread-Index: AQHSCLcSnGzpImrFO0KRsTEgY+TdQaBtYmQAgAAA/xCAAAIcgIAAAtaw Date: Wed, 7 Sep 2016 04:04:47 +0000 Message-ID: References: <20160907032156.34492-1-sodey@sonusnet.com> <20160907034252.GI23158@yliu-dev.sh.intel.com> <20160907035359.GJ23158@yliu-dev.sh.intel.com> In-Reply-To: <20160907035359.GJ23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sodey@sonusnet.com; x-originating-ip: [66.30.138.194] x-ms-office365-filtering-correlation-id: 1c0370a1-5933-4b1a-6f0d-08d3d6d41b8a x-microsoft-exchange-diagnostics: 1; BN3PR03MB1496; 6:kDeOcXenJSjvaNSLqwY+uaPjpnzlaPJS2LSSUBApbN/p4OT2GtAapsakx2u5ykKtfq4mUYTbFdvkj7YcaesH+DdQCH+hZSukezM3SenbhtavPSz6QjUFHVhoqOOXEzzi1F86+wY5n/E0HfktXFts3O7Om/RVwIog/a4QquXJ5dsk1/F7avW6cWVX+bBHTVbildssp7+DmOE4eheqzAAx/qvkQiAXdhU9qJShhV3wdshEMVC7jy03EFaPg+VinD9hqkpqcYVL/9wiB9wCtGU/hDYAw1rQzNDHAmDaUotzPqQ=; 5:Rte4qpAgJq7YdRuNdRF0WCcY9irtWUpHDbPa7YrvVP4IWpFGygZk96lpbpb3hfzFqqog0vYeCISdZ6L3Fm/txmUQ1MhYzxmn8VMoW9WTopaAM859Vb8T2qqDA2JXJif94+/+BKu7pndc9z7P90zmKA==; 24:IhSQPGMz8TgH5CBmFw6B9G/y0/Ec6EzQvs86yJWYlmgMlNADtAxbOwtVTXPZmEa+ItQs2Cu1JvC/hFg8ercwKN/bKaUqvwrJPJ9SJCqoxPY=; 7:VAe1rqemeD+3ei9clmc4c0YybF/9B50RR59rjTm8A7n3KywPMV/S3VbllrJ1fC3QWn4C2sFMWBmhHhHEvsRJ19dM7jKCw84+rs1CmAjWfsmQ/dVosAiD9QO6XZ/htHXphWW4HTvaZQcd+dfeegVAF5xcP3r4vA68qRbscKOoGvjEP+1znkw9Jz8wIbXTlZxbS3+uxLXcWH02hDnBAKE02NTV8v58Hwn21rIKwcO8H6kmJ2lfXD4e3pzfgqO574zg x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1496; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(188685893418542)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BN3PR03MB1496; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1496; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(57704003)(377454003)(13464003)(189002)(24454002)(199003)(66066001)(5660300001)(54356999)(50986999)(76176999)(11100500001)(93886004)(97736004)(305945005)(87936001)(586003)(7736002)(19580405001)(6116002)(102836003)(3846002)(19580395003)(4326007)(86362001)(106116001)(2906002)(77096005)(106356001)(76576001)(105586002)(3280700002)(92566002)(74316002)(2950100001)(3660700001)(99286002)(7846002)(189998001)(10400500002)(101416001)(110136002)(68736007)(5002640100001)(81166006)(8936002)(2900100001)(7696003)(81156014)(9686002)(8676002)(122556002)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1496; H:BN3PR03MB1494.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 04:04:47.0808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1496 Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 04:04:50 -0000 Ok thanks understood. I will submit v4 for this. -----Original Message----- From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]=20 Sent: Tuesday, September 6, 2016 11:54 PM To: Dey, Souvik Cc: dev@dpdk.org; stephen@networkplumber.org Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio On Wed, Sep 07, 2016 at 03:47:27AM +0000, Dey, Souvik wrote: > Ok will change it. Do I need to submit a new v4 for that ? Yes. > can I put your name also in the reviewed by list? Nope, you should not add that. I just offered some comments. And yes, I rev= iewed your patch, but that doesn't mean you could add my Reviewed-by. You can only add the Reviewed-by tag only when the reviewer gave it to you,= explicitly, like following: Reviewed-by: Some One --yliu >=20 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Tuesday, September 6, 2016 11:43 PM > To: Dey, Souvik > Cc: dev@dpdk.org; stephen@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio >=20 > On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > > +static int > > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > > + struct virtio_hw *hw =3D dev->data->dev_private; > > + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { > > + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); >=20 > I forgot to mention in last email, that you should not use the number (64= and 9728) directly, use the MACRO instead. >=20 > --yliu