From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0053.outbound.protection.outlook.com [104.47.41.53]) by dpdk.org (Postfix) with ESMTP id D65C06CCF for ; Wed, 7 Sep 2016 05:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=y+FHI99XvO1BsFCw3MVXC8yAzoUS57I6rMBULbgShIc=; b=skluXorhWcU/FmO7p5//ZdUiLtA+BZQhufRs9L8oUl18pIRYJORMAcZW+1Vk4JA0SWZ4p1MOScWw5O7zlLRd760IV63XRoSSRqVg+TQ+9++8dc8Sp57FLHR1hLLNt1LH1EX2vDwK3HK0t65bGKCP1tEN0yFMREaqj2OSJOkurdw= Received: from BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) by BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Wed, 7 Sep 2016 03:45:53 +0000 Received: from BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) by BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) with mapi id 15.01.0599.016; Wed, 7 Sep 2016 03:45:53 +0000 From: "Dey, Souvik" To: Yuanhan Liu CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio Thread-Index: AQHSCLcSnGzpImrFO0KRsTEgY+TdQaBtYQaAgAABJqA= Date: Wed, 7 Sep 2016 03:45:53 +0000 Message-ID: References: <20160907032156.34492-1-sodey@sonusnet.com> <20160907033759.GH23158@yliu-dev.sh.intel.com> In-Reply-To: <20160907033759.GH23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sodey@sonusnet.com; x-originating-ip: [66.30.138.194] x-ms-office365-filtering-correlation-id: 3e1b3d44-2006-41f6-d02a-08d3d6d177a2 x-microsoft-exchange-diagnostics: 1; BN3PR03MB1494; 6:Z/kbjv4NTM86IUvN1uSKG2bs6HuG0CEhYgo4S5LWE6yBYsWQ5vsGlh0cJOHaavo5rLrx/e+mEVpbIMutN5hnh9z3Qb3xZKPeBQE7xOugbYL8V68VPp/hGYNZ5aM8ACjczoNwR+i3aLjYk2Ff/9aEHGFy51vxQFflVoMrewuzfwzwRMWoePkg9WEx4WS/B73+oefpGDRdFGEQyPiKzFhu26t5OXxyEUqWr/au/GbiRKoku1lwA052rX+NCjn11hhWY/9ONcRLGkoJiAshLXbW6xh8oGJGYve3Ye3kMnLJFo4=; 5:QIV8/GtrnNUpQ6nzZ1z0Olo1X+QmySAEH+qx4J6+XlVk2ln0Yza5sdxqgwaTKVmoTca/GTUwFiKMMV4M+RRxPfycWnclHESWK0XmA8ifyHwNoMfS9D+NrDQWreOH8S3+gTz4zi1mDvt0LL4cIMTnMQ==; 24:WCtbmKsB8GI271ase1s2LwI6egoBZ2UyZFg+MtD/dx6lpFsZ5InRQ7flYERpCZQ8nfrMafsHEQx1fvc0Cwh7kGQocX9d0nkbxN38zpFpVjQ=; 7:13Hj1XRHQXYwtjI/9MNuJHWiki2XyusZPfFlya1b/ghcFmy8kZgPiVrQ6j5wBhrjgxN94zPERyq9S4VMVLbxfhHYtAJoGXZfQ/u5guIAPHtuTTTsyZFMizPVMDEt7rVpN8DTwL+7ztmZjggYGcPE/rVThHEk2b50016lZ9X+yPYrPYguhkPnfNdxLSBUVgxj3Kc2F17lJLE5UZiHHv83Re9FcbvlLpQ9Rxn5W8eU4BaznlSrhMUzpf3rNMBWmpLM x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1494; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN3PR03MB1494; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1494; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(189002)(24454002)(13464003)(51914003)(69234005)(199003)(377454003)(7696003)(6116002)(102836003)(86362001)(3280700002)(3846002)(68736007)(3660700001)(76576001)(33656002)(97736004)(66066001)(19580395003)(110136002)(8676002)(87936001)(122556002)(81166006)(586003)(105586002)(81156014)(106356001)(106116001)(5660300001)(99286002)(19580405001)(305945005)(10400500002)(2906002)(54356999)(50986999)(7736002)(76176999)(2900100001)(101416001)(7846002)(2950100001)(9686002)(5002640100001)(92566002)(189998001)(4326007)(8936002)(74316002)(11100500001)(77096005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1494; H:BN3PR03MB1494.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 03:45:53.0383 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1494 Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 03:45:55 -0000 Hi Liu, The first version of the patch was reviewed by Stephen and after he agreed = I have incorporated all those changes in v2 and v3 had only the style error= fixes. That is why I have put the line Reviewed by . Still I might have some errors in filing the patch as I am new to this. Do = you recommend to submit an updated version or this is fine ?=20 -- Regards, Souvik -----Original Message----- From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]=20 Sent: Tuesday, September 6, 2016 11:38 PM To: Dey, Souvik Cc: dev@dpdk.org; stephen@networkplumber.org Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio Firstly, thanks for the patch! And I got few more style issues for you :) The first goes to the subject (c= ommit summary): - the prefix is "net/virtio", but not "virtio" - a space is needed after ':' On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > Signed-off-by: Souvik Dey SoB should go the end of the commit log. > Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey ") The fixline is needed for bug fixing patch only. Besides that, the commit h= as to be an commit has been applied before. > Reviewed-by: Stephen Hemminger I don't see such Reviewed-by from Stephen. I think you should not add it, u= nless someone has given you that, explicitly. > Virtio interfaces should also support setting of mtu, as in case of=20 > cloud it is expected to have the consistent mtu across the=20 > infrastructure that the dhcp server sends and not hardcoded to 1500(defau= lt). > --- > Corrected few style errors as reported by sys-stv. It's better to keep old changes, such as: v3: correct few style errors ... v2: .... FYI, you might want to read others patch to get more used to the right way = of making a patch. >=20 > drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c=20 > b/drivers/net/virtio/virtio_ethdev.c > index 07d6449..da16ad4 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -92,6 +92,7 @@ static void virtio_mac_addr_add(struct rte_eth_dev=20 > *dev, static void virtio_mac_addr_remove(struct rte_eth_dev *dev,=20 > uint32_t index); static void virtio_mac_addr_set(struct rte_eth_dev *dev= , > struct ether_addr *mac_addr); > +static int virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); I think it's not necessary if you defined the function before the usage. --yliu