From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0078.outbound.protection.outlook.com [104.47.41.78]) by dpdk.org (Postfix) with ESMTP id 76CBC6CD0 for ; Wed, 7 Sep 2016 05:47:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lDaBund7abO0jatdDLX52mQ3LU87LD+eT0VlohqWSQs=; b=KtG66XwzwuLeXFNcyjmctcNMaNvdTlYOZQsH02dcx9jR772RyET+KWv9XFfRdc/uE4DJndYx1M6udZD5+dEyLlnVIXah9NmfJMoPVkkE7FmjLShB+CWdT+0WM4FfqpNMvwda6amClAEZEhPzh8jgKw6emI4nc9IsOZaUjMH3YU4= Received: from BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) by BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Wed, 7 Sep 2016 03:47:28 +0000 Received: from BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) by BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) with mapi id 15.01.0599.016; Wed, 7 Sep 2016 03:47:28 +0000 From: "Dey, Souvik" To: Yuanhan Liu CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio Thread-Index: AQHSCLcSnGzpImrFO0KRsTEgY+TdQaBtYmQAgAAA/xA= Date: Wed, 7 Sep 2016 03:47:27 +0000 Message-ID: References: <20160907032156.34492-1-sodey@sonusnet.com> <20160907034252.GI23158@yliu-dev.sh.intel.com> In-Reply-To: <20160907034252.GI23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sodey@sonusnet.com; x-originating-ip: [66.30.138.194] x-ms-office365-filtering-correlation-id: 34cae0c0-fbd4-4c5b-fabd-08d3d6d1b028 x-microsoft-exchange-diagnostics: 1; BN3PR03MB1494; 6:VgF0Am1+JVktMTZKLtvBSCSsghyTLWOse3PJb3ODOoKM48Rupe4csN4HB2Qyuwp9OkXpzPQWqabRLC8/iT/fOAUO4LfahRYtT+kOSkvR38fqtzcGx4OhjQgA5WMHNf3OR+5wvXm2EAqAsp3tY6gqN7BtotsIhqyR1b3tEEEOSvVslOXc5j2nbQPmpLT48PCuc0uiOd6HaPPMlfpDtDpje+Ba13ow31qcNaPYYmndpl4Gs8Nda5le0Pn055lKPWrMrYXu0oWRD/G+P0sBzjsCuCFdPgt982etEcgi9PlSc+k=; 5:LxZD4tK3hcjsA62eYIfSE97DJZc8c+1yxbPv4E9G5WIbobeS6RnxEQpsYeWe1a6jcCEH+VLH2BAppMwbWHp2plh7+MNyNU1U/5Ns0uE+4zWY3BdmxfzMR3enM+oHmJ55jehM6z7JBU3PCmxOODfO3w==; 24:G94cDBzNKMiLtnxH9j8hR5YgkOqlITAxAc+jUqFCodS8DnDuj+DghYAx+q/tYhSWIrhwR80JdEI14pYcyzs2HzOfqecLvQ4+AQhj8ceW0PE=; 7:szw2DZNBeg7hZa+h2vJ3vmxFQHtS50IRiQ2QlfF5Jx92KzODIqggiXfcxNnyHiGE5tnB31C/wRdDBaBfjKwvjSsKUmJe86WUwc9nCbS+HsyCE1SDps7cRxB9Pf7E8JFL/kGO7zpNp/kLFRUh6RT0f7rveJyPia7LhKf1ch9L6IDWrPsxNCl1jEjncgiiaxpWL3V+VHXKdRAPr557Ve7jWvZ5dBemEuFw4267sDthRRgDOYGb6+KcZWVMq3XOAT08 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1494; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN3PR03MB1494; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1494; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(189002)(24454002)(13464003)(57704003)(199003)(377454003)(7696003)(6116002)(102836003)(86362001)(3280700002)(3846002)(68736007)(3660700001)(76576001)(33656002)(97736004)(66066001)(19580395003)(110136002)(8676002)(87936001)(122556002)(81166006)(586003)(105586002)(81156014)(106356001)(106116001)(5660300001)(99286002)(19580405001)(305945005)(10400500002)(2906002)(54356999)(50986999)(7736002)(76176999)(2900100001)(101416001)(7846002)(2950100001)(9686002)(5002640100001)(92566002)(189998001)(4326007)(8936002)(74316002)(11100500001)(77096005); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1494; H:BN3PR03MB1494.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2016 03:47:27.9637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1494 Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 03:47:29 -0000 Ok will change it. Do I need to submit a new v4 for that ? can I put your n= ame also in the reviewed by list? -----Original Message----- From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]=20 Sent: Tuesday, September 6, 2016 11:43 PM To: Dey, Souvik Cc: dev@dpdk.org; stephen@networkplumber.org Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > +static int > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > + struct virtio_hw *hw =3D dev->data->dev_private; > + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { > + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); I forgot to mention in last email, that you should not use the number (64 a= nd 9728) directly, use the MACRO instead. --yliu