From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0077.outbound.protection.outlook.com [104.47.38.77]) by dpdk.org (Postfix) with ESMTP id DEA68475D for ; Tue, 20 Sep 2016 20:42:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R1925BHvFLj78MEKpzkhZ8WNhkHtpXBinC6E499GO0U=; b=JriRqzGxvocyfyeS0kcLlDXq/FFJR8eyHKS7BAsw2ekzCtkm6E3nn3+LAs3cqq7bUZfuwJ/cA6gu/qmsCPaA0f9kixNwQd2QjxETu+uZ6dPveXloYCi8C3y1iZqj4xExu+Zt+SkS5Su2pL/sxzlSgRlSYlBLCR+7hnsrRz7xp2I= Received: from BN3PR03MB1494.namprd03.prod.outlook.com (10.163.35.145) by BN3PR03MB1493.namprd03.prod.outlook.com (10.163.35.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Tue, 20 Sep 2016 18:42:02 +0000 Received: from BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) by BN3PR03MB1494.namprd03.prod.outlook.com ([10.163.35.145]) with mapi id 15.01.0629.006; Tue, 20 Sep 2016 18:42:02 +0000 From: "Dey, Souvik" To: Yuanhan Liu , "Kavanagh, Mark B" CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH v4]net/virtio: add mtu set in virtio Thread-Index: AQHSCL7xEgAVZJyiaUu1GlORUNZIaKBtbHzggANRoICAAHiC0IAADvoAgAAGmlCAAAQsgIAAJdjQgASBloCAAAPRgIAC9kuAgAkZHwCAAMBxsA== Date: Tue, 20 Sep 2016 18:42:02 +0000 Message-ID: References: <20160909070009.GS23158@yliu-dev.sh.intel.com> <20160920071152.GR23158@yliu-dev.sh.intel.com> In-Reply-To: <20160920071152.GR23158@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sodey@sonusnet.com; x-originating-ip: [208.45.178.4] x-ms-office365-filtering-correlation-id: d1cf78b9-13c0-4bb6-0381-08d3e185cfec x-microsoft-exchange-diagnostics: 1; BN3PR03MB1493; 6:FGB4/xS9SA8ejsZeP9o8nC+9dN8tFyxlmRIXGgJJyCvg//q1t7Mpmu1x6IqjQ9VlPaIiTeZ4iwgUmg/DLgif0YrW1oPM7kDosdoh8J11IJwsm4lZrJeQsDz5EkhlwAHm9Ot0i45NpDHQm2Q6nRNONkvo60UbWSGnL32sb1H90AyS0ITsCGgXibeuR2WssN5RCtwMVzKgURbsV4COhli0JTKxFLkGfSeKKbvj7btC0B56jFzWSSNSUUEuHWtrGBNpEBXpWbRRuoTn6N5A9mD9v5Dx/Cl4tNAXUcgNdCIpAu8=; 5:OE3AMbwj/DJMH5NAXCheM8tly4R2XCfsODAFGxYPLy+hR1Zlpsn6h1/PFxYjYbEV43AoWOc+Dl8GHRZdZ26PHT7Y/J/nuCFMIap7BkGPi48xoM4ldpvtygWVYNdSvBcKNsFhMakRy7mGOyI4MxScRg==; 24:A4S5OmjrqKflb8OTtpwhDTS48qLIB9l52YsYyZWY4CR+3R6A+GIZhRwpCb9vByK+oEfTCqUAtrNhX1nhqQd1zTlyrwRfWXBZa1ryrscQJ3k=; 7:CvMCW+PqB/AKN0TMJaWAF8PbH4UHqqrQQPXbXrF6m4y6PyrBjc6s39LPMvybVs2K6M3i+M8wvseXojIjAkIq5cmUAWZNgfnyQBEG24QNtNBdvYjEyZpIybRkosFcsVcQq8sJQtHUcm+5dp1aglaZrYRr2zGD9h4i30qgfekXcJ9dwDI+98Rn1/4WxAFyy3KfYUCsJdam8quhVfXqV1Tm8usqSlOR5Oongb9yE+Z7Ge89KqlPwlPxzUZtjtVGD4GxyP19VoQYB7VrbykXD4IWvBDwK9L03kLXdn8XCzJDrAApUtA29I/AIFT6BYeTVL3V x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1493; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001); SRVR:BN3PR03MB1493; BCL:0; PCL:0; RULEID:; SRVR:BN3PR03MB1493; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(377454003)(478694002)(13464003)(24454002)(189002)(199003)(305945005)(77096005)(2900100001)(76576001)(93886004)(2950100001)(106116001)(99286002)(66066001)(105586002)(106356001)(97736004)(5001770100001)(19580395003)(33656002)(122556002)(19580405001)(7696004)(101416001)(102836003)(6116002)(8676002)(54356999)(586003)(189998001)(50986999)(81166006)(81156014)(76176999)(4326007)(5660300001)(8936002)(7846002)(2906002)(3846002)(74316002)(7736002)(68736007)(11100500001)(86362001)(9686002)(10400500002)(3660700001)(87936001)(92566002)(3280700002)(5002640100001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB1493; H:BN3PR03MB1494.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2016 18:42:02.0879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1493 Subject: Re: [dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 18:42:04 -0000 I have already taken care of this in v5 of the patch , If possible please r= eview the same . -----Original Message----- From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]=20 Sent: Tuesday, September 20, 2016 3:12 AM To: Kavanagh, Mark B Cc: Dey, Souvik ; dev@dpdk.org; stephen@networkplumber.= org Subject: Re: [PATCH v4]net/virtio: add mtu set in virtio On Wed, Sep 14, 2016 at 12:15:37PM +0000, Kavanagh, Mark B wrote: > > > >>+{ > >>+=A0=A0=A0=A0=A0=A0 struct rte_eth_dev_info dev_info; > >>+=A0=A0=A0=A0=A0=A0 uint32_t ether_hdr_len =3D ETHER_HDR_LEN + ETHER_CR= C_LEN +=20 > >>+VLAN_TAG_LEN; > >>+=A0=A0=A0=A0=A0=A0 uint32_t frame_size =3D mtu + ether_hdr_len; > >>+ > >>+=A0=A0=A0=A0=A0=A0 virtio_dev_info_get(dev, &dev_info); > >>+ > >>+=A0=A0=A0=A0=A0=A0 if (mtu < dev_info.min_rx_bufsize || frame_size > > >>+dev_info.max_rx_pktlen) { > > > >It's not clear to me whether 'mtu' in this case should be compared=20 > >with ETHER_MIN_MTU, as per other DPDK drivers, or alternatively=20 > >whether 'frame_size' should be compared with dev_info.min_rx_bufsize. > >Any thoughts? > >[Dey, Souvik] I am not sure why virtio min_rx_bufsize is less than=20 > >ETHER_MIN_MTU, i think it will be good to have the compare statement=20 > >as If(frame_size < ETHER_MIN_MTU || frame_size >=20 > >dev_info.max_rx_pktlen) , then error. What do you suggest ? >=20 > Again, this all depends on what 'mtu' means in this context. >=20 > Since you mentioned previously that it relates to the packet (i.e. L3) le= ngth, and not the frame (i.e. L2) length, I would suggest that the comparis= on should be: >=20 > if (mtu < ETHER_MIN_MTU || frame_size > dev_info.max_rx_pktlen) >=20 > Yuanhan, any thoughts on this? I think you are right. At least, that's how the ixgbe PMD driver code looks= like. --yliu