From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF6DBA0C41; Tue, 22 Jun 2021 09:40:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71A474003F; Tue, 22 Jun 2021 09:40:23 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E77EC4003C for <dev@dpdk.org>; Tue, 22 Jun 2021 09:40:20 +0200 (CEST) IronPort-SDR: QlVpIOzZKhHwvpG1YP9fnxFo12HRtnQRQnaI3ghu+MIuoVLG9ez33whZolxAAdjbdNBKZiGBN3 mwhRTHu+odHg== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="194313537" X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="194313537" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 00:40:16 -0700 IronPort-SDR: pgm5tiDvCi6qEsSwfBBmPxXGOcBa/xlQOL+JSwL+5kVTRD74LD9jazolybw8GzbmDH4BrkeSrV aTe54NQ4k+sg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="623380245" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 22 Jun 2021 00:40:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 22 Jun 2021 00:40:13 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 22 Jun 2021 00:40:12 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 22 Jun 2021 00:40:12 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 22 Jun 2021 00:39:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TAXDq/aUaVpiuYYo/HEzdnFUaNEgTG010Jp/aoR7UH06WFniKG9VSatGrWv4UA+vkBA+MpOKJTk8md/YP8Ioi2BgWStyUaI/EUgq6uNFvP0WHXGDBXIs2DceyUg417qCzUYJdNc31TbAUVCC4LT+J5Jvria1FOjri3v6/sbxF7JjD/LgSOj+zRqDT3MgpxCswcyY//rFUilhbrdbOtR4EWIT2D9i7W0BZqU7LDiWMxBShKlfeBAsARCgJv9ueK9xXU6VPGXG2B+tuHivpnEcHEx4PhUO25Df4kbVvYiEgY3iNVF7thE0TKnfjLpJ0kV64vn03jZsbABLpzJt0NwYsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLAoir5aER9WmtO0fLSXbLOCrQBkkPEIFoTLGdvD8Xs=; b=c7KyJKzPWGulxlGsiN1FL9soP530oCUA5fvqR8aXWvSLYVXWDd/5qCbc0a7e8QGd+nstTpzymAr7rjTvCkHTlh1eV47ijxgFtKBst6ULB5gboonvWnebmkPeBu7oHt6/BOhbPxy6BIxt57T2YIwWz3mQHEfYTqsy/W8aVGcQVaP9zp12crSbwInf1scOt9lnZ7sVHFLrAVOuBNSNsHVmOQxr4UPXWjKADOnmHO9+djB/M0XYb0DkCcv+Ru4K9QVPoUebyQ5Z4aHv6MW5CLCxgdBZEHmhYYsM/Fo+XXIIDTu1yrhHkcZOyoGIgbWPNckDByunSINFo4/o0LSATOUMAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLAoir5aER9WmtO0fLSXbLOCrQBkkPEIFoTLGdvD8Xs=; b=N+yy1ap540W73YkyBh65InWOYn4aoNfbLa7uUjFI6O8Zvw7T132iftvoptG8MDI7TOPxAcovUzVfJksr32Gprnpi7cpfjkWE2xcro6SYIPy5tfl8XkuyR+mwOW20Wi4ZcR4q5jjfaQ+21QqzW4oXEN9NIWU+wNnmAYnzIU6NC80= Received: from BN6PR1101MB2097.namprd11.prod.outlook.com (2603:10b6:405:50::15) by BN7PR11MB2723.namprd11.prod.outlook.com (2603:10b6:406:b9::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Tue, 22 Jun 2021 07:39:41 +0000 Received: from BN6PR1101MB2097.namprd11.prod.outlook.com ([fe80::d9b9:a3a0:9345:812f]) by BN6PR1101MB2097.namprd11.prod.outlook.com ([fe80::d9b9:a3a0:9345:812f%5]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 07:39:41 +0000 From: "Liguzinski, WojciechX" <wojciechx.liguzinski@intel.com> To: Stephen Hemminger <stephen@networkplumber.org> CC: "dev@dpdk.org" <dev@dpdk.org>, "Singh, Jasvinder" <jasvinder.singh@intel.com>, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Dharmappa, Savinay" <savinay.dharmappa@intel.com>, "Ajmera, Megha" <megha.ajmera@intel.com> Thread-Topic: [dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestion management Thread-Index: AQHXZnAfjzCkIR4zDECduhJs08StzKsexqeAgADO6lA= Date: Tue, 22 Jun 2021 07:39:41 +0000 Message-ID: <BN6PR1101MB20970DF5FB1B90846222226B94099@BN6PR1101MB2097.namprd11.prod.outlook.com> References: <20210615090200.56824-1-wojciechx.liguzinski@intel.com> <20210621073506.96017-1-wojciechx.liguzinski@intel.com> <20210621073506.96017-2-wojciechx.liguzinski@intel.com> <20210621111759.30cae7c2@hermes.local> In-Reply-To: <20210621111759.30cae7c2@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56268336-82d3-421a-a86e-08d93550e5bd x-ms-traffictypediagnostic: BN7PR11MB2723: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <BN7PR11MB2723564D8D5F01C5F9DBA49694099@BN7PR11MB2723.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6j16/TF/A5S7TJV2MLLdtAm0b8rxXRqH9AtDUnr7hD53u6qOYnGpmDh4wNrK2Vo7X0200DnmHarCnzo75eK3UmqOUPZPODfjrkGjaVtPSGUPMR1wOq/+8GKVoX48ny3l20uonTeXhLt/cBmwZ1OS/vQs4952AGqVzTzaUeBMAbz9bBXNapqPD7dwPm81YkT36Iga9yTHug7gJL9nqzCagzsmQkFqXdGwNu1VcWbP0vQP2Yk/duFdEOtnMNgz/JBFH8hkv+XSrF4MFgThmZjE70M+axm0tzuhUj3aFf08vg1lrRPa8+FrbspMgfbJ62xZPiG6Hw2PJmXoxkY1NJSb+t9FjWXauWIBw2sdE7pU/nsZErb/Ev++v0t6D8u385CIDpmM7JxEO57D2MxuLDerhkg/SLWcuNCNfylu84Klzs9hKD6RsoPZbajAq8glQ4FKvSiSB25w1Exrl4y8LxEbHbS+/Rsvc+vERvmZyyQDe5mxyaeBzcf9PpPXzc7veh3ukswONH0bmRWQqacBCNvd7lE1oeIXKLfFiYctX9hS+cfZBlVX7NqWVbCaKGk9jJv5xjuQPpKjDgRtE9MC++fiZ8Uw9YM+0rngf3xPfklu9yo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1101MB2097.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(39860400002)(396003)(366004)(136003)(64756008)(2906002)(66556008)(66946007)(66446008)(66476007)(26005)(186003)(8676002)(76116006)(5660300002)(478600001)(4744005)(33656002)(6506007)(54906003)(7696005)(53546011)(316002)(55016002)(9686003)(52536014)(38100700002)(122000001)(83380400001)(86362001)(4326008)(71200400001)(107886003)(8936002)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eXdVgWnsAQjQIZeWI1QljYgup3prV0miCYO3nKc3I8sEgnF/0853+Tbm0r82?= =?us-ascii?Q?W0jY5DHi4VhEm+dsmQDye0PgFjhpqt9kWfbk5JcYLiAx4TyuF+ZdLMgyrmyg?= =?us-ascii?Q?G2EbMCcY6lcghhbgxyLjgWwU6we6pSw5i9tW7reNMHoyFJTt7GjQFTZmw5ej?= =?us-ascii?Q?4IJQ7tXrvYSta+eZ2yFTS9/n2ZLgzDuEoHbU2rwEJm2/qkxgpIGrTprqi0fk?= =?us-ascii?Q?IsPZ04FsprpGYxi/ym/IW5qvHVP2Ai4GavfFNnslHgOXefeJUO+8CKN3UV5q?= =?us-ascii?Q?9txMNIJXXdSbrm7le53RfPEkXMT9sPgvocGoieb8K0AkgYTLidFgfpgZoqEi?= =?us-ascii?Q?cQMwgeAnkanSx5vVuM6R6ScDGSTAZiKzfU/2fhUVCLlc2Ty7NIQAPqjEc8v5?= =?us-ascii?Q?3QjQS2lMLTq30foVOVxgmc2t+O4Sen4CLu876KgoSm3eRHA3OhfuKhy/F21x?= =?us-ascii?Q?FqWGzkAHxRR9UFzUOmfBk64AkVNp7DArteRol5UDs/Qc35xHevo4L4KV61Bu?= =?us-ascii?Q?H6mijhBC6WqjPkch49jZfBrmU40p8tW3er611wAXPqn+f2Et6qAzjNOIbzNN?= =?us-ascii?Q?KG2wszO41ajZ3wCusFUkqZWBYDsZBJo4oeqizlHzaV88Bym4lkl/3jgjEBJs?= =?us-ascii?Q?C7A3cUQICRLXqn6vB96rnDdhIDKzmrH3ziSjaxXTLUWEGt8/Rb/Z0FjzbQ83?= =?us-ascii?Q?05d1ZkJWf964gUW7uIDaFbGyyb9bxa2ElKFNAkuI2rlZ3PbjkhNCwrNhiPd4?= =?us-ascii?Q?9KjzRp4cMge4a18TDyVZ1DdDenJF7iHFZ7cYaMb0xsjdG1FFLVUwbKwjbYoM?= =?us-ascii?Q?uwzuANsDWKXzqC3XiB7XNHsjy87s/xkjjhZFpr6p3VBcZ5DXkEWfcecYC+LK?= =?us-ascii?Q?puG2ZHhkb5hNq4E77RCwBGK2/QWb0Zp1LkVMVIHE4NJqFNi91kQV/b5ipngW?= =?us-ascii?Q?RBlxJkFTKeZbGfEWD9RbU/00tFCFR5dOJbTfAjy4D8/IAjzMdXxltizPi3S4?= =?us-ascii?Q?HELKdmdT44vKcWen95TTcaHhlsP9fMyzl0l0ZXJUIbGx9tiabvUdq995oGmA?= =?us-ascii?Q?2Z4jB6PI3BvKWqsfz0qMZXMu2nFN5u+5JUJ/KYT0Z808pj9WJNgcNNr984p3?= =?us-ascii?Q?0bEXpJNkftg2TutaaW+aTyWUU3VXaR5oteyaW+BSh044CDzMj1AfiFZnt6+7?= =?us-ascii?Q?XY0rEsz44DiejeRVzXY7LtTZgmNCmV+tD6gtEBtrNa79Ne4GbEx0nToqiwIk?= =?us-ascii?Q?Y6q4Kul1Gwd1Nladvn5umRCiVrR5gD6uKt9tinvp/x1v7/k/Jo2YLpGQPh55?= =?us-ascii?Q?JmXmoA0g5iOry0fk0wbo5JPW?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2097.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56268336-82d3-421a-a86e-08d93550e5bd X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2021 07:39:41.5814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n0WkNCgNdYAGTRKAp9xbcISgk835HsQdFOr7IZkFB9aOgEQeANH6xv3zQATlijHyRo/5txth9AGcewf4lBZbYN1VyKa67EU5/EKTRIJBxIM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2723 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Stephen Hemminger <stephen@networkplumber.org>=20 > Sent: Monday, June 21, 2021 8:18 PM > To: Liguzinski, WojciechX <wojciechx.liguzinski@intel.com> > Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitresc= u, Cristian <cristian.dumitrescu@intel.com>; Dharmappa, Savinay <savinay.dh= armappa@intel.com>; Ajmera, Megha <megha.ajmera@intel.com> > Subject: Re: [dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestio= n management > > On Mon, 21 Jun 2021 08:35:04 +0100 > "Liguzinski, WojciechX" <wojciechx.liguzinski@intel.com> wrote: > > > +/** > > + * @brief Initialises run-time data > > + * > > + * @param pie [in,out] data pointer to PIE runtime data > > + * > > + * @return Operation status > > + * @retval 0 success > > + * @retval !0 error > > + */ > > +int > > +rte_pie_rt_data_init(struct rte_pie *pie); > > All the new code needs to be marked experimental. > Why return an error on the init() function, then you are going to make ap= plication check the result and lead to lots more code. > > Other places in DPDK use void for init functions. Thanks for comments. I'll apply necessary updates to V4 of RFC patches. BR, Wojciech