From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 685DCA0C56; Wed, 8 Sep 2021 10:50:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC40241158; Wed, 8 Sep 2021 10:50:09 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1673C4013F for ; Wed, 8 Sep 2021 10:50:07 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="200626589" X-IronPort-AV: E=Sophos;i="5.85,277,1624345200"; d="scan'208";a="200626589" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 01:49:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,277,1624345200"; d="scan'208";a="538458889" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 08 Sep 2021 01:49:54 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 8 Sep 2021 01:49:53 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 8 Sep 2021 01:49:53 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 8 Sep 2021 01:49:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ARK6FR2Nbtog4pJpgjJpawbIMfwGjl37GuWKqVpDtGdvB2ofpcgXXhwoAkkmWKFZYbzNzGNdbkpZJGQe7EEm5MfSqvgxe7LuxvjfYNPAxJoYkVt9p3HunJA0U0kz6hj+gWMffKI9iJ0qwZmdfeDYoDqutEhbf7SyDGW4v71NwBjajgfONyix73i+nWC+L7D4JzbZMJ648DaiSQoUAWEVO18RxDaxA12f3iCQEK9CyYuG6FyeFg/STtY+aEyjhoIBdupAGj+r++uB0G00CKhDujKAtqeIlH3dq+sOu3hNDfn6fY4kvp2kkkEjhYrZPdzjiBnPukFd5DuDLF61v4WBDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u36nU2nUZ4jkTtHJQSx8vaLUqU1h0fSSJC0S2XCQqlo=; b=THFHFYOFQYFL5z2w82zNBJ6O0IPiwIg113EOvJnQJdzdUb0eSyLfbUGTTqbCQMtyz6AKbDc1g6qkkWQ3SxfRfK+jBz4gPZLeplPGejqf2bKi7ruPx+tyCUT2QsF5LI5v26/RsTGnjKa2Wd/rrD5Gl2gNBUIRR2QceWQCvof3ngghjmGDs4zeOFYVcGT7Wl4r3DnBdaMgxTC/Dw1uoPBRsU0Vb8meqG5+3IYX+1/04n0Lltuc1Rh2Epjhl0T8DxdjDvHBIuHVjW28N598QTxLsZiqXWBfXgi7a0x7mgwiT32zOCXYu/teXQmQbi4RUMB8YQzbeKASZcOhFwtMdETqmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u36nU2nUZ4jkTtHJQSx8vaLUqU1h0fSSJC0S2XCQqlo=; b=LrmO9dQPU+PwnM7CEQLiECiZ99ojTAnmQk44CriWsaPIo42lHmDPS4yzXPO5j7AgZcsroEFGoh2hz1C6u2/xKxUkp3y9P9OcOLvY+jcU6cW/HpkfqOTk/eutPIYOm6GC+uwImT9mcdHB7uoCqkTBoeQns3iwnP9Z2SjC75mvHjg= Received: from BN6PR1101MB2097.namprd11.prod.outlook.com (2603:10b6:405:50::15) by BN6PR11MB4082.namprd11.prod.outlook.com (2603:10b6:405:7d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 8 Sep 2021 08:49:42 +0000 Received: from BN6PR1101MB2097.namprd11.prod.outlook.com ([fe80::c956:7464:422c:8c45]) by BN6PR1101MB2097.namprd11.prod.outlook.com ([fe80::c956:7464:422c:8c45%12]) with mapi id 15.20.4478.026; Wed, 8 Sep 2021 08:49:42 +0000 From: "Liguzinski, WojciechX" To: Stephen Hemminger CC: "dev@dpdk.org" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Ajmera, Megha" Thread-Topic: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion management Thread-Index: AQHXo7q+9IZf8lorTkynGWasXiVzYquY8c8AgADaVAA= Date: Wed, 8 Sep 2021 08:49:42 +0000 Message-ID: References: <20210705080421.18736-1-wojciechx.liguzinski@intel.com> <20210907073328.1498973-1-wojciechx.liguzinski@intel.com> <20210907073328.1498973-2-wojciechx.liguzinski@intel.com> <20210907121452.3788c935@hermes.local> In-Reply-To: <20210907121452.3788c935@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7eea68b3-9250-42b5-1e46-08d972a599e7 x-ms-traffictypediagnostic: BN6PR11MB4082: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 03P2BUVU2aeJQ278XA3NCW3kJcwBgA3I4faOpUnThRfByZGUk/R9JGvcRnL8VpJErSW0IZU6ydUY5d3f+hD1f16n9xHNUWa5W9jFWIl6SQMYvRvmd7PHfRbCmHzAcJV81fC7O165grn0yjjmECLSI5i6NCgg9j//bxNzK34upu2sXLkHoMxlFfZh7GaPNldoXbU3LCGJXF5fnXNgHL7DeTdgtVoc/yFz05sxEcEiklg33riSdnyzo38ZQyghfLqAa6bCBrunn8+ta8XyF8iiMYsZ7LhvSRjYIIR33xwBPjeE293fLNRVV/Od9tXH3SEfyTyrhsTAzvzj0W9hLf6LTgt7cc+JvU2FFDKf7hn/8QvqDYYXgCuIpG5YibMmghE5R2Mp4ZULzUW9F2xySJR26y1vRG0aYUIiMNC4YAJ1yJTS3SwmiTDIJfOUqPNSE8MMLHp4P+D926G4dNr+cy/jSETFuGt5d/JFyHAOQRINOYSzKjjASd8JIjvXiZEZW6xZWQ57cxHMC3Ok4PvculjLf0MVtl1J7/pDuJgpa49IzVA+e326pCeo/zYOeQECoYy2Ng1vue5nl1p/24JBnCG0OTtv8a3e+IlBFSFN2ABsV2jNgrmEXgc0E364YbHFI+uKIuSy8pSvMCZLaPrRfFLIbilk9ZCv/5/u9Rjfe8WbNrOIJNe8pozWlt4GprRvOdnjXSz3dHE7UNMj4kK6WacHkg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1101MB2097.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(53546011)(8676002)(83380400001)(316002)(6506007)(5660300002)(8936002)(7696005)(6916009)(26005)(2906002)(86362001)(38100700002)(122000001)(71200400001)(4326008)(52536014)(9686003)(33656002)(64756008)(66946007)(55016002)(107886003)(186003)(66446008)(76116006)(38070700005)(478600001)(66556008)(54906003)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vo/FVbtR38xJUyquQCLNlqT/ND3qe/zI+E/PiMpG/PpyeBBPXyFmSVa6es9R?= =?us-ascii?Q?wKMnlcQemmgYPREoMRfPRW3ys1NOhkTR2cJ3m93YXb27LeKNczYSw6OHjlHx?= =?us-ascii?Q?jcEdJ2bIjw2P6CaJ0UmbcEDFV6rC5tk7Rda3TjBhgiONLp9lOMoYRDtRM2Q8?= =?us-ascii?Q?jXGPtQC9c3J+KBIfegJWND8Ps9IXgAnkJVe4xVq49S4atglwZBkW16qsas91?= =?us-ascii?Q?t2bus5K6wjGhjSJjDa0p+w/gYtlisfesHyomDIHwrwrbU6mQmm+R01+R7NWx?= =?us-ascii?Q?XRia2YKxs05yCfRxJf2j8+OUuZLQNh5TSE2gG4MGfIRluP+pPdnngN633rpu?= =?us-ascii?Q?tBsSu8rakEmmuXkgL9y6jOoaR+3PYV7cYTm1rUINEB2W5ZEPM7xf6I+3vy2Y?= =?us-ascii?Q?elOMBfsTtSy0+HiCC/3vLnBM2kQMt3WZctuj5HtiMorRK3k70Tb5+zLR3hq1?= =?us-ascii?Q?nBfEiMIMzRNGMmceYOqM4dxFxp+lqj+120PDdPWuZKVCbjjLcAvdsfmJsST9?= =?us-ascii?Q?uPpp5cYs3KXMQMXgPKf8UmxxyUYckouIH4s1gjaLGzY3tRLalFDGIgkD+upq?= =?us-ascii?Q?MiFWELqKAiWQQYkBZaznHgz40y5GeZ69lJEXUG44kjin1C/RfCgkZIv0+ZuG?= =?us-ascii?Q?HO9FH9GLDFooT39qZ3UaetKPFkN4B6CdCQn4lp/cJwb0TAkl2n81O7IaQHrk?= =?us-ascii?Q?mq17pjQxZJYE7GkIWKSACOSkCD2asHDFmTnAXWDh5qhMHVobOQJQOXmFDDAk?= =?us-ascii?Q?E6JEBxravOEO5eWCLnF/lEjpkxuUGoM/oDp9p9DjpL7G8idQ/LY3HtWDIQf3?= =?us-ascii?Q?8oHV1KoNrL0GnZudHKQX+ofl0IODJxmg3hWCnrlcjZVt5Ym6pdR7Q/LeKtQ6?= =?us-ascii?Q?ROE0iuK6bdTSzygAMWOtTJv0e1TzJl8QohlPbWxvbTmTNBeOE3Pgu+mquCC/?= =?us-ascii?Q?lL7YunqC8WZsGt9ozHB08KpJ4O6r6o8I48XowFtVj9ZrWsX0NwaDL8aXLAn8?= =?us-ascii?Q?DX4MDs5aQCNGN1Rtf2qHR+y91rb/kXSGtBF7UePJxmcYk0V044TC5/DM+CRj?= =?us-ascii?Q?VcWj4DcAD68wYhzwfxOOa5R57fZFWs949OPI5VqAtqoT2ejDNFp6SIz4nb0f?= =?us-ascii?Q?Y/LD4eJziY+Z6GDHtZwNx53WGWuiIgmpgt6g+vrZQFh4A1V4KUEzAckzXtXv?= =?us-ascii?Q?BNXP293xxCl9AkBctbcqE6SDVgK4B9Q3N0BrRi4EF+mS3WlsO45BORH0ZTfw?= =?us-ascii?Q?v//Xwn1nUpj4s9gHz2Gd+aMoHapuzWLdmkIEoc+7QmFbIFJxMVaCZOPKRYt+?= =?us-ascii?Q?GF+VGkwfc5JvKwKn1ywNLfci?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1101MB2097.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7eea68b3-9250-42b5-1e46-08d972a599e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 08:49:42.5197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J3OClhyNpiK6UBjNFeefwFuQIbGqXUUD77507RIq3mP5pEf1VNb9PvYZLJfk0hfVkcCYNbwNfq10hnjEmtshFc7YtXiHwVjoh8THuS3UkwM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4082 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Stephen, I will do my best to apply your comments. Best Regards, Wojciech Liguzinski -----Original Message----- From: Stephen Hemminger =20 Sent: Tuesday, September 7, 2021 9:15 PM To: Liguzinski, WojciechX Cc: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu,= Cristian ; Ajmera, Megha Subject: Re: [dpdk-dev] [RFC PATCH v5 1/5] sched: add PIE based congestion = management On Tue, 7 Sep 2021 07:33:24 +0000 "Liguzinski, WojciechX" wrote: > +/** > + * @brief make a decision to drop or enqueue a packet based on probabili= ty > + * criteria > + * > + * @param pie_cfg [in] config pointer to a PIE configuration=20 > +parameter structure > + * @param pie [in, out] data pointer to PIE runtime data > + * @param time [in] current time (measured in cpu cycles) */ static=20 > +inline void __rte_experimental _calc_drop_probability(const struct=20 > +rte_pie_config *pie_cfg, > + struct rte_pie *pie, uint64_t time) This code adds a lot of inline functions in the name of performance. But every inline like this means the internal ABI for the implmentation has= to be exposed. You would probably get a bigger performance bump from not using floating po= int in the internal math, than the minor performance optimization from havi= ng so many inlines.