From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E0BCA04B1; Wed, 9 Sep 2020 09:18:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F3831BF8F; Wed, 9 Sep 2020 09:18:56 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 300D51B9B7 for ; Wed, 9 Sep 2020 09:18:54 +0200 (CEST) IronPort-SDR: O8me4yjnIHWfFJVKjsOhI1vlxTYvKi1bU0aI3GD8VL+z+ozmSblY8AIRM1IG6l1R1cZtFaLIpm Hwb5tWmAi2yA== X-IronPort-AV: E=McAfee;i="6000,8403,9738"; a="157559634" X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="157559634" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2020 00:18:53 -0700 IronPort-SDR: JENs21CNo2IE9aHshebFJ6DEfjUSCEQG/VQRNcCSuZcaTnvi8TUXojKUUPQCWOJ+8yhkIFHzsN hefhwBWsdIwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,408,1592895600"; d="scan'208";a="407373122" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 09 Sep 2020 00:18:53 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 9 Sep 2020 00:18:52 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 9 Sep 2020 00:18:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 9 Sep 2020 00:18:51 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 9 Sep 2020 00:18:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PCiFNkpV/qP4GINw3RBVpft3K5Muvc8wXBvlfUmEx3lafgPv8Y/wFIAsFEWLUPuBFEikWnowXB83qfwDcLa7oKK3Nd1IGMJ28xljELdOpzyGRNB75RkD2afZMRFOCMYV/QFcy6lzNdXNbDgYN7RP/gqtW/SEA9AEHcQFvwywKpZ0yvX8HzxOI1eLbdPXxuIawpv2pvfL4abKsQ+Jm6+laR/uSSPEVrbKCoWilzF2ZNaByo7w7YUKiFGGIE561LZMbTdiWje0RmPIpmYMtkLXrJIqucT0iW97IwibDo1MM6irXtqeudGnR1WYC2CirK3Zs4cppEEw5b4xvYXbPTD2DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBU73ku4gGObo6lH3DJ+mqR+lOJMy0ZzPl1+JUqgF50=; b=DO5Jshnj/821qmMFeX1QDjJmXfY0kpE4pXnGgDDjWE20wFjwYctmAxX7XVgFtGhINGBJF+ChiiZVmk/z+e2D8tYTHe3xbiYIA3hVmrTAtUlSsrymHy9PDkoQKV28t9ieOhk2/3qmz9q1eiBuWX8rt8xmIgdY6g5h1x2xNUzAJir2GO5key6+c363NhKYHOpNmyXzr8wgF/TkZ1aa5OOnrKPbxb+jzooetGag6L7zjbCW/3Eh7imqcK62BiWw5wIX/YH3FN7v881SBcFM4S9PkaDtI+vg281IYqQpHxg4ltqmsLlCegI2g78Gy3z8mhmQXpXpXDHm0rKgA6UBqrexqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBU73ku4gGObo6lH3DJ+mqR+lOJMy0ZzPl1+JUqgF50=; b=CeeMGLmTIZY/6vGlW72fHB5tqb5VhOc9jD9yOLXm4SPjqw1qrsA1DrndtYNIAzU33zAi1h88qhZbhHS39VSeR8TigCMgFPrMR/wIfi1d24i0sgK2HEaeaRwtz97wjB8CoCdSh603EVE9zZ8Z6DkRd8Aw7wsuQL3JxrAdr6b2AqA= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB3938.namprd11.prod.outlook.com (2603:10b6:405:79::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Wed, 9 Sep 2020 07:18:26 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::e41f:999f:5492:5175]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::e41f:999f:5492:5175%6]) with mapi id 15.20.3305.026; Wed, 9 Sep 2020 07:18:26 +0000 From: "Yang, Qiming" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure Thread-Index: AQHWhdQYV/Dm07k9h0eEgnTBYNK5E6lf5ueg Date: Wed, 9 Sep 2020 07:18:26 +0000 Message-ID: References: <20200902063802.102428-1-qiming.yang@intel.com> <20200902063802.102428-2-qiming.yang@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4704b756-c8a9-4dc3-787b-08d854908b78 x-ms-traffictypediagnostic: BN6PR11MB3938: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UYj+ntQPG47EusSbPqQv+G0qboiviV/KEuKrHga+695XMflnDwefjvADCkpuw1v+YecTGyQpHQusKkQGnk4s9Txho/DFMlNmQSEhfWqa9TeASGrq1mkDi+u3ghJDDrk1wwEkYYFzf5y++1Hyad+QiB+9jDnHMO8Fti9eDT/rKJX99kCzJ/05RVP0EiYG/tcmo/haR++8bi8G9q7bIBCyE5KC911dGNXyYqwuaZKjcH5+3mY77qa6CuCnavB3+jtwTWetw0V00l3mgbkfBkkf8RsuZB+tPO96GsAQAIvsEH/ZjOkO/DoT5fq/+Z9mm257 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(110136005)(33656002)(7696005)(55016002)(83380400001)(5660300002)(186003)(478600001)(9686003)(52536014)(86362001)(4326008)(2906002)(316002)(26005)(76116006)(66476007)(66946007)(66556008)(71200400001)(53546011)(6506007)(8936002)(107886003)(64756008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7Wbz2YULoX+ISqSC/3xRIu7XKCpGkwo/UNPAFD1qx3s3SlHAN8YmI+ZKLJnGjy0wNE7G9Jw0vhqZTrKPJBIpAwR8n/fbGPExnyvghfY8SSATJPstfMzx7zT/rzJDL+Q2wfgZGtL23IMASanZAiwTRdgo66H1QnEfqacYlZWVLv9LFexiIjsXXEMU0MJrUdfLFJiUSV496lWiysFUr+qx5TmPodXpdk7j7HjoFdYeyvtl8445zf9c8Jond4XCVZtQLGCEVXF/08zwtUbMWi/KqriUDJg8ZfxE1ulmwx+DMuJQwMeRGMBrOzNrImZvbSd0+oq4sm2aKV6OhfKwNivEaf72JKo3XXnO12k9OqUCyPikO8Xht1mKNhj/n712t54sH5BiLDKXcBVL5e8AhdaZOkMen9pq2o+VHTwoduxSjCdAt3tZJ09e/l+n17ZqBjjdAfQ3UacMwwjE08qxc8jQ/2dW68FXhwvzIRbNm+PfnfmGAR6jp7MgUncxPsk7nmmPnZw6s32g8ZVCG/P0cF7Ej/5DHYO5kWn49J+fKfh3sm36zMvlkeGivUEFF2MzB4bXOac7XdRUiz6xefOYWWeo0s2am3RKQRDRM8SdshPUq6lrtU89Fb3yV+QpwfR9DD2DRUGFzAXm5RMUNgDRG2i8YA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4704b756-c8a9-4dc3-787b-08d854908b78 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2020 07:18:26.3637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pJIqtMkvPWHLTe2+TQsTUFOmBlRST5Kg3WwUEOLjah4Vq/4Px+UHGKWZFVW85B1GoPkQCxGCUQozyWMTsuS8QQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3938 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All the format issue will be rechecked in the next version > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, September 8, 2020 19:35 > To: Yang, Qiming ; dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: RE: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor > infrastructure >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Qiming Yang > > Sent: Wednesday, September 2, 2020 2:38 PM > > To: dev@dpdk.org > > Cc: Zhang, Qi Z ; Yang, Qiming > > > > Subject: [dpdk-dev] [PATCH 1/2] net/ice: add dcf port representor > > infrastructure > > > > Defines data structures and code to init/uninit VF representors during > > pci_probe and pci_remove respectively. > > Most of the dev_ops for the VF representor are just stubs for now and > > will be will be filled out in next patch > > > > Signed-off-by: Qiming Yang > > --- > > drivers/net/ice/Makefile | 1 + > > drivers/net/ice/ice_dcf_ethdev.c | 66 +++++- > > drivers/net/ice/ice_dcf_ethdev.h | 11 + > > drivers/net/ice/ice_dcf_vf_representor.c | 245 > > +++++++++++++++++++++++ > > 4 files changed, 321 insertions(+), 2 deletions(-) create mode > > 100644 drivers/net/ice/ice_dcf_vf_representor.c > > > > diff --git a/drivers/net/ice/Makefile b/drivers/net/ice/Makefile index > > 34cd4024b..f9eb34a87 100644 > > --- a/drivers/net/ice/Makefile > > +++ b/drivers/net/ice/Makefile > > @@ -88,6 +88,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D > > ice_generic_flow.c > > > > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf.c > > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf_ethdev.c > > +SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf_vf_representor.c > > SRCS-$(CONFIG_RTE_LIBRTE_ICE_PMD) +=3D ice_dcf_parent.c > > >=20 > <...> >=20 > > + > > +static int > > +ice_dcf_representor_tx_queue_setup(__rte_unused struct rte_eth_dev > *dev, > > + __rte_unused uint16_t rx_queue_id, > Should be tx_queue_id which is more readable? >=20 > > + __rte_unused uint16_t nb_rx_desc, > Should be nb_tx_desc? typo >=20 > > + __rte_unused unsigned int socket_id, > > + __rte_unused const struct rte_eth_txconf *tx_conf) > { > > + return 0; > > +} > > + >=20 > <...> >=20 > > + > > + /* No data-path, but need stub Rx/Tx functions to avoid crash > > + * when testing with the likes of testpmd. > > + */ > > + ethdev->rx_pkt_burst =3D ice_dcf_representor_rx_burst; > > + ethdev->tx_pkt_burst =3D ice_dcf_representor_tx_burst; > > + > > + ethdev->data->dev_flags |=3D RTE_ETH_DEV_REPRESENTOR; > > + ethdev->data->representor_id =3D representor->vf_id; > > + > > + struct rte_ether_addr mac_addr; > Why not move this to the beginning of the function? Format error >=20 > > + > > + memset(&mac_addr, 0, sizeof(mac_addr)); > > + ethdev->data->mac_addrs =3D &mac_addr; > > + > > + return 0; > > +} > > + > > +int > > +ice_dcf_vf_representor_uninit(struct rte_eth_dev *ethdev) { > > + ethdev->data->mac_addrs =3D NULL; > > + > > + return 0; > > +} > > + > > -- > > 2.17.1