From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7208AA04AA; Tue, 8 Sep 2020 09:56:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C51E51B9B7; Tue, 8 Sep 2020 09:56:15 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A16DE2BA8 for ; Tue, 8 Sep 2020 09:56:13 +0200 (CEST) IronPort-SDR: c/0IF5/2IGk1BeG6wafv2Gr+fTHq0bxs7iDgWnPhxSUI7sQJvY21/40IidrC/gZxcpTdcj9Og0 eH/SRFVbJvsg== X-IronPort-AV: E=McAfee;i="6000,8403,9737"; a="137605638" X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="137605638" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2020 00:56:12 -0700 IronPort-SDR: M4IVkhlTKUAMWuapVkNJmOmuykKQNjLkkRDk9GWAXbp0CQL6slLnjE+CCvaAtkl7sEt27OZocy jrZjoNEM5C0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,405,1592895600"; d="scan'208";a="284427845" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 08 Sep 2020 00:56:10 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 8 Sep 2020 00:56:09 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 8 Sep 2020 00:56:09 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 8 Sep 2020 00:56:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FvIpo0VVIJddKnE56kJOB9XbW5WpOjWlPaBnddDKGSfhe6GviYyeqaDOkb0Fhz8M6l4Wo3+t0ZzfQbk6cQB2MUydQDholvlGnId3F3ejSq9DQP1HYgRcVYA9e5OCGcrtuyHz4ujx/abMDcuv3z/t/sgIcthETmdDb5ahDVsioHEFswZTeN5WhO97MARDpK/L8pkT1DNpm3ljx8omdGdpg3KJZ53rpAAJcFMfip/GMwB705OEDSsEgT2qtl0cgvqT0gGA/xAub9eJCRX8VLjUObtn7tKgUrdNHZoMl3lKsLSQIUxKlEKBUd2fQunz+KVmLUJoVFG86gw1c9NQNs8FVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=42FWl4F2seXSvF1ikQ7EduHQwyeAVQYFSeL+k/L0xv8=; b=FN8Umwa7OQcQvgkwCkxFY3pX9j01k6ZeHuWlIsZubJPumQgy3G4/IbHlBs+TnM9LJhBvWPSeTkQgR+30G9AMe7lx49btNDQifRBW21s0j3XU7GASztDuk1KkQuVP9prIltmLiY/Y2PW1U6M7MA2QLfApCgXMMzS7G8RGWWcPzIY7rj8LuXswDnwJQvPcQRk8dHNez63wqCjcLmwslcEcqdGczcgZ95zU+bflF4SVQf+Uhacf5VohyCvfcKu5x2gZxbPlbsQHbv0ktfm/Ssa6mrAnqVM3ETVR9vNvW3LxEL+LAArvutvSAY19z/xE+lJZYM5Uzf3va268dObEGVd8vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=42FWl4F2seXSvF1ikQ7EduHQwyeAVQYFSeL+k/L0xv8=; b=ZZZ25vQNwePLdpJMUGU53KRF//VRwylChnqnupxw2kTRDVlR3n8RLR/9urSArqX/eO49mB3lVqEz3HXHR4nP34xsKITwJXL5kT3nKxpcFJEPsVBryqHRIt9ubd3CG3wYXjKvsQvaNhoMn44obMiN5pObxg2ooWjwGx/4Wwsw7BQ= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN7PR11MB2867.namprd11.prod.outlook.com (2603:10b6:406:b9::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Tue, 8 Sep 2020 07:56:00 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::e41f:999f:5492:5175]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::e41f:999f:5492:5175%6]) with mapi id 15.20.3305.026; Tue, 8 Sep 2020 07:56:00 +0000 From: "Yang, Qiming" To: "Jiang, JunyuX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Sun, GuinanX" Thread-Topic: [PATCH v2 5/5] net/ice: remove devargs flow-mark-support Thread-Index: AQHWhPkHH2Zy9qHeiEWSZOn/Y8csa6leYI7A Date: Tue, 8 Sep 2020 07:55:59 +0000 Message-ID: References: <20200826075501.50052-1-guinanx.sun@intel.com> <20200907091711.5980-1-junyux.jiang@intel.com> <20200907091711.5980-6-junyux.jiang@intel.com> In-Reply-To: <20200907091711.5980-6-junyux.jiang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6328b0a3-e2ce-40dd-bd92-08d853cca043 x-ms-traffictypediagnostic: BN7PR11MB2867: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:813; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qjxNCOnfrn5zcSUcsa4yqwfddWuf6/uin+CyhBKLFWSo3TLSFpW/nRyVAGoqdi7N40DlhIJx0ya3ejOd4/nHwdHEV3xyvzkTNnmtce2FfaJbgfjn1o+AAu8n2VoKOeAyTWhgV5BGPD25B6Rj4UKfysG/UsbzS4gBQLjQQwH1KR4ttFPP1YkYj45X0NjKdZHr7f2AMNfM3EG0a+nTdFpNGsfpES5QaSZhCogzSArNeSHo59vZ8bz48TFvewb2WhcPJlVpJ0/iNQbbl0nlawgO+80fIEGnRftd1GTRxIxxPT5VZNe4Nm7ZQfRkL4vSx7sCnnURRiK8cA9DT81wkjXyVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(346002)(136003)(396003)(376002)(6506007)(53546011)(55016002)(52536014)(26005)(186003)(7696005)(71200400001)(8676002)(83380400001)(8936002)(5660300002)(4326008)(9686003)(110136005)(54906003)(107886003)(316002)(64756008)(66556008)(66476007)(66446008)(66946007)(2906002)(86362001)(76116006)(478600001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Bnrep3CduPZMaJ2WwOXLStmFVJZoDa2Dd/JAMjpvWWsqBk3GzpAiDmdukFTWSChEoZLuTYcKNvlx7E1fdVSon+OA2+0b4iIbuAbFevkNzRxg8sLVe4z5NUJLRqtcg2Y0cqTPkwdOtKs7Cjsyrq8n4JG7/bBcWbVIS3LfgHCGnAtLNxMvxzbo0Bhvi+e9U6g66nMoj8WkI8SGegmt6VfdKZ1g8vJE300afoZZdoYS4q+3eyDk1RrRa3PvxGk1ADFpcIvaLazuwGKBZcD4lR1xh9rEsYRiF81yeuKMo1DxYeLGpFQQ4CtXTOQCQxHpVlEzbbow7VstflG/oieNN36ZL+YCXiJGePHLgX6nEAiiDKuvtS4v3v/5bxtb3zeQDMQ5uTBCs9SB5DbmYk1YRPcFVMsa85ShLwLeHypV8s/a65qkQz6PG9RwZ02x5edtMio+VaMvpzSgT4wWRa0FywY3afMIBubel2pMoFwzeD5yLjNjUcUB+k1xKlojOKdITSZUO6UGEvLrjayTAsJmLG1gRa8VS5e7/4utfm+EB8h3Gc4guLd3lUPPzZsnFuvUtPtngwOolivb8yq4EtXX+ifZ0HZAdHs1aOYNl9YERog6Ra2bMrkQ400JzjG/PLjT7aSbY4a1XhMYhAitYWkCNlyhEA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6328b0a3-e2ce-40dd-bd92-08d853cca043 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 07:55:59.7414 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6g6nvATwu5vV/cMtxT3XGecPyW3ZSAt8KAz8BoV55KiKKoj65JdUQD68L6EFwyqkR7GCJttz9hBpwyiB/fRB4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2867 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/ice: remove devargs flow-mark-support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jiang, JunyuX > Sent: Monday, September 7, 2020 17:17 > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Sun, GuinanX > Subject: [PATCH v2 5/5] net/ice: remove devargs flow-mark-support >=20 > From: Guinan Sun >=20 > Remove devargs "flow-mark-support". Please rework the commit log. Mention the reason why you need to delete it = and what't the new way to configure flow mark? >=20 > Signed-off-by: Guinan Sun > --- > doc/guides/nics/ice.rst | 12 ------------ > drivers/net/ice/ice_ethdev.c | 10 +--------- > drivers/net/ice/ice_ethdev.h | 1 - > drivers/net/ice/ice_rxtx_vec_common.h | 6 ------ > 4 files changed, 1 insertion(+), 28 deletions(-) >=20 > diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index > 9a9f4a6bb..64b1b13a6 100644 > --- a/doc/guides/nics/ice.rst > +++ b/doc/guides/nics/ice.rst > @@ -75,18 +75,6 @@ Runtime Config Options >=20 > -w 80:00.0,pipeline-mode-support=3D1 >=20 > -- ``Flow Mark Support`` (default ``0``) > - > - This is a hint to the driver to select the data path that supports flo= w mark > extraction > - by default. > - NOTE: This is an experimental devarg, it will be removed when any of > below conditions > - is ready. > - 1) all data paths support flow mark (currently vPMD does not) > - 2) a new offload like RTE_DEV_RX_OFFLOAD_FLOW_MARK be introduced > as a standard way to hint. > - Example:: > - > - -w 80:00.0,flow-mark-support=3D1 > - > - ``Protocol extraction for per queue`` >=20 > Configure the RX queues to do protocol extraction into mbuf for protoc= ol > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 8d435e889..cb6882f70 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -23,13 +23,11 @@ > /* devargs */ > #define ICE_SAFE_MODE_SUPPORT_ARG "safe-mode-support" > #define ICE_PIPELINE_MODE_SUPPORT_ARG "pipeline-mode-support" > -#define ICE_FLOW_MARK_SUPPORT_ARG "flow-mark-support" > #define ICE_PROTO_XTR_ARG "proto_xtr" >=20 > static const char * const ice_valid_args[] =3D { > ICE_SAFE_MODE_SUPPORT_ARG, > ICE_PIPELINE_MODE_SUPPORT_ARG, > - ICE_FLOW_MARK_SUPPORT_ARG, > ICE_PROTO_XTR_ARG, > NULL > }; > @@ -1985,11 +1983,6 @@ static int ice_parse_devargs(struct rte_eth_dev > *dev) > if (ret) > goto bail; >=20 > - ret =3D rte_kvargs_process(kvlist, ICE_FLOW_MARK_SUPPORT_ARG, > - &parse_bool, &ad- > >devargs.flow_mark_support); > - if (ret) > - goto bail; > - > bail: > rte_kvargs_free(kvlist); > return ret; > @@ -5131,8 +5124,7 @@ RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* > igb_uio | uio_pci_generic | vfio-pci"); > RTE_PMD_REGISTER_PARAM_STRING(net_ice, > ICE_PROTO_XTR_ARG > "=3D[queue:]" > ICE_SAFE_MODE_SUPPORT_ARG "=3D<0|1>" > - ICE_PIPELINE_MODE_SUPPORT_ARG "=3D<0|1>" > - ICE_FLOW_MARK_SUPPORT_ARG "=3D<0|1>"); > + ICE_PIPELINE_MODE_SUPPORT_ARG "=3D<0|1>"); >=20 > RTE_LOG_REGISTER(ice_logtype_init, pmd.net.ice.init, NOTICE); > RTE_LOG_REGISTER(ice_logtype_driver, pmd.net.ice.driver, NOTICE); diff -- > git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index > df0d65d8d..d441350e0 100644 > --- a/drivers/net/ice/ice_ethdev.h > +++ b/drivers/net/ice/ice_ethdev.h > @@ -444,7 +444,6 @@ struct ice_devargs { > int safe_mode_support; > uint8_t proto_xtr_dflt; > int pipe_mode_support; > - int flow_mark_support; > uint8_t proto_xtr[ICE_MAX_QUEUE_NUM]; > }; >=20 > diff --git a/drivers/net/ice/ice_rxtx_vec_common.h > b/drivers/net/ice/ice_rxtx_vec_common.h > index 46e3be98a..e2019c8d6 100644 > --- a/drivers/net/ice/ice_rxtx_vec_common.h > +++ b/drivers/net/ice/ice_rxtx_vec_common.h > @@ -270,12 +270,6 @@ ice_rx_vec_dev_check_default(struct rte_eth_dev > *dev) { > int i; > struct ice_rx_queue *rxq; > - struct ice_adapter *ad =3D > - ICE_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > - > - /* vPMD does not support flow mark. */ > - if (ad->devargs.flow_mark_support) > - return -1; >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > rxq =3D dev->data->rx_queues[i]; > -- > 2.17.1