From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>, "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix vf reset hw error handling
Date: Thu, 3 Sep 2020 02:24:03 +0000 [thread overview]
Message-ID: <BN6PR11MB0017580C29D79F6B85DA2807E52C0@BN6PR11MB0017.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200902004425.33423-1-stevex.yang@intel.com>
Hi,
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: 2020年9月2日 8:44
> To: dev@dpdk.org
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH] net/ixgbe: fix vf reset hw error handling
>
> The PF control message will interrupt the assigning MAC address for VF when
> PF physical link down, and the VF reset operation returns the
> IXGBE_ERR_INVALID_MAC_ADDR. In this case, reuses the MAC address from
> eth_ixgbevf_dev_init() directly, no need care of PF assignment.
Better do not use function name.
Reuse the MAC address when device initialization instead of waiting PF reassign.
>
> Fixes: f69166c9a3c9 ("net/ixgbe: fix reset error handling")
>
> Signed-off-by: SteveX Yang <stevex.yang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index fd0cb9b0e..c2fa59c73 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5326,10 +5326,17 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)
> ixgbe_dev_wait_setup_link_complete(dev, 0);
>
> err = hw->mac.ops.reset_hw(hw);
> - if (err) {
> +
> + /*
> + * The VF reset operation returns the
> IXGBE_ERR_INVALID_MAC_ADDR when
> + * the underlying PF driver has not assigned a MAC address to the VF.
> + * In this case, reuses the MAC address from eth_ixgbevf_dev_init().
> + */
> + if (err != IXGBE_SUCCESS && err != IXGBE_ERR_INVALID_MAC_ADDR)
Is there any other cases will also caused IXGBE_ERR_INVALID_MAC_ADDR?
> {
> PMD_INIT_LOG(ERR, "Unable to reset vf hardware (%d)", err);
> return err;
> }
> +
> hw->mac.get_link_status = true;
>
> /* negotiate mailbox API version to use with the PF. */
> --
> 2.17.1
next prev parent reply other threads:[~2020-09-03 2:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 0:44 SteveX Yang
2020-09-03 2:24 ` Yang, Qiming [this message]
2020-09-08 3:17 ` [dpdk-dev] [PATCH v2] " SteveX Yang
2020-09-11 6:24 ` Guo, Jia
2020-09-15 6:46 ` [dpdk-dev] [PATCH v3] " SteveX Yang
2020-09-23 6:16 ` Guo, Jia
2020-09-23 11:46 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB0017580C29D79F6B85DA2807E52C0@BN6PR11MB0017.namprd11.prod.outlook.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=stevex.yang@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).