From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C737A0350; Tue, 30 Jun 2020 12:27:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B3CE1BE8E; Tue, 30 Jun 2020 12:27:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CE6DA1B9BF for ; Tue, 30 Jun 2020 12:27:36 +0200 (CEST) IronPort-SDR: t5WsN/k6C+MZhoD42TCG8zlrL38kVvkKdlm+igmRtcpUPkdOHRhrXwxu5la+Lf5DnV43zWCeuO dlLsAT2j2xaQ== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="133649305" X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="133649305" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 03:27:35 -0700 IronPort-SDR: SAluD31a3jyV7vg9njbPF0GFnaqOSsLABDq6DX9n6X17lUXlbtofHulP8v+yWbJRUoxlH/L40k ibwBK560r2VA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="320889452" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jun 2020 03:27:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 03:27:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 30 Jun 2020 03:27:34 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 30 Jun 2020 03:27:34 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 03:27:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UBY51AfiWi7VHgs5OuJa+1x7pLxBRHPpqmFjlvDpUeACoFsMFFuvAcAspPlCpfeam7hkjipVQjXkcYBI+DsJdgCjWjw6WOC8fMcvFG6z0EqPJZV9TjTmVjNi6IDbKP0icxltzP+rpRuWxdQ64TDo3hBn5MXFv5qpFE9XB7yVkcvSiTYwcGjF25uDiME3ZP1Sx2glHkHKvgasfyM/JL5o2rk+6S0fIzgMtJivkAUZOi2BNEReiYB6019m4SLnm/I0JF51pDIIc/GL3fCeUMp9a0WnkzReM0SD7IKLJ/JTMFDFWqs6x6R+emej1HgS1GNnoqzU7WVfruk0Rx3t2ZXRIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QSXihBivsrtH/E8Ly7WPf97hMYHqcGqm1WRBqgOe7zI=; b=kzAeX79YlgQzpLNoShmAoRwTUh/Aa9llETfgatp9/4Jq5cd3ABVGdtDjbMcVhDdfGnLrguC8mrkgaXUwdXPafXEyxoMjhT8vDY7iUopJI3VWqxWl+wpKP2nbIEx79IbGga3bft1YBBIL+1BhC9R3d7G1dxXLeV7QwKDzvBJRkKXXULqyasyV9oWsew5cltz/+Mipc1qRCg7mwCe23R1GMugYHocRp9va7SDYdGLEShouJHMlcGfabWXgovN6kW2eKslC9wddAZnHOKJJ7ek6NzfzHbBzpPq8KXqPp6ucaNIMWa98TlTlCfv7qqbUQaMj7iMkxCtpik1YGKqVaB2LvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QSXihBivsrtH/E8Ly7WPf97hMYHqcGqm1WRBqgOe7zI=; b=vcOPcBAi431wv6qoRujJc749bXOXLzz6FflFy2Vh1jLcUO72ql7RtbdY06fej+NzUcjQ8VrfmyvXlrsQOip57Z5PNhJ5zDnCzNQ+bgm++Nmba5OcCSb020rpIoJb89wqBa7HnPA4FmxzjhSHMR+nOQgAND7cwRAkEV1kgfLGFG8= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB3857.namprd11.prod.outlook.com (2603:10b6:405:79::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Tue, 30 Jun 2020 10:27:29 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3131.028; Tue, 30 Jun 2020 10:27:29 +0000 From: "Yang, Qiming" To: "Di, ChenxuX" , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [PATCH v2 4/5] net/i40e: enable flow query RSS Thread-Index: AQHWQr4C1d9UGcuXjkqStOkL1L9TF6jxDFpw Date: Tue, 30 Jun 2020 10:27:28 +0000 Message-ID: References: <20200611060142.75465-1-chenxux.di@intel.com> <20200615021858.13985-1-chenxux.di@intel.com> <20200615021858.13985-5-chenxux.di@intel.com> In-Reply-To: <20200615021858.13985-5-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 420ce10f-8a33-4d9a-766e-08d81ce03114 x-ms-traffictypediagnostic: BN6PR11MB3857: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1148; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Swr+7/62kByt0yyukxv1DqLM/O51/5gpCXU4ur84zV4PwR6ialKnT+IIc4GDSjyfcnGrxWUBxc1E60AOcEyUgEjbOdP0ieKLGzbR8rIGvUDtPdaTQcx6eCD54wTzro/jSMt/2MavKSKiYJ0lkcVeWsGhmwn5NLXehjJb8GpRLwrcNIl51r4uTwX812Rsx9jI6qC5DDvqp8SzuVh0zYSDh2S5l3iN6Odz6kYEMdBYfTQgCK03jfaE8XkxpjVNze0z0ZHILGxvBNvP59xT6isy+gyeQtM+kpCZChT5BNJdMDGSfd0WvHjHB+01AV2tNs0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(66476007)(107886003)(86362001)(2906002)(83380400001)(71200400001)(33656002)(7696005)(9686003)(52536014)(53546011)(55016002)(6506007)(4326008)(8936002)(478600001)(110136005)(66946007)(66446008)(186003)(5660300002)(64756008)(66556008)(26005)(8676002)(76116006)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 9+08c2OPrLoRncFzpnLs+SpH6iIyeENPQOomIuoNJ0gSeHPnGkIKwPkR9ZRIYce+RaDplh1wcbDSuCLjyuBo0EPASLQWEaC4Dp48vrOe+9SX+e1A8MIAc9PMaHftdlaTKf0h4R4yWleKaw/HqI2tc0APAKOgxuJ2Fwo/i0fkBGHA4n+CsDasZKO/LgVyKR0XgqC6kpfh1/rjYMMH9wP/tIujeTuYV7oewKiGi1SOCeV2DWZAuN04jjpm1lxtm3W2yON2auqjEQ2YauODNFD1kyy6tc6FQtdepveYR5pWnFm/tm3yvH5W7JMQ1nhsL/82vJIgm8ScUSvvUtOnQDmTDZN42t/o1qKpi8OSQH/VG2NYS2VKFyqg3GvSzZKHdv9cUxsztYPTfqIovEiCY664BIxMT9N8QNy36rPxH4wYs5T7IrLJ6MAa6ypUQS3dFI+5xvMiJSmCtAPMaWOiuo9sdKDdYn2h/MT9jUBH0Vm/pcNdaERqmG5PqDWXYnNWwAzP Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 420ce10f-8a33-4d9a-766e-08d81ce03114 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 10:27:28.9814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZnhjH+9gaSCZeB0M3Xk8H8LCJRsScnisjgHEnVQKlCHf78whVSGkDPG1x4rNHvrxIBHuHFAbm/MQfx0a4OAwOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3857 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/i40e: enable flow query RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Di, ChenxuX > Sent: Monday, June 15, 2020 10:19 > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Di, ChenxuX > Subject: [PATCH v2 4/5] net/i40e: enable flow query RSS >=20 > This patch enables flow query function to get the configuration ofthe > specified rule. >=20 > Signed-off-by: Chenxu Di > --- > drivers/net/i40e/i40e_flow.c | 51 > ++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index 8f8df6fae..b070802bd 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -43,6 +43,11 @@ static int i40e_flow_destroy(struct rte_eth_dev *dev, > struct rte_flow_error *error); > static int i40e_flow_flush(struct rte_eth_dev *dev, > struct rte_flow_error *error); > +static int i40e_flow_query(struct rte_eth_dev *dev, > + struct rte_flow *flow, > + const struct rte_flow_action *actions, > + void *data, > + struct rte_flow_error *error); > static int > i40e_flow_parse_ethertype_pattern(struct rte_eth_dev *dev, > const struct rte_flow_item *pattern, @@ - > 129,6 +134,7 @@ const struct rte_flow_ops i40e_flow_ops =3D { > .create =3D i40e_flow_create, > .destroy =3D i40e_flow_destroy, > .flush =3D i40e_flow_flush, > + .query =3D i40e_flow_query, > }; >=20 > static union i40e_filter_t cons_filter; @@ -5462,3 +5468,48 @@ > i40e_flow_flush_rss_filter(struct rte_eth_dev *dev) >=20 > return ret; > } > + > +static int > +i40e_flow_query(struct rte_eth_dev *dev __rte_unused, > + struct rte_flow *flow, > + const struct rte_flow_action *actions, > + void *data, > + struct rte_flow_error *error) > +{ > + struct i40e_rss_filter *rss_rule =3D (struct i40e_rss_filter *)flow->ru= le; > + enum rte_filter_type filter_type =3D flow->filter_type; > + struct rte_flow_action_rss *rss_conf =3D data; > + > + if (!rss_rule) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_HANDLE, > + NULL, "Invalid rule"); > + return -rte_errno; > + } > + > + for (; actions->type !=3D RTE_FLOW_ACTION_TYPE_END; actions++) { > + switch (actions->type) { > + case RTE_FLOW_ACTION_TYPE_VOID: > + break; > + case RTE_FLOW_ACTION_TYPE_RSS: > + if (filter_type !=3D RTE_ETH_FILTER_HASH) { > + rte_flow_error_set(error, ENOTSUP, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + actions, > + "action not supported"); > + return -rte_errno; > + } > + rte_memcpy(rss_conf, > + &rss_rule->rss_filter_info.conf, > + sizeof(struct rte_flow_action_rss)); Don't understand the behavior, what's action means? What's the things this = commend query? > + break; > + default: > + return rte_flow_error_set(error, ENOTSUP, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + actions, > + "action not supported"); > + } > + } > + > + return 0; > +} > -- > 2.17.1