From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32AB7A04AA; Fri, 7 Aug 2020 03:45:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 682022BF1; Fri, 7 Aug 2020 03:45:37 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DC0882B87; Fri, 7 Aug 2020 03:45:34 +0200 (CEST) IronPort-SDR: PRui3zYLhpgkiojrvBcCU0bjZeHXsZ1k+7ls6CFhNikryYSiV8MDwTstZZqwfiU2NeTOAQf1gr UT5WLCWbMwBg== X-IronPort-AV: E=McAfee;i="6000,8403,9705"; a="237827788" X-IronPort-AV: E=Sophos;i="5.75,443,1589266800"; d="scan'208";a="237827788" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2020 18:45:33 -0700 IronPort-SDR: K7uVxrfyoGNyvyn8B0URBJa5FdGmlL/mCbUVceXYSEbBBgbVlbdDPkbGdrzN3GJo/Bs3wMs/y5 o18y/578M+wg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,443,1589266800"; d="scan'208";a="275248451" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 06 Aug 2020 18:45:33 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 6 Aug 2020 18:45:33 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 6 Aug 2020 18:45:33 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Aug 2020 18:45:32 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 6 Aug 2020 18:45:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IZmnR+L5zr6FSHzD41muYLf8aFJDxBL+hc33b15yxL7lfpL9wumI/E0jI/7w2ia7MNGF12VexfC0Nyeie/q6a+WO0hIEMGZ4MrbYWHv9MPvOYiE2yLm+ez6o30IhyaGl6mqclgpMPibFDafIRYgdLj2YSjzfpobZtJNSRQriPjqLxKlF0LlMJ5s/qP10hj8mwu1mA4pQrRFFmB4DlGy4rzJMti4Jgu+EvG9HD1mxSPelYP6MrGbjhG+wYbW5w7VxGXFlMkvqoib/ITIkwCDgQGw7sifjVkrFYmBVCnsp3MNzm1LPaWxc+3XUrEtbnTBLTZxlnwZjL+j/llwksm+f+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pf2+iqG/Kqh1KeVNkouV3XCIjwmRYwv8M/BtwC1xEsY=; b=hlctJtcbQEDf9XSnoT9q+EHIPdKeXE+L233H+Pa8oNZIq30AeIPNmuqW1mRfFAuMOB72UvZb5aISyiiHrf3BxALFX7H1on/cXrgbPLaLuu5Q9KEQgaxow/c+M4Hx8kQUUsxriuPKnjGBeyuOs/ctuXrSu8ZQ8IugcNQQE69GSprTXX5c/mNBbmEp6BBJr+Ze30xX/6//b6MMgnYafXcwLce9/R6AgGmxt0pFOEClFwMcc0yDKxGSIuYOolIYHpiiAgbvVwUsd7E8pTZ9mcbCiYIOUKJTEtQnkM7Du4UWIPQ2Lj7TVBsvq31NUF9ishJGVu+i7pGwh7qabZbf2L8B2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pf2+iqG/Kqh1KeVNkouV3XCIjwmRYwv8M/BtwC1xEsY=; b=RYNwkpP1E/6C88qykOfqkOSgZlwRgS6TUyjqGGfmeBuem+daT79o0Z6OLJwo/ooBpD25/O6giWg7vItk6h9cmxBK7+yqg8GEPJjbbjGYpEiJHmWBubg6q03Xgxk80jnyJdfZ0uNuT6DGjYfZVd9WHbSUoWHxnfnRY6ZGKpHmhBg= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN8PR11MB3713.namprd11.prod.outlook.com (2603:10b6:408:8e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15; Fri, 7 Aug 2020 01:45:30 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::6c3f:f9b6:80fd:5f29]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::6c3f:f9b6:80fd:5f29%4]) with mapi id 15.20.3261.018; Fri, 7 Aug 2020 01:45:30 +0000 From: "Yang, Qiming" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/ice: fix incorrect firmware version Thread-Index: AQHWa95KRt0bSRF1zU6AXxw9tzGBfqkr4Pvg Date: Fri, 7 Aug 2020 01:45:30 +0000 Message-ID: References: <20200806082519.71727-1-shougangx.wang@intel.com> <20200806102824.2561-1-shougangx.wang@intel.com> In-Reply-To: <20200806102824.2561-1-shougangx.wang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f59a13f-7536-42a9-fd37-08d83a73912b x-ms-traffictypediagnostic: BN8PR11MB3713: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hokTgSFYK349CNQHoXpitd//wUVeI9tGUHTGjZKeHRQApvhjNKX6iQOlD7fZesfWE4kw7NKuCp77xmcal4fZDWfDwq+0pLLKmZe76WfFN6mOyTBxig7DSwtjjkpIeG0U4B8Y+7hJLmD90xIF1BkBeomu9gYSJUAUJTjucq1ykilVyBdrrtxBCeNaHWbTsn96yfELKLTrgKU61XqDtvDhEVERCYYqEd5J+IuHGwImLgbFC+wdZfA43PJNHJdRmKXGpRevDj0/hKZ9Ib97GTUIvH1jBKBksgh5NypXzmoJEDffl6VGH/CuO4a+NZM9cO+x x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(450100002)(86362001)(5660300002)(26005)(186003)(6506007)(110136005)(9686003)(316002)(478600001)(54906003)(55016002)(7696005)(2906002)(8676002)(71200400001)(52536014)(8936002)(66446008)(64756008)(66556008)(66476007)(66946007)(4326008)(76116006)(33656002)(53546011)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 64T5ARlBNNfflIGl1kN42iZjhezxaXDVhDdz3zo9lTU+7D4toDEpqJpnkejob0kLXkjLaNfrDtbYTcnsBA8koyGYouQkOlUc4rE4Uaz0gs3civRWSwxC7kslnGmm/EhhjxmBrLjLirzU2CRntXcMRyoTdeJxyT/oRDpUa7mTM3EV6wKyk1ZzS6B9f7r92gTMCgvCGFqL4My4+oN8MwmrR4W0K9qgKm+GlT0pmjfw2bdl6GuTcT38ihTp/g5ivTuihaQht35z97ApKSXoa9F/fSFw++S+waPrj5jj4Sq6iv/QtXWsQWcBGSBAglzRju0qFLiqXJcpYpE45YGwMTRZ4oh1zgdAmKzL72T/oQ9gf5OAnwjA6B8ZpIcs6bZNlHvN1tV9a3OY8c7uhaanZeEv51ntSYo/xGmDNBBtfRRi4Aw3GAm+EWAxby5YpsSLnwh8ky+ikWHuwmfKcBqTu34wX5Bagcuq3dRXMiGfjyJWvoKyLZeKpP1Z8e3oMxkyN7FCqN5G3DtsLzb6+JycARfW9kyt0AIiaZc2tWrokxDh+qgj3P38NeHUs8hznrXcHDh6hcwYcEOC6hgaTVwr2jbykWwbAzzGnQEozToIZRhToS8AGxuN6geV2zu3i+HrGYPYgKBzZIdmp/2Yd3BYuah+dQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f59a13f-7536-42a9-fd37-08d83a73912b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2020 01:45:30.1635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PiEQVaMpz2bWmTXI2AZnvsnZQLwqB4nRlndr2UC+p71ctshODwxcNtwxruh4YmSwCJtwbsIAEvv2538Kr4XNCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3713 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix incorrect firmware version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, ShougangX > Sent: Thursday, August 6, 2020 18:28 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, ShougangX ; > stable@dpdk.org > Subject: [PATCH v2] net/ice: fix incorrect firmware version >=20 > Kernel driver shows firmware version as hex but ice PMD shows as decimal. > This patch fixes the issue to make consistent with kernel driver. >=20 > Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shougang Wang > --- > v2: > corrected fixes version > --- > drivers/net/ice/ice_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 8d435e889..88b8428b9 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char > *fw_version, size_t fw_size) > build =3D hw->nvm.orom.build; >=20 > ret =3D snprintf(fw_version, fw_size, > - "%d.%d 0x%08x %d.%d.%d", > + "%x.%02x 0x%08x %d.%d.%d", > hw->nvm.major_ver, > hw->nvm.minor_ver, > hw->nvm.eetrack, > -- > 2.17.1 Acked-by: Qiming Yang