From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix out of memory bound for MAC addresses
Date: Thu, 18 Mar 2021 02:07:27 +0000 [thread overview]
Message-ID: <BN6PR11MB001784F17E5DC31AA0D344A9E5699@BN6PR11MB0017.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210317060219.2162370-1-qi.z.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Wednesday, March 17, 2021 14:02
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice/base: fix out of memory bound for MAC addresses
>
> Not enough memory be allocated for dev->data->mac_address which cause
> out of bound memory access when iterate all mac addresses by
> dev_info.max_mac_addrs.
>
> Fixes: f9cf4f864150 ("net/ice: support device initialization")
> Cc: stable@dpdk.org
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 8999d441ac..22104250fa 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -809,7 +809,7 @@ ice_init_mac_address(struct rte_eth_dev *dev)
> (struct rte_ether_addr *)hw->port_info[0].mac.perm_addr);
>
> dev->data->mac_addrs =
> - rte_zmalloc(NULL, sizeof(struct rte_ether_addr), 0);
> + rte_zmalloc(NULL, sizeof(struct rte_ether_addr) *
> +ICE_NUM_MACADDR_MAX, 0);
> if (!dev->data->mac_addrs) {
> PMD_INIT_LOG(ERR,
> "Failed to allocate memory to store mac address");
> --
> 2.26.2
Acked-by: Qiming Yang <qiming.yang@intel.com>
next prev parent reply other threads:[~2021-03-18 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 6:02 Qi Zhang
2021-03-18 2:07 ` Yang, Qiming [this message]
2021-03-24 13:03 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB001784F17E5DC31AA0D344A9E5699@BN6PR11MB0017.namprd11.prod.outlook.com \
--to=qiming.yang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).