From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84C82A0350; Tue, 30 Jun 2020 12:25:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E6BC91BE8E; Tue, 30 Jun 2020 12:25:00 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 540851B9BF for ; Tue, 30 Jun 2020 12:24:59 +0200 (CEST) IronPort-SDR: BbI6Yamd5p104mr+99XveK7v0p+4q/JR2qwrufK/ovY8BtxNnLsdnDapleO4cz0h/jc2GHqhO2 Ao5TwdOt6xfA== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="211261104" X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="211261104" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2020 03:24:57 -0700 IronPort-SDR: gQ3FwC2JyqqgZttyvJoJFmj4ZJfseZ4k7hccYj0Q/AEMPLmn1jyyBubF6n1dcfZqh2eotkZwWA mAjg0eytoCZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,297,1589266800"; d="scan'208";a="454558921" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga005.jf.intel.com with ESMTP; 30 Jun 2020 03:24:57 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 03:24:56 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX121.amr.corp.intel.com (10.22.225.226) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 03:24:56 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jun 2020 03:24:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=auQP8hQxqV1IlMJMR/sdVhiOm4OqbXPM7MxkLdB0zvUGHUqQMEMo6KXnKecwePpKJuG327CHI1+Qr2LWapjlkXTHtB82MG2529eO9CUZJeaXoQwJKSv8f0pAT6eyHJZNBhPpLD1F262QXRQJRnm1PsFpSsU3pFRLGhIKhKZEJ5hGBlEkUuPi/glXG9SJIbe1hSBxx9NKavC3Nco/ORTVoOJMrBMSHhIiCluNozZUgB2i9ecvMw3qDtR3uFCdFUp4F79rF8qzck9xbhOddA9voBkiITgRZ25xTVDdZzi8HCVXgTlnqkAOm9qujZYu3xlvzqWbYfc/DldRzhr+Mc/u9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aKDk6iR2PxIU2FSlIoLK0tE/bOXWWLgw1hspanDndlA=; b=TpanycdCxYauN3cfhYpYpEWrKRsZFDNTIh1/JUAT/F4VQPqknXXARJiGU3hjnsJQAs7WRjCASjCYMmnAVQnEEvZKy2Xo7RasZv21qHCPZnJ1ZegLxbhH0ZeDkXaZY61m2+nWIg84SdHM9L7jtiAEgKs/Y1jiwiW9jZXlFdDCihvUjjz40VZjdGHvK6Hu9FsPfSmgxkxzidUOemzg3Tr7E8o6uTqGndIuJaydYulOy09TKFtaCN/9AXhoFIY3bkHTT9teyj0X6WB1lllCU3XDYHWQal75NPclBMU1O6xBEN2QsP33N54N+057/7Y+FaZ/pL8gqbLRCREkNH79LSTyiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aKDk6iR2PxIU2FSlIoLK0tE/bOXWWLgw1hspanDndlA=; b=YTvYAb44mSVu9yydOEpx2/hubY67JaJRB1QHLskcLkz2oG9z89DoJpZV4Oo/AIQVhexd3r9vp3dUTbwrkx72UtIZeTfLu9yeo60rbZBvQ1ADHg+26K89O0Bas2Bhpf6gLbVqVoPwUinkv6X2XoYU859nTE38zEDGHxYwMmm2HpA= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB3857.namprd11.prod.outlook.com (2603:10b6:405:79::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Tue, 30 Jun 2020 10:24:54 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3131.028; Tue, 30 Jun 2020 10:24:54 +0000 From: "Yang, Qiming" To: "Di, ChenxuX" , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [PATCH v2 1/5] net/i40e: add private APIs Thread-Index: AQHWQr378mNrWN1OO0m0SDp7LhlL96jxC08w Date: Tue, 30 Jun 2020 10:24:54 +0000 Message-ID: References: <20200611060142.75465-1-chenxux.di@intel.com> <20200615021858.13985-1-chenxux.di@intel.com> <20200615021858.13985-2-chenxux.di@intel.com> In-Reply-To: <20200615021858.13985-2-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34bee7da-7f09-4514-cc9b-08d81cdfd4b2 x-ms-traffictypediagnostic: BN6PR11MB3857: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0450A714CB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ObbCFnl+GIk5+MxaLZhf6CKo4F1pjYCwYam4CO75aXfOvovK8x4PHk8DA5DJkzwoBHgxu+Tmji92PqMplyiSPnaSq3p5aObn9SNMVHgiyvHjNq1opGUGnHbFTkPOJWJUskqYy3FwIfqJIAo+TNrNORGqcrp8la/y1RfcQKRkUJKsxBk4shpVfs/NdaIZAlOzM0jgAXCvbNuEU6eA7Qh6wSpvo1F48936mtFEZS7ottEhFTPDz64WoGTCYnQ31J/p4haJJxtklopTa1//L2MljvsGt854sQA5nr6luFoUVucYT9Hm4db60pcc2MIeGZkR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(66476007)(107886003)(86362001)(2906002)(83380400001)(71200400001)(33656002)(7696005)(9686003)(52536014)(53546011)(55016002)(6506007)(4326008)(8936002)(478600001)(110136005)(66946007)(66446008)(186003)(5660300002)(64756008)(66556008)(26005)(8676002)(76116006)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: xhKZJH0kNcZT5z5ide6tO3ybkY3GYuEMDP5826/rSy2PSWtkgdc0Vs/G6iKNDxcYwscQY5+5eN+KfQupl/SMd0iVsCgMSEBpjR3gVPJDEKsP1yVG8EbJ7JOGAqVU2vN5Iw+XhTddOos5OVHVwW2j0IkF7i+beHNCwQisRkpfR3BKG1ManvLLpwIpI5wSvzm/AzO+mZU9nJ3JhQAorZbRiKKq/ohXYW2+hS6XlFgHnhy6zPXiTAbIsR3HREnS9j2UNvzxf1Rv9qXrKjafDJYoImujrtfAeL/PKSQR3SSr3AIO9gDHTyUxZc2W2kC/5jvT2mzOCs5BfPASD5c8pnwR3xDRdN5SX2SRghTUySQvUtfcNgsZDgL7pkZYLIWtECUVGiYZO55ZvRzER5s79gmYv6ReiqpJk+ydkJ4o8lcYFSQEF74LZUiCI+POIRi/Ezp1DM0AWdqMbFL+WGDD8/5sOfIRHOWIIRNIDjhwQUMh0T4wCSD+EpcTYyl3qik+Puh+ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34bee7da-7f09-4514-cc9b-08d81cdfd4b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2020 10:24:54.3588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t3LZpjeQNqy8gABdx30aNLgG/eaXSK6cR6UzuUF+Q4fYtBCrsFy3YEyNshZYGdRqLgHgfqOy7H7/9X49Rjdbow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3857 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: add private APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Di, ChenxuX > Sent: Monday, June 15, 2020 10:19 > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Di, ChenxuX > Subject: [PATCH v2 1/5] net/i40e: add private APIs >=20 > The legacy filter API will be superseded by rte_flow. > There are also several small features which can not be implemented in > rte_flow. This patch re-implemented these features as private API. > Three APIs are added: > rte_pmd_i40e_get_fdir_info. > rte_pmd_i40e_get_fdir_stats. > rte_pmd_i40e_set_gre_key_len. >=20 > Signed-off-by: Chenxu Di > --- > doc/guides/rel_notes/release_20_08.rst | 14 +++++++ > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev.h | 5 +++ > drivers/net/i40e/i40e_fdir.c | 4 +- > drivers/net/i40e/rte_pmd_i40e.c | 51 +++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e.h | 49 ++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e_version.map | 3 ++ > 7 files changed, 125 insertions(+), 3 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_20_08.rst > b/doc/guides/rel_notes/release_20_08.rst > index dee4ccbb5..550ad33aa 100644 > --- a/doc/guides/rel_notes/release_20_08.rst > +++ b/doc/guides/rel_notes/release_20_08.rst > @@ -62,6 +62,20 @@ New Features >=20 > * Added new PMD devarg ``reclaim_mem_mode``. >=20 > +* **Updated the Intel i40e driver.** > + > + Updated the Intel i40e driver with new features and improvements, > including: > + > + * Re-implemented get_fdir_info and get_fdir_stat in private API. > + * Re-implemented set_gre_key_len in private API. > + * Added support for flow query RSS. > + > +* **Updated the Intel ixgbe driver.** > + > + Updated the Intel ixgbe driver with new features and improvements, > including: > + > + * Re-implemented get_fdir_info and get_fdir_stat in private API. > + >=20 > Removed Items > ------------- > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 970a31cb2..674b711d9 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -8787,7 +8787,7 @@ i40e_tunnel_filter_param_check(struct i40e_pf *pf, >=20 > #define I40E_GL_PRS_FVBM_MSK_ENA 0x80000000 > #define I40E_GL_PRS_FVBM(_i) (0x00269760 + ((_i) * 4)) > -static int > +int > i40e_dev_set_gre_key_len(struct i40e_hw *hw, uint8_t len) { > struct i40e_pf *pf =3D &((struct i40e_adapter *)hw->back)->pf; diff -- > git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h > index e5d0ce53f..192636927 100644 > --- a/drivers/net/i40e/i40e_ethdev.h > +++ b/drivers/net/i40e/i40e_ethdev.h > @@ -1270,6 +1270,11 @@ enum i40e_filter_pctype > uint16_t flow_type); > uint16_t i40e_pctype_to_flowtype(const struct i40e_adapter *adapter, > enum i40e_filter_pctype pctype); > +int i40e_dev_set_gre_key_len(struct i40e_hw *hw, uint8_t len); void > +i40e_fdir_info_get(struct rte_eth_dev *dev, > + struct rte_eth_fdir_info *fdir); > +void i40e_fdir_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_fdir_stats *stat); > int i40e_fdir_ctrl_func(struct rte_eth_dev *dev, > enum rte_filter_op filter_op, > void *arg); It doesn't make sense to add the definition here as these functions only ca= lled by private API. I think it better to move these function to private also [...] > -- > 2.17.1