From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F8DDA09E4; Thu, 28 Jan 2021 09:13:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40EA040692; Thu, 28 Jan 2021 09:13:42 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 0EA8540395; Thu, 28 Jan 2021 09:13:39 +0100 (CET) IronPort-SDR: wJrpw5Wsj8TX9IY6ALNod//Y/Pux8gdRFUdw1OpEXdlukHk343Cdvc1/0+ucVN341FzgL/oUlm PL/R96lDzntA== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="244281480" X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="244281480" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 00:13:37 -0800 IronPort-SDR: 6eEnvkctgEFUKNFsF+D03T63tnsoMqii01rn9gvXnZgb/859/jCRZMOHdL1xr7G0Q4zIaObFEB MGHuaLdmKk/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="430430369" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 28 Jan 2021 00:13:37 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 00:13:36 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 00:13:36 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 28 Jan 2021 00:13:36 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 28 Jan 2021 00:13:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFWrceSJU6t04KPbqHcFMRr3VozzbzIqm9ISNylX0i0bRIX3FZBMlT+bhg1lWC9zhmj/fOmtECyaajosNacwH+H5iQnCyfoK+E67Lfux7TyW0M9jDqeKZ7hs55zQtK4qoAjpxnTn38dWFkmZ2JOkGsw4NM6jbGVgOzCYSZO3CKcc5ntGEsAHnC3Wy1o2oGzMffE++sZHRsC5u0vT6HYYppFuZLyZIrd6ZaT8fhjIprFlhTbCtrNjCmdJSYKPij2BVOEipNCkRjhrLv59YmwWqKNeECM1UtIUUD287dkioclKWoaFZOzk6XkDA6DAYh1T89XHMWXKgyxNTciMVDwNYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkY5tjhp++VZoTZicT11f+ekR1ySW4GfUfVM/LNFHZw=; b=f4oC4fB1x9ShAAGEbWdN/nuWn6pG0cS2Xqwkj68byZrsbRjKpXL5BX35Gb/P/nlUjoyCPKxrrWmjSHUCgDM5RVy2dGfAKuJcRFD+S8EEhMF8Ut4/HCWtADuqqq1PqKkDupxYrIIp+Ux1RuBp65lGLjYC552Ner89FkEMBMYCeA4eXIZShnkMayzpSzQ8UQRHFHk6gRdKbkLsG8GI6Q0Swj4c2U7FP518xH/okbGWnLdRkpWExK744hfJaPNE58ofPBmNl42XoCkEcTjKFrC4zmiBy+IqKbog8MDOxklQRnUl9OJuhWzDt2TiE2pHcT1J/6G4PiFSY/MPo6lYf5U6ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lkY5tjhp++VZoTZicT11f+ekR1ySW4GfUfVM/LNFHZw=; b=OFziXy/fOBdpGhRF+RtoLW8BRWxJPNfWfKfupgGAMbqAeh8tDVyJfDEJ6AB4ELpyx+PBhnHigZh9YINgNZjIyUsFus/IHx5fC7s/eF24EBLSAePeomCIqUlOgMwQUP4I6sxExBWRq+M/D6jRJ0PC0a/EUx/5LCF3Dm7B1g9zGxk= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR1101MB2131.namprd11.prod.outlook.com (2603:10b6:405:51::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.17; Thu, 28 Jan 2021 08:13:01 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::f14e:a742:165b:1a84]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::f14e:a742:165b:1a84%4]) with mapi id 15.20.3784.017; Thu, 28 Jan 2021 08:13:01 +0000 From: "Yang, Qiming" To: "Wang, YuanX" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Wang, YuanX" , "stable@dpdk.org" Thread-Topic: [DPDK] net/ice: fix flow rule checking Thread-Index: AQHW9JHD9dgDM/72qke3yuQvdoFvi6o8sIuA Date: Thu, 28 Jan 2021 08:13:00 +0000 Message-ID: References: <20210127094236.44186-1-yuanx.wang@intel.com> In-Reply-To: <20210127094236.44186-1-yuanx.wang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cbf283d6-8ee4-41c7-228e-08d8c364878d x-ms-traffictypediagnostic: BN6PR1101MB2131: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EgJGocdyuyazRYngXoWnHyyl2rSIApq30p1sgEgxV71efgPn+6Kmna5XGeFcjNCJFuqPDD/FauU+s90Zy5sGDv3ngpLVVuLAUusAkGhKhpv6QVlDShYWaeELe+YjGkhHJKJ1D3b6qbM0JVgROWi58LNmog1eoTKWAAZqrofovvQ7n44Seh1EvSp5TCdME1cSPk4CpTVXgOdH67WEFNTCe+9C4y2s5sW6NyJYVzTm2svP473lotcpCJ05mSsvJ4+sqKcnnKJY93kyL6DIlmXPLCoqdyD3VHLCUyP0Bjma+k2js7/8gJUZTWJCmahJrYjV/Y+BBmgfGMKqhZpc+qD4vJYpFZubjs+iAv1Qe7M5cYZ5APWS+h0aBXR9FUPY3bbXQoL7z3UZN4/R8Y3K4Z9ZtZd+h90KK0LOOt/yOaUcW3nW8O6m7palrh6QEK0oELHeQvA2sOCAiglAfzUxBIIMmfeFKVuaIObZ32L0ucRjmw4Z7puSBCjwd+F0tA+Fbd1U4eiA9cF4F9vx92IBeSenwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(6506007)(64756008)(33656002)(54906003)(5660300002)(26005)(7696005)(52536014)(4326008)(9686003)(450100002)(53546011)(66476007)(76116006)(110136005)(86362001)(66446008)(8936002)(66946007)(186003)(66556008)(71200400001)(8676002)(55016002)(316002)(6636002)(2906002)(83380400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?HYYmxjMVQ+61LBykvedN6iPzWYWkbt7FQWsgB6qAwN97eP3gPBpaKpWj2VNR?= =?us-ascii?Q?Ar8AG16FTXCiSLMzXNQNzCONbzoUpFH4sUx70XyKoLopmM7dmr535CzgSN5a?= =?us-ascii?Q?ZPf1/1LCzqlOk1Cx3yaIEWJAVeS1N+Xyw+8wKWf4yu9/ZzHda9pxWaR1CcdQ?= =?us-ascii?Q?N0jiQpIQM2ZYDf1ttjRoVcBFHJ7i5DRPh4HhwdsqZsQLu6zQA9Xr3ECtX7iB?= =?us-ascii?Q?LZS598sxFhtf37Xe9URKwbT9zeZ52Zayw6JtNcFLz9GCcLV+j6D6kPXIX6bP?= =?us-ascii?Q?37jRH87efgVVKWHceajnZS4ApyCXZhgcyrzWdt6Hn02c3okNwlSgUj4uSGcH?= =?us-ascii?Q?rRwP6m7GYF24RyMPiqjW38Uo2T6aWszwOB156YnevFXPst8yFMsJxUFgRu3+?= =?us-ascii?Q?5IVMENdwbUSeTq7phX73prq0ox55hXImiSdJa+E8iRuE75abWRRSf315Px02?= =?us-ascii?Q?DVKZNra84Jbjrnx/MAB2RgWQcpgbBIhZSNtbCbFhJZinCjYCM2dlimXJL96i?= =?us-ascii?Q?4u1lvgyB80jI1VYKPuiGt0tqUoDt9kTAy5NcmdJD6MtaOFHpVQ9D5R++ScGL?= =?us-ascii?Q?H664E9wYBE385XVfbgQ9Cuci1TRR8BqEP/ZZ7sLoOaUi5NYHp1eeNa1S9082?= =?us-ascii?Q?A7G7Iq1QVbIyHbHY9yDgpDG74bMN4IRwZe6e5eXag3loRWTghzSTWGdmJeS2?= =?us-ascii?Q?rzXU/LOT5aJTfMGEL/l6ckeBRLJItNj35BGYg36G+Uy+BGQd5B/if4Vx2sY9?= =?us-ascii?Q?Ft9GSpXbr0LfqzBZ82n59SGjCJpxHHUhdJXxLV8Lgs7yQNgVeU5Zv56G5OPF?= =?us-ascii?Q?w1Pqi2Jzl2XE3Bpwo2TDnOkKOnWaoCKUTfEoRK63lzjQkAjF1xEpM18KBv3/?= =?us-ascii?Q?F7eFfGeEq50xMloxCMxvpB4tbL/or9D5AbpnjTPEn3pTKXqpm97elR2Dgp2U?= =?us-ascii?Q?36dZZT8N1ljB6TLLdrWcn5a7Z2Py/RkAX1rB49e0PNujWMV3P7eCI6nuIPt+?= =?us-ascii?Q?9dY5iugmm9gAY+mM7QRnttfAjSiuTE7JyZ6RZUhFD5iyihEqlwMjgeVyZgeF?= =?us-ascii?Q?9KCvpbKr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbf283d6-8ee4-41c7-228e-08d8c364878d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2021 08:13:01.0095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qr/NLCDbAc26tr9TcRvG/hdLKLgMhiZjDCIt1PaCOSRQtNHk1zl/G0inB1wpOWW+x3vrM3O8kJhx7hilaBpyag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2131 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [DPDK] net/ice: fix flow rule checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: yuanx.wang > Sent: Wednesday, January 27, 2021 17:43 > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, YuanX ; stable@dpdk.org > Subject: [DPDK] net/ice: fix flow rule checking >=20 > Currently, when the RSS rule set to l4-src-only and l4-dst-only, the hash= value is > different while the ingress packets have same L4 parameters. >=20 > This patch keeps the hash value consistent in above situation. >=20 > Fixes: 38d632cbdc88 ("net/ice: refactor PF RSS") > Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow") > Cc: stable@dpdk.org >=20 > Signed-off-by: yuanx.wang > --- > drivers/net/ice/ice_hash.c | 66 +++++++++++++++++++++----------------- > 1 file changed, 36 insertions(+), 30 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c inde= x > 2d23c8dd5..8092c1acc 100644 > --- a/drivers/net/ice/ice_hash.c > +++ b/drivers/net/ice/ice_hash.c > @@ -712,14 +712,18 @@ ice_refine_hash_cfg_l234(struct ice_rss_hash_cfg > *hash_cfg, > if (rss_type & > (ETH_RSS_NONFRAG_IPV4_UDP | > ETH_RSS_NONFRAG_IPV6_UDP)) { > - if (rss_type & ETH_RSS_L4_SRC_ONLY) > - *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_DST_PORT)); > - else if (rss_type & ETH_RSS_L4_DST_ONLY) > - *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_SRC_PORT)); > - else if (rss_type & > - (ETH_RSS_L3_SRC_ONLY | > - ETH_RSS_L3_DST_ONLY)) > - *hash_flds &=3D ~ICE_FLOW_HASH_UDP_PORT; > + if ((rss_type & > + (ETH_RSS_L4_SRC_ONLY | > ETH_RSS_L4_DST_ONLY)) !=3D > + (ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)) Do you want to avoid set ETH_RSS_L4_SRC_ONLY and ETH_RSS_L4_DST_ONLY at the= same time? > { > + if (rss_type & ETH_RSS_L4_SRC_ONLY) > + *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_DST_PORT)); > + else if (rss_type & ETH_RSS_L4_DST_ONLY) > + *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_UDP_SRC_PORT)); > + else if (rss_type & > + (ETH_RSS_L3_SRC_ONLY | > + ETH_RSS_L3_DST_ONLY)) > + *hash_flds &=3D > ~ICE_FLOW_HASH_UDP_PORT; > + } > } else { > *hash_flds &=3D ~ICE_FLOW_HASH_UDP_PORT; > } > @@ -729,14 +733,18 @@ ice_refine_hash_cfg_l234(struct ice_rss_hash_cfg > *hash_cfg, > if (rss_type & > (ETH_RSS_NONFRAG_IPV4_TCP | > ETH_RSS_NONFRAG_IPV6_TCP)) { > - if (rss_type & ETH_RSS_L4_SRC_ONLY) > - *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_DST_PORT)); > - else if (rss_type & ETH_RSS_L4_DST_ONLY) > - *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_SRC_PORT)); > - else if (rss_type & > - (ETH_RSS_L3_SRC_ONLY | > - ETH_RSS_L3_DST_ONLY)) > - *hash_flds &=3D ~ICE_FLOW_HASH_TCP_PORT; > + if ((rss_type & > + (ETH_RSS_L4_SRC_ONLY | > ETH_RSS_L4_DST_ONLY)) !=3D > + (ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)) > { > + if (rss_type & ETH_RSS_L4_SRC_ONLY) > + *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_DST_PORT)); > + else if (rss_type & ETH_RSS_L4_DST_ONLY) > + *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_TCP_SRC_PORT)); > + else if (rss_type & > + (ETH_RSS_L3_SRC_ONLY | > + ETH_RSS_L3_DST_ONLY)) > + *hash_flds &=3D > ~ICE_FLOW_HASH_TCP_PORT; > + } > } else { > *hash_flds &=3D ~ICE_FLOW_HASH_TCP_PORT; > } > @@ -746,14 +754,18 @@ ice_refine_hash_cfg_l234(struct ice_rss_hash_cfg > *hash_cfg, > if (rss_type & > (ETH_RSS_NONFRAG_IPV4_SCTP | > ETH_RSS_NONFRAG_IPV6_SCTP)) { > - if (rss_type & ETH_RSS_L4_SRC_ONLY) > - *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_DST_PORT)); > - else if (rss_type & ETH_RSS_L4_DST_ONLY) > - *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT)); > - else if (rss_type & > - (ETH_RSS_L3_SRC_ONLY | > - ETH_RSS_L3_DST_ONLY)) > - *hash_flds &=3D ~ICE_FLOW_HASH_SCTP_PORT; > + if ((rss_type & > + (ETH_RSS_L4_SRC_ONLY | > ETH_RSS_L4_DST_ONLY)) !=3D > + (ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)) > { > + if (rss_type & ETH_RSS_L4_SRC_ONLY) > + *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_DST_PORT)); > + else if (rss_type & ETH_RSS_L4_DST_ONLY) > + *hash_flds &=3D > ~(BIT_ULL(ICE_FLOW_FIELD_IDX_SCTP_SRC_PORT)); > + else if (rss_type & > + (ETH_RSS_L3_SRC_ONLY | > + ETH_RSS_L3_DST_ONLY)) > + *hash_flds &=3D > ~ICE_FLOW_HASH_SCTP_PORT; > + } > } else { > *hash_flds &=3D ~ICE_FLOW_HASH_SCTP_PORT; > } > @@ -946,12 +958,6 @@ ice_hash_parse_action(struct > ice_pattern_match_item *pattern_match_item, > RTE_FLOW_ERROR_TYPE_ACTION, > action, > "a non-NULL RSS queue is not > supported"); >=20 > - /** > - * Check simultaneous use of SRC_ONLY and > DST_ONLY > - * of the same level. > - */ > - rss_type =3D rte_eth_rss_hf_refine(rss_type); > - > if (ice_any_invalid_rss_type(rss->func, rss_type, > pattern_match_item- > >input_set_mask)) > return rte_flow_error_set(error, ENOTSUP, > -- > 2.25.1