From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CB7EA0350; Mon, 29 Jun 2020 04:46:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C774F5B30; Mon, 29 Jun 2020 04:46:25 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 312F32C01 for ; Mon, 29 Jun 2020 04:46:23 +0200 (CEST) IronPort-SDR: atMEZhfzmIzk/qprVI7zftlRGss4+TShBVPfpDHX0Pt2mU2+ypm1OpxpmwoJSOK2wfSIvSpjZ0 66jBVhL8Fwuw== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="163912450" X-IronPort-AV: E=Sophos;i="5.75,293,1589266800"; d="scan'208";a="163912450" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2020 19:46:22 -0700 IronPort-SDR: cB3azAIL/GSLSqnsPd1ibkGUBmxoXjwPGWoTDrdqIKOnEHbNwLbdXe7MqxrB6QKkPgcFvrl0sI QLE6vDv26arg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,293,1589266800"; d="scan'208";a="312907068" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 28 Jun 2020 19:46:22 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 19:46:12 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 19:46:11 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.51) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 19:46:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VQQEo9b0yxLlQGt6V7RMxdHdHVHtClacDVI7w+wdPk/x9/IwE8sJN+obEC98/UgiyVPhVhV1l8Td+BamuFtrnpa7W3tWVmhdXE7j3bUOQm12Cl1JsycYc18Q5TBlww6ahyzFX6j8qOlmcvxiL76y8whB4T5rYiv8fuay21svnkO/aHfzE1d8l4ZX1np0CTu2evTjc3uSpLIcdGSJvYFj7PVwEMfnW7tidtjNo2zvTjficMT2ARGx2fR+VhqfwNbi/eTOW0aKPEU9DaH+F4dHvt1vvKztXsXTBBcJi3f2xMY0/6ZYtpSVPEoeRS8GTdA22W/kPJUO0bERmDYQbaOq5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhkMkvm4+I2D3pQl5XY5IoWtTpOyn/EZnGdtb4D0SFw=; b=YDAYcVGtU7hr8BZYrsEc/noueLzQQaUApzCKTjEnFXbLBUE7WZ9fAFZvYcl/8uRZ+aGNgRWVouZ9L1bVZ64yjlChRaradNhIwiZx4rTC/WIgX+I9bZ+G6gEfNnmHeSHQjQLz8PpFc+jHdIWjv88ZfwNJ9YESmeqlRfqMqyJBYNPyeglSimItk5JWldEnkdUpvEkAua6a5poH9xpiThQqEoOStcgj38R7bxPqGSJqYoj4CBB2Kb7pz0Odokjn57FCxKOZ5Xga8DJxV+K5Ku+qugEN55Pncc7gFYffBLHhkQs870W6lEi8g6tpvOiJt74Ivp4HWPERp9B+3cp3+ehmvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hhkMkvm4+I2D3pQl5XY5IoWtTpOyn/EZnGdtb4D0SFw=; b=dM9uZPl1or2dnoRxyP4ogHnk1GSGvZqQwWf9Nkc8XmrtCT3zV9o2xVtKUY2kvyhOqqln4OVHPEBgjrVDoKbOgcGJjkX+h2bqm9eEoIZVFPGXyPw/XQBQBQ+0+hNMbzuKeY1Fr7opd7Z2pyP1wv3KfuJb4tRByItDm+g3AqIZ6uI= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN7PR11MB2642.namprd11.prod.outlook.com (2603:10b6:406:ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.26; Mon, 29 Jun 2020 02:46:09 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3131.026; Mon, 29 Jun 2020 02:46:09 +0000 From: "Yang, Qiming" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH 4/8] net/ice/base: code clean in FDIR module Thread-Index: AQHWTJQBBHKg1YPeuEaOLA6Jmmtj6qju5Xnw Date: Mon, 29 Jun 2020 02:46:09 +0000 Message-ID: References: <20200627150615.2233-1-qi.z.zhang@intel.com> <20200627150615.2233-5-qi.z.zhang@intel.com> In-Reply-To: <20200627150615.2233-5-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba68f910-a075-47a7-38c1-08d81bd693f3 x-ms-traffictypediagnostic: BN7PR11MB2642: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:556; x-forefront-prvs: 044968D9E1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nX9sX9C9mwo24B/5g1XcxiN34Lwb/ikb65CAyx5gCUOGo4flBNGo6xczWT/v7L+lq/Sionv8Z5Ti8/uEzogKUVL2C89F7meJXTcxiaJUqZzmLyuTmnjrSpSUQSgg9v1k6kLh1K8VZkULGhaEyHDWMH0ccsqQOr2ko/uXbqQu1mSumR/fHs52bDlbiSj/5xebHAIEbWMjlu7x2s5L0WCdD5VNs0kWyEQ+vO2711Q9r1CXQ/yF25azeLRhCW9Vvq2zpcZOKvVcarLaz9OQcjIhPhbtOu+0/NWJbwaPv1SVIvfgMS+ohv2Cd9ZPc65T1jXqQPfCIK1+pGZR61rVb+d+Tg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(366004)(55016002)(83380400001)(6636002)(4326008)(9686003)(71200400001)(107886003)(6862004)(478600001)(7696005)(66476007)(66446008)(33656002)(52536014)(66556008)(66946007)(6506007)(53546011)(26005)(8676002)(186003)(2906002)(8936002)(54906003)(316002)(76116006)(64756008)(86362001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: /wJ0zUMVQLcDTIF3PCLHb6/JiuaSANKig6WQV6IpaIZjIMiXm2ktVd+u7a9syz2He1/TefvhQ//0iJXk+tdhR9G4p23W70by1AqwScOWsfo6DEa5UmD+eXAqXHMV6D3xFYIWyFnzXJRSKwk+9ST7Q9yLnlMf/3Gxg7J/zB6/2y2XV27aCE2bZUvfhdWMQw0JRFQe44QOmc3j6zYb101zFE61OuHurfbu33t9K2gDQqdS28Zmp4cro4CLWreO48PfgCok7P9qqzCxiZ5kHUnoP/eZx9m5DEqVzpMXrxWVLEe5MXFP26qy1CGFBTZ55hNkgKg5Dzg9H19erMe/ennNeFZ0p5RAkZsgTZhyEIFekT6sO7ZGLp6sBbc+Qh+aTV7EGUkXPCrhcrcuyJNW7Cp4qWS94oAJVFoPGwHEpipBfDHET5Q2swVziRnZZOkzAsFBbZma+tIKnrXOaSKauydIhUr5PXKFKnIthBlGchb/F6ZBt8jVC9zkdrNKFK0cyMRI Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba68f910-a075-47a7-38c1-08d81bd693f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2020 02:46:09.0288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kjIQ6KmKs0qovgspGTQ2H/X/lpdLranGpQl1bis3nij95xtKI1WWP2kVo6/UnAWtA2NJqTlzyUDEIWh5lSZwOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2642 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 4/8] net/ice/base: code clean in FDIR module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, June 27, 2020 23:06 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Stillwell Jr, Paul = M > > Subject: [PATCH 4/8] net/ice/base: code clean in FDIR module >=20 > Remove unused macro and funciton. funciton / Function > Declare no external referenced function as static. >=20 > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_fdir.c | 23 +---------------------- > drivers/net/ice/base/ice_fdir.h | 3 --- > 2 files changed, 1 insertion(+), 25 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_f= dir.c > index c5a20632c..b1dc2afb7 100644 > --- a/drivers/net/ice/base/ice_fdir.c > +++ b/drivers/net/ice/base/ice_fdir.c > @@ -597,7 +597,7 @@ static const struct ice_fdir_base_pkt ice_fdir_pkt[] = =3D { > * ice_set_dflt_val_fd_desc > * @fd_fltr_ctx: pointer to fd filter descriptor > */ > -void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx) > +static void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx > +*fd_fltr_ctx) > { > fd_fltr_ctx->comp_q =3D ICE_FXD_FLTR_QW0_COMP_Q_ZERO; > fd_fltr_ctx->comp_report =3D > ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL; > @@ -1389,27 +1389,6 @@ bool ice_fdir_is_dup_fltr(struct ice_hw *hw, > struct ice_fdir_fltr *input) } >=20 > /** > - * ice_clear_vsi_fd_table - admin command to clear FD table for a VSI > - * @hw: hardware data structure > - * @vsi_num: vsi_num (HW VSI num) > - * > - * Clears FD table entries by issuing admin command (direct, 0x0B06) > - * Must to pass valid vsi_num as returned by "AddVSI". > - */ > -enum ice_status ice_clear_vsi_fd_table(struct ice_hw *hw, u16 vsi_num) -= { > - struct ice_aqc_clear_fd_table *cmd; > - struct ice_aq_desc desc; > - > - cmd =3D &desc.params.clear_fd_table; > - ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_clear_fd_table); > - cmd->clear_type =3D CL_FD_VM_VF_TYPE_VSI_IDX; > - > - cmd->vsi_index =3D CPU_TO_LE16(vsi_num); > - return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); > -} > - > -/** > * ice_clear_pf_fd_table - admin command to clear FD table for PF > * @hw: hardware data structure > * > diff --git a/drivers/net/ice/base/ice_fdir.h b/drivers/net/ice/base/ice_f= dir.h > index 1f31debe6..ad3e11a5b 100644 > --- a/drivers/net/ice/base/ice_fdir.h > +++ b/drivers/net/ice/base/ice_fdir.h > @@ -17,7 +17,6 @@ > #define ICE_FDIR_TUN_PKT_OFF 50 > #define ICE_FDIR_MAX_RAW_PKT_SIZE (512 + > ICE_FDIR_TUN_PKT_OFF) > #define ICE_FDIR_BUF_FULL_MARGIN 10 > -#define ICE_FDIR_BUF_HEAD_ROOM 32 >=20 > /* macros for offsets into packets for flow director programming */ > #define ICE_IPV4_SRC_ADDR_OFFSET 26 > @@ -222,7 +221,6 @@ struct ice_fdir_base_pkt { >=20 > enum ice_status ice_alloc_fd_res_cntr(struct ice_hw *hw, u16 *cntr_id); > enum ice_status ice_free_fd_res_cntr(struct ice_hw *hw, u16 cntr_id); -vo= id > ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx); enum > ice_status ice_alloc_fd_guar_item(struct ice_hw *hw, u16 *cntr_id, u16 > num_fltr); enum ice_status @@ -231,7 +229,6 @@ enum ice_status > ice_alloc_fd_shrd_item(struct ice_hw *hw, u16 *cntr_id, u16 num_fltr); > enum ice_status ice_free_fd_shrd_item(struct ice_hw *hw, u16 cntr_id, > u16 num_fltr); -enum ice_status ice_clear_vsi_fd_table(struct ice_hw *hw, > u16 vsi_num); enum ice_status ice_clear_pf_fd_table(struct ice_hw *hw); > void ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *inp= ut, > -- > 2.13.6