DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
Date: Thu, 28 Jan 2021 08:21:41 +0000	[thread overview]
Message-ID: <BN6PR11MB0017C0B2D49832F419725288E5BA9@BN6PR11MB0017.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210127160516.5718-1-haiyue.wang@intel.com>

Acked-by: Qiming Yang <qiming.yang@intel.com>

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, January 28, 2021 00:05
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH v1] net/ice/base: don't set VLAN mode in DCF mode
> 
> The PF will set the VLAN mode globally, DCF just needs to get the VLAN mode.
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ice/base/ice_vlan_mode.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ice/base/ice_vlan_mode.c
> b/drivers/net/ice/base/ice_vlan_mode.c
> index 2e4c3f62c4..460c4f902b 100644
> --- a/drivers/net/ice/base/ice_vlan_mode.c
> +++ b/drivers/net/ice/base/ice_vlan_mode.c
> @@ -354,6 +354,12 @@ static enum ice_status ice_set_svm(struct ice_hw
> *hw)
>   */
>  enum ice_status ice_set_vlan_mode(struct ice_hw *hw)  {
> +	/* DCF only has the ability to query the VLAN mode. Setting the VLAN
> +	 * mode is done by the PF.
> +	 */
> +	if (hw->dcf_enabled)
> +		return ICE_SUCCESS;
> +
>  	if (!ice_is_dvm_supported(hw))
>  		return ICE_SUCCESS;
> 
> --
> 2.30.0


  reply	other threads:[~2021-01-28  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 16:05 Haiyue Wang
2021-01-28  8:21 ` Yang, Qiming [this message]
2021-01-28 13:29   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB0017C0B2D49832F419725288E5BA9@BN6PR11MB0017.namprd11.prod.outlook.com \
    --to=qiming.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).