From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1E97A0523; Thu, 2 Jul 2020 06:22:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7C151D72B; Thu, 2 Jul 2020 06:20:58 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9243A1D70C for ; Thu, 2 Jul 2020 06:20:56 +0200 (CEST) IronPort-SDR: QVNgCYOpO4yc9F4fw6HnF1uCbgq+HCVhu0xYwR3ob4fxMn7tzm4XJpbrNIDZxcLNR0OAlasy+B DUhSpIhN0HHg== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="164841648" X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="164841648" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 21:20:55 -0700 IronPort-SDR: wjYs471aC7NjH4ZYaD9zqoM8vUTf/BRaQvVTrn7QoelqvaEg6scbwHawMljyePCP27seqSz7Dz Ky6yo2UqAWGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,302,1589266800"; d="scan'208";a="481556063" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga006.fm.intel.com with ESMTP; 01 Jul 2020 21:20:55 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 1 Jul 2020 21:20:55 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 1 Jul 2020 21:20:55 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 21:20:54 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jul 2020 21:20:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVPdaz3ZH77SmcJJd0omLeVxacSRgVDJYc8CEexEtH2HvLxBgInqkfE3kWFDuvZwdSTfBpEGp2NfaWGs4uYY7ndDgJSK8qJ7+bScx8mhmQzOV34anDj5I7YVXAvyoaNHTCgeiytm2u0i6o05j8hhTWK1nmyQelT/9OACNJ9FtJ1hd2VXU6/bDG0nMPR4AYkQwGuy7gswJtcL3RRluooiIRSZYocZTbWDiL5xXIl3LErZ0xPfFfVMf2hqPELP2UbUpwFxL5bvP+z20p0vKK4tGquWHQOc8pzQMDRcrdolwVxEsJUyl4CQy88okQM6fCRunq+YDy+F+FieEEQnFuejzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1siZraatA5Lg3gMZ56mO6hNo4DsKvI7ww3uKp8QZ5Ok=; b=nLwZ/1unBpwlbVZfKOcLWIlrAjmr6s5IVwdyaw5oAWQBgqv8YyYjqX2vo29ohdknLrzjjPhJjBIzRRL5P4OYnoxjTgExrJ/kBltbuD5hGMII7QzyvFiCg1csHaxX4gqNaHUPmxqSd9xjD6Wgm5SHvIZ0Qg93QbGbMzR0LYbWy5x9/yeBtDLBWHNKabvP/jzjTGAo3jn1zSdS+V4ddjBvhF4kGP824J9q6nJj5n/e/K4V533fo9O5aDut+N0I3pqCfyVcSzKh+q0cKerxyGbt/gel9Pn42uCNfvcoDC2ORahR2H7+tmpdMD4k9+8D/0HJvXp7R/P4rGVi45ECa1hZqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1siZraatA5Lg3gMZ56mO6hNo4DsKvI7ww3uKp8QZ5Ok=; b=SfLbWtuMNo1WOlx5VJYuuXBXUVOokwLuZ0QP+X4d2MmP00PK/cV64JRWzELSbugqVuVq9QtUGz6as1irU8YYSQndWJJJlMxhgEL96xnYFLoYdJ29GV6cQXgPhDB7VkgqcrO/AhCwQjWTCa3N3b7hgRrVA9Eo51y25GJjHcm3yBk= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB1650.namprd11.prod.outlook.com (2603:10b6:405:11::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Thu, 2 Jul 2020 04:20:53 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::c8eb:f4c9:5b58:3120%6]) with mapi id 15.20.3131.028; Thu, 2 Jul 2020 04:20:53 +0000 From: "Yang, Qiming" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH v2 4/8] net/ice/base: code clean in FDIR module Thread-Index: AQHWT2rrnW3UWhnc2UWquK+SgH+XQqjzsS4Q Date: Thu, 2 Jul 2020 04:20:53 +0000 Message-ID: References: <20200701054951.2393-1-qi.z.zhang@intel.com> <20200701054951.2393-5-qi.z.zhang@intel.com> In-Reply-To: <20200701054951.2393-5-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b457bea9-328d-4683-e73d-08d81e3f4f1b x-ms-traffictypediagnostic: BN6PR11MB1650: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mGz63160KXVEntp6n3pLNzrrcOZVcN8eASV1ktGmIoGLS6lIj6DtCFrIzNmpWRhJ0V4GVbeafa9SfQW9yF32eYpvC1P3pzo7QgEACVHNHtd8D2RX52vXAV/3EIzwdB9ds1QgmTqNn+Zwi2DCpW7JKYLnQyWPKOnuMj1gSda+2KuDepq8vN5Wd+amLg2DKHvz4PXseEzCdL6u/p7Bhuqtd5e6RZ9M6wVMgaXFdJ8ITN/AQu3dZfb5er5U7uax4T3p8SkiDwdJ+A0gKZTOduFOKMJaObdcYPwVfyR4hqj5GXHF5VBKbxKgt3KgIm6URSYApULZ16TaBamSnO3lXB6LcQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(39860400002)(376002)(396003)(136003)(66946007)(6506007)(66476007)(4326008)(6862004)(83380400001)(55016002)(186003)(478600001)(2906002)(76116006)(5660300002)(54906003)(64756008)(66556008)(66446008)(9686003)(52536014)(316002)(26005)(6636002)(53546011)(8936002)(33656002)(107886003)(71200400001)(8676002)(86362001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: DV4fScsj9U97nzZSBK4F83WtjqwTI/Q8ahHAf/E7A7lW5YlefaaUJicPZS36gdXiPTMr/3LPYHwSH1VfMw9M5BFWqeF3jP/Of0cQYX4xRlUkGjXtfURl7JVHCPl+TZgETR/1FyoIVAJ68kcJ9/KZWua2ucBUBpjq5RQ2isuzZONqxChKoXJJ12suIJWGWlHGcAHYdAgBaZTitLSkqpzdnN3ydK1dCCsKilZPBJJKa8dAn+mEeUGa2eWZMh94SOBAjNLZK9WqTNbo7fpyKyHf3TOnQSQzQB+Yv91pAx/MFI1Pr/hQ6ryRZ26BQwerpRmp6IZRLdE58Qz2kpR5C+gYQjFuInCtAe292UoSD249kDSfM37lZUAUcSLS/UuKEudHdoaV8CQURpkZubiGgEjtNMMQgYtnI0MTxxUuXKRrGSc53aDLYifSe+vUd+4YcuT0/6NcpNCRiCiGoiK1bZ9t0UO68QiWU1cG10pyCAm8ipen5kxSPom/Zixn5YKOy4WA Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b457bea9-328d-4683-e73d-08d81e3f4f1b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 04:20:53.0777 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +yLsbRm01/SyDTVEnz8LoiPN08/aax8PVBxeAJJS5TBC9O9PaMRUXc3s+KjuBYFaASK20HDfiWPZkR7K80h9DA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1650 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/8] net/ice/base: code clean in FDIR module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, July 1, 2020 13:50 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z ; Stillwell Jr, Paul = M > > Subject: [PATCH v2 4/8] net/ice/base: code clean in FDIR module >=20 > Remove unused macro and funciton. This error spell still exist. Please fix it when you apply it > Declare no external referenced function as static. >=20 > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_fdir.c | 23 +---------------------- > drivers/net/ice/base/ice_fdir.h | 3 --- > 2 files changed, 1 insertion(+), 25 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_f= dir.c > index c5a20632c..b1dc2afb7 100644 > --- a/drivers/net/ice/base/ice_fdir.c > +++ b/drivers/net/ice/base/ice_fdir.c > @@ -597,7 +597,7 @@ static const struct ice_fdir_base_pkt ice_fdir_pkt[] = =3D { > * ice_set_dflt_val_fd_desc > * @fd_fltr_ctx: pointer to fd filter descriptor > */ > -void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx) > +static void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx > +*fd_fltr_ctx) > { > fd_fltr_ctx->comp_q =3D ICE_FXD_FLTR_QW0_COMP_Q_ZERO; > fd_fltr_ctx->comp_report =3D > ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL; > @@ -1389,27 +1389,6 @@ bool ice_fdir_is_dup_fltr(struct ice_hw *hw, > struct ice_fdir_fltr *input) } >=20 > /** > - * ice_clear_vsi_fd_table - admin command to clear FD table for a VSI > - * @hw: hardware data structure > - * @vsi_num: vsi_num (HW VSI num) > - * > - * Clears FD table entries by issuing admin command (direct, 0x0B06) > - * Must to pass valid vsi_num as returned by "AddVSI". > - */ > -enum ice_status ice_clear_vsi_fd_table(struct ice_hw *hw, u16 vsi_num) -= { > - struct ice_aqc_clear_fd_table *cmd; > - struct ice_aq_desc desc; > - > - cmd =3D &desc.params.clear_fd_table; > - ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_clear_fd_table); > - cmd->clear_type =3D CL_FD_VM_VF_TYPE_VSI_IDX; > - > - cmd->vsi_index =3D CPU_TO_LE16(vsi_num); > - return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); > -} > - > -/** > * ice_clear_pf_fd_table - admin command to clear FD table for PF > * @hw: hardware data structure > * > diff --git a/drivers/net/ice/base/ice_fdir.h b/drivers/net/ice/base/ice_f= dir.h > index 1f31debe6..ad3e11a5b 100644 > --- a/drivers/net/ice/base/ice_fdir.h > +++ b/drivers/net/ice/base/ice_fdir.h > @@ -17,7 +17,6 @@ > #define ICE_FDIR_TUN_PKT_OFF 50 > #define ICE_FDIR_MAX_RAW_PKT_SIZE (512 + > ICE_FDIR_TUN_PKT_OFF) > #define ICE_FDIR_BUF_FULL_MARGIN 10 > -#define ICE_FDIR_BUF_HEAD_ROOM 32 >=20 > /* macros for offsets into packets for flow director programming */ > #define ICE_IPV4_SRC_ADDR_OFFSET 26 > @@ -222,7 +221,6 @@ struct ice_fdir_base_pkt { >=20 > enum ice_status ice_alloc_fd_res_cntr(struct ice_hw *hw, u16 *cntr_id); > enum ice_status ice_free_fd_res_cntr(struct ice_hw *hw, u16 cntr_id); -vo= id > ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx); enum > ice_status ice_alloc_fd_guar_item(struct ice_hw *hw, u16 *cntr_id, u16 > num_fltr); enum ice_status @@ -231,7 +229,6 @@ enum ice_status > ice_alloc_fd_shrd_item(struct ice_hw *hw, u16 *cntr_id, u16 num_fltr); > enum ice_status ice_free_fd_shrd_item(struct ice_hw *hw, u16 cntr_id, > u16 num_fltr); -enum ice_status ice_clear_vsi_fd_table(struct ice_hw *hw, > u16 vsi_num); enum ice_status ice_clear_pf_fd_table(struct ice_hw *hw); > void ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *inp= ut, > -- > 2.13.6