From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B86FA0A0E; Wed, 28 Apr 2021 09:45:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D73E940147; Wed, 28 Apr 2021 09:45:32 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EB2EE40041 for ; Wed, 28 Apr 2021 09:45:30 +0200 (CEST) IronPort-SDR: qeORvx+2s0es+8prq5q5u2lPbXOMNipqFHGmaoY39jtCGoWGthWqcKWeVKuMVLI+uR43ZRyR3F tp6oX01VJDWA== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="257983549" X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="257983549" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 00:45:25 -0700 IronPort-SDR: nfTxHQPYePFuvChUeZCjwoYz5WSDVBl/XtCs8jO3V0yW5PMryWN9czW9Syzk/f4VAihwWhnDXl pk3Brr0IVQOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="425515220" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 28 Apr 2021 00:45:25 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 28 Apr 2021 00:45:25 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 28 Apr 2021 00:45:25 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 28 Apr 2021 00:45:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PofohpABt1aQkhIKO4/Vhdx79uimx9gocSmKokeGsLW/Chnl+2IdjhjyXzu3KuG++lHm+4ysU9MWGiG/pllr1SDHx465IzUL79QwVFz2XHh2GudNNQthMUfcgFPIaAwWChbSg+LfZDVYdd1hmfQle3bCwnFxIIsF6geDeh7yK3kiWYBrbhe5aVf/xKyUI6EWh5PuZPduWVthR+eLvGP3T8bLokjRqqeNJKM6ujBeWzUCEt825aJ5AQ1pcxmtGNjP9NYFljiLzlxTcK/NlhabGajRt4rQtGQaqYykTLgi55zYiOdT3V7poCujDPsOiTeBnuBNzOdJZi7vWjTiK9hmGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2+dyuUr7rskR+2QUvesri8gXXnZHhs06nXYoRjraGM=; b=j9/y3FV4KR9+4hBm0fY0phn4PYgpDOpUEzkUBaP4qEFs6nYh6ugK1T8lrz085yz2rVRFi0Cg4Zkc1+nOCrkeXzle2Uv1ztgiJtwDFGdQLSDhlu1WsVfbKvAFiBn9oPA6drCc/2lOACxccLQ6H0GD0zMdu8q1IAykbGZPHC8Pb6jAdERwjxubY4NRmF17NfYpXZENOBSyy42HeYhBKMVyWUD6Dn7sPxNhdfC8TYkFDM0xBT5QDTmKOYEPynSKroZBAPdIWggnOQcmT9lLM5PS4JChlH8pxZ9dLUaH+Lf/JBPaqCLxKSFqm8CZdnCvh2va73142sgD7FhDmacf1C8aOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t2+dyuUr7rskR+2QUvesri8gXXnZHhs06nXYoRjraGM=; b=zExCbXuvJVI27l7IZAKptJgOqK9YLZJdeI9uNQGMJyqeZAyLu3rnREDKTkc4cefQT6IlzTn5O/dLuYBOTWDfMhaplt8twf9X3ZNPq6jP5yAg6IbI3ONW3lOVoJLTHAS5Eq7GteED//WzrIzeI2xBrgThe39taqPJnHyR85yuQxo= Received: from BN6PR11MB0017.namprd11.prod.outlook.com (2603:10b6:405:6c::34) by BN6PR11MB3938.namprd11.prod.outlook.com (2603:10b6:405:79::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.25; Wed, 28 Apr 2021 07:45:20 +0000 Received: from BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::31fc:8a3:8229:1619]) by BN6PR11MB0017.namprd11.prod.outlook.com ([fe80::31fc:8a3:8229:1619%4]) with mapi id 15.20.4065.027; Wed, 28 Apr 2021 07:45:20 +0000 From: "Yang, Qiming" To: "Zhang, RobinX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" , "Wu, Jingjing" , "Yang, SteveX" Thread-Topic: [PATCH 1/2] net/iavf: fix missing set primary mac type when start port Thread-Index: AQHXO0gftaF1QUAUPkieZbIF2mQMgKrJjZwg Date: Wed, 28 Apr 2021 07:45:19 +0000 Message-ID: References: <20210427092243.391908-1-robinx.zhang@intel.com> <20210427092243.391908-2-robinx.zhang@intel.com> In-Reply-To: <20210427092243.391908-2-robinx.zhang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a8d20ef-6b3d-4efa-6032-08d90a1992a0 x-ms-traffictypediagnostic: BN6PR11MB3938: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1079; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lWMkLIA6EmXcL8QEnvwFRny6BmOf3SFZe8G1UPyaplHKApMe438kz7Ir7c7cGgtmFHLkZp6+rYOoeDzMb4o7zy7uSbI+rEC9BfYzJilPczMj9s/u3cZRy9BRvq64VG26HSU6omK2/FMiWan6uHDmJacW1jNAbh/LNT+ipQqsGa57sECGLM052e9uCkjVH1Zpp/jgoL3DH0glqN6A3fUWvK51/mCl7eVk7wCr4GdJ0dElR6On5OBKePknasGuoj/TUULyHtZq/stWfYdjmXbB6t0/HTX5RV75QmQbQTAX0KHONYE/cko/g/rBnIVjr+swNiUIG5CLj12uFzg8LOmuub7XE2TenffIKmXTUDo44sBVlBr1X3zUUUa8fkOrNSNydDEQR/szXyLdw1IGjLrJGG1xGjjClYmrYg794SQik3WbXJ7ziX+XMUCXrZBpHwFnM7O/JsR58P28IFhAEaZ6/5p3BnEEwNaveCpZiCqXJ7qck8/sUXp9oWncKbBSwRI44qS8crwBTeJeNQhIUDMCXRy/zzk5aYUqULXHgRMtb5GTq6GdpdqkqpgOHbVPSpI7xqVV3ztiUvbsjujepOhOfHFZBJ+/igrJceiWopsSceY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB0017.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(136003)(39860400002)(396003)(366004)(316002)(52536014)(186003)(83380400001)(4326008)(7696005)(38100700002)(122000001)(33656002)(64756008)(53546011)(26005)(66446008)(66556008)(66946007)(107886003)(110136005)(86362001)(66476007)(2906002)(55016002)(8936002)(9686003)(8676002)(478600001)(54906003)(6506007)(71200400001)(76116006)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yczgZYVtp8S6Odm5bYqfQQ8DNYt5wEe3iiNjFeYwzfOiq0t1xYhCfWhYW0o6?= =?us-ascii?Q?x8Z3W77LXu0SmZkCTRz1omWtcblwSCcxJW5D0Lb4CzBO1GhSY9kuUQKg63kx?= =?us-ascii?Q?1WETTwV++7lLyrwqQbiAApwvgAa6CswHzIbg1H8TT4cXy7AwzhDNic4TWiWk?= =?us-ascii?Q?1m0uiOakDbE3HM68mWsjq7LQ9TGQIhlitVQftqUkrpj7tFEEaBYiV7i66SoK?= =?us-ascii?Q?a7cLJeDBD+RAbtEZxtPQhU2lNoCjIna38fn5K1Z6w/AT8xKcPy/c1WC9OUEQ?= =?us-ascii?Q?fbtKh16Dxrh69/2VDYWxYAkxrsaZUeQTPEcJO1tmLQIAX5t2p8uUpFhkaAAT?= =?us-ascii?Q?xfQ/9l9WD8VfGmYML1uNv/kHkrvLQb2pi9D9ePwu/kBSmVBF+Pa60YlMfWrM?= =?us-ascii?Q?6hyElLlXcRDix7+LjKivyouDu8Q7/1OSBaCcvWhhQjqTMYlLhdxUoyYY4Zi2?= =?us-ascii?Q?l3lKrlQAfdaPi5HBViM+cGI7xSzYApBweqwPSf+99eETHk//5hAB0dzi0qT+?= =?us-ascii?Q?qnd7haj970BWbypYczSC0keqjYy5MNobvdEtX4pjN03IeoffB3GJ5IvJjCQE?= =?us-ascii?Q?MjJYZf3F2YQ75h+Ssu4V123xRfaCJBJCF2sZR3cKMVXCnqjsn6y/lfur6RUV?= =?us-ascii?Q?MRHljOGlfq5gX/7ISkukraGyfCL6IW1ZxNGMW2v2VgivVJek9gD8fnXHcBK+?= =?us-ascii?Q?bmBktxnFe1maKIaNZBU91+OIFuXuHzn7Pfvd67chka+jacWHpZHl5DGb41FL?= =?us-ascii?Q?NR5LjadmECAB1e7mphpK5TPj2m4g8u9dkHbR0Eb1+GOL9eNI7UBArKIc3NyW?= =?us-ascii?Q?ycrgvAwI49nS+Z+pX+Tb56sSmgwz+jEd/+c8PUU7XVWsDIQJA2PDYIGV+WE8?= =?us-ascii?Q?dhk2ka/FklDno5kSSbp0oCqWSX+alR14Pxa2hMT86YXXXXgHk5syTX9/62Ax?= =?us-ascii?Q?PslCPjeKi355XiwkYXG0ymRdnrhyGuWKdHWWd1ylG3CSMxkH8mLOthBYtfDA?= =?us-ascii?Q?PxmCFGI/We4Uu3WDBum4PmZpb080FygynXBeXnw8BZny9jBOiTUxUEIKhB0x?= =?us-ascii?Q?Q8TTTfTujuJZCwZRQsE+b15P4igqOLOoM/bf6nuMTCcWemUPUcxltcA6YGmf?= =?us-ascii?Q?ewydgOx9Bt+Qu9cUgHYHYBdlXWiLR4Gz2TCqGohYDCvgCyXJ4KG0qig1K3tz?= =?us-ascii?Q?JI0ieAi1UAFD20cD2fxf/q+/n2e9mWCVqoQ48qXCDa2/HT/3dMBxLKr5RIYn?= =?us-ascii?Q?htpiwM7j/J/Tu6EaJkRM72xW/E2z11NbZusEJ4d0Z98HJHTyLZa1cZ6kzMLT?= =?us-ascii?Q?c0wNls+wgLHTZ3Rox7Hk9Vcz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB0017.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8d20ef-6b3d-4efa-6032-08d90a1992a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 07:45:19.9150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: amdWf6ZPwCJLU9SMhNdIvWlDr4sSpDUxibLie6ejcx3H1A0wYTMrTyw9po9h2/CoaiE9X5v7DZp6r6iVdsRV/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3938 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/iavf: fix missing set primary mac type when start port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,=20 > -----Original Message----- > From: Zhang, RobinX > Sent: Tuesday, April 27, 2021 17:23 > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; W= u, > Jingjing ; Yang, Qiming ; > Yang, SteveX ; Zhang, RobinX > > Subject: [PATCH 1/2] net/iavf: fix missing set primary mac type when star= t > port >=20 > When start port, all mac addresses will be set. We should set the mac typ= e of Please use MAC. > default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. >=20 > Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address= ") >=20 > Signed-off-by: Robin Zhang > --- > drivers/net/iavf/iavf_vchnl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.= c index > 0026120cf4..5d57e8b541 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter > *adapter, bool add) > continue; > rte_memcpy(list->list[j].addr, addr->addr_bytes, > sizeof(addr->addr_bytes)); > - list->list[j].type =3D VIRTCHNL_ETHER_ADDR_EXTRA; > + list->list[j].type =3D (j =3D=3D 0 ? > + > VIRTCHNL_ETHER_ADDR_PRIMARY : > + VIRTCHNL_ETHER_ADDR_EXTRA); > PMD_DRV_LOG(DEBUG, "add/rm > mac:%x:%x:%x:%x:%x:%x", > addr->addr_bytes[0], addr- > >addr_bytes[1], > addr->addr_bytes[2], addr- > >addr_bytes[3], > -- > 2.25.1