When start port, all mac addresses will be set. We should set the mac type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Robin Zhang (2): net/iavf: fix missing set primary mac type when start port net/i40e: fix missing set primary mac type when start port drivers/net/i40e/i40e_ethdev_vf.c | 4 +++- drivers/net/iavf/iavf_vchnl.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) -- 2.25.1
When start port, all mac addresses will be set. We should set the mac type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address") Signed-off-by: Robin Zhang <robinx.zhang@intel.com> --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 0026120cf4..5d57e8b541 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add) continue; rte_memcpy(list->list[j].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; + list->list[j].type = (j == 0 ? + VIRTCHNL_ETHER_ADDR_PRIMARY : + VIRTCHNL_ETHER_ADDR_EXTRA); PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x", addr->addr_bytes[0], addr->addr_bytes[1], addr->addr_bytes[2], addr->addr_bytes[3], -- 2.25.1
When start port, all mac addresses will be set. We should set the mac type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address") Signed-off-by: Robin Zhang <robinx.zhang@intel.com> --- drivers/net/i40e/i40e_ethdev_vf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index aeb6816b9f..8f3b152b6c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2127,7 +2127,9 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add) continue; rte_memcpy(list->list[j].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; + list->list[j].type = (j == 0 ? + VIRTCHNL_ETHER_ADDR_PRIMARY : + VIRTCHNL_ETHER_ADDR_EXTRA); PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x", addr->addr_bytes[0], addr->addr_bytes[1], addr->addr_bytes[2], addr->addr_bytes[3], -- 2.25.1
Hi, > -----Original Message----- > From: Zhang, RobinX <robinx.zhang@intel.com> > Sent: Tuesday, April 27, 2021 17:23 > To: dev@dpdk.org > Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Wu, > Jingjing <jingjing.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; > Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX > <robinx.zhang@intel.com> > Subject: [PATCH 1/2] net/iavf: fix missing set primary mac type when start > port > > When start port, all mac addresses will be set. We should set the mac type of Please use MAC. > default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. > > Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address") > > Signed-off-by: Robin Zhang <robinx.zhang@intel.com> > --- > drivers/net/iavf/iavf_vchnl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index > 0026120cf4..5d57e8b541 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter > *adapter, bool add) > continue; > rte_memcpy(list->list[j].addr, addr->addr_bytes, > sizeof(addr->addr_bytes)); > - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; > + list->list[j].type = (j == 0 ? > + > VIRTCHNL_ETHER_ADDR_PRIMARY : > + VIRTCHNL_ETHER_ADDR_EXTRA); > PMD_DRV_LOG(DEBUG, "add/rm > mac:%x:%x:%x:%x:%x:%x", > addr->addr_bytes[0], addr- > >addr_bytes[1], > addr->addr_bytes[2], addr- > >addr_bytes[3], > -- > 2.25.1
When start port, all MAC addresses will be set. We should set the MAC type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address") Signed-off-by: Robin Zhang <robinx.zhang@intel.com> --- v2: -fix commit message typo --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 0026120cf4..5d57e8b541 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add) continue; rte_memcpy(list->list[j].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; + list->list[j].type = (j == 0 ? + VIRTCHNL_ETHER_ADDR_PRIMARY : + VIRTCHNL_ETHER_ADDR_EXTRA); PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x", addr->addr_bytes[0], addr->addr_bytes[1], addr->addr_bytes[2], addr->addr_bytes[3], -- 2.25.1
When start port, all MAC addresses will be set. We should set the MAC type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address") Signed-off-by: Robin Zhang <robinx.zhang@intel.com> --- v2: -fix commit message typo --- drivers/net/i40e/i40e_ethdev_vf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index aeb6816b9f..8f3b152b6c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2127,7 +2127,9 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add) continue; rte_memcpy(list->list[j].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; + list->list[j].type = (j == 0 ? + VIRTCHNL_ETHER_ADDR_PRIMARY : + VIRTCHNL_ETHER_ADDR_EXTRA); PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x", addr->addr_bytes[0], addr->addr_bytes[1], addr->addr_bytes[2], addr->addr_bytes[3], -- 2.25.1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Robin Zhang
> Sent: Wednesday, April 28, 2021 4:05 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>;
> Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC type
> when start port
>
> When start port, all MAC addresses will be set. We should set the MAC type of
> default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
>
> Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address")
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Robin Zhang
> Sent: Wednesday, April 28, 2021 4:05 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang,
> Qiming <qiming.yang@intel.com>; Yang, SteveX <stevex.yang@intel.com>;
> Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix missing set primary MAC type
> when start port
>
> When start port, all MAC addresses will be set. We should set the MAC type of
> default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY.
>
> Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address")
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi