From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Sexton, Rory" <rory.sexton@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core
Date: Wed, 15 Jul 2020 15:08:57 +0000 [thread overview]
Message-ID: <BN6PR11MB12821AAE804D713E77C0718CFF7E0@BN6PR11MB1282.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200714160200.1727417-1-rory.sexton@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Rory Sexton
> Sent: Tuesday, July 14, 2020 5:02 PM
> To: dev@dpdk.org; Hunt, David <david.hunt@intel.com>
> Subject: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio
> threshold per core
>
> This modification allows for the branch ratio threshold to be set per core rather
> than system wide. This gives greater flexibility to the branch ration monitoring
Small typo ration ->ratio
> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
> Reviewed-by: David Hunt <david.hunt@intel.com>
>---
>v4: adding upper limit of 100.0 to branch ratio
>---
The upper limit changes looks fine to me.
Small nitpick that the commit headline should be in lower case, same applicable to other patches.
You can take care this next time if you are spinning the another version and keep my ack.
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
next prev parent reply other threads:[~2020-07-15 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 16:01 Rory Sexton
2020-07-14 16:01 ` [dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power managing of idle cores Rory Sexton
2020-07-15 15:09 ` Pattan, Reshma
2020-07-14 16:02 ` [dpdk-dev] [v4 3/3] doc: update vm_power_manager cmdline options in doc Rory Sexton
2020-07-15 15:15 ` Pattan, Reshma
2020-07-17 12:31 ` Thomas Monjalon
2020-07-15 15:08 ` Pattan, Reshma [this message]
2020-07-17 12:40 ` [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core Thomas Monjalon
2020-07-20 10:26 ` Sexton, Rory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB12821AAE804D713E77C0718CFF7E0@BN6PR11MB1282.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=rory.sexton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).