From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A79EA0540; Tue, 14 Jul 2020 13:46:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37A5B1D607; Tue, 14 Jul 2020 13:46:07 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id EF24A1D521 for ; Tue, 14 Jul 2020 13:46:04 +0200 (CEST) IronPort-SDR: myLBKDAzFtqxwYSXtHrxMADvIWkXUkQEsQQOTfCSWltTnr/m0iQU4SureDAn5EatAkiWVvSQ99 0GHsWMYYg/ow== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="136330676" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="136330676" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 04:46:03 -0700 IronPort-SDR: GP5RonwQSiSLS1AjPTFzJL5OeHTrTHqCgoXOw13PMFVm6G6vVxL1mbJJsywG7Ww7o2eq5WJcT/ M0+QhYZKNJaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="317691522" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 14 Jul 2020 04:46:03 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jul 2020 04:46:03 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jul 2020 04:46:03 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.57) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jul 2020 04:46:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUWwAkc6UaiJCWhb31t9+KsXrHw68nz2lmB139p9d635iMHhLsjO0brp/ZGTXWfFkun+yLSPTHi86xQqlv46HfNOzc38aBOx7tBHVRBFLmyV7thaLOVwjhNkOr1PhEuwNGf7xjhXmIrPj0j1CIL8jBnp0j02kkfMBXQVvhCwFhlTrcfVTn1Yg4O4D41Q3dDUFzPQKJq+Me1Bvos5hxQpBptjt/N557p3UVjh43jxj+UClz3yrXl9AmollT0NQi0uRM1gHVurnUbHJ228O2kz6jM7tJUbDkgfqJXzg7x/IfbDHyDrUBhiyV1c945Net7bxjCTvw7KNbjs+WQOcm4p3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dduD/zMBW8slIx3MmkXXwefH/CXxFSNTXomRzhR1auY=; b=kWfAaq7xY3HER20porIwbELVWRsaWO5E5dZea+MT8WJvTUbOWUVf8vtWzfcLn1PJwXLlyRA/bIf1x7Z0gO9bIqiUN0GVm9H7drkSpCoPiHnQHg9/3WspWAxqZauk+JzW4X8mcpUMkf3e/gfWStW07FkopNQWmwJmllBzB+IbdDQM9jETGGGgHZfjXHt8NI5BbRGtn9Y/dbUIcfPO7RZ9QBmXUA1Wkpzxdb3Szy1GBf10WynljJsJH0jzqT5CqeTJqY29OAHW9V24QpwCM/S/HTULqxRAMMFibrmHAwsvox8U1NWxaOZNOACm59nwTyhMg7Ylp61rVv0kqXYDaxRrhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dduD/zMBW8slIx3MmkXXwefH/CXxFSNTXomRzhR1auY=; b=VCEv4GV3k68ce9G8dGPE0Np/8qxfxzHkTK4OormY8jbEGaqVC3DlHeDgDzUBaiTR+d6h472HNt6EaPEtfQrDa16+tgUPEufp65eFS6772OZ+cYQDRJNMTmyLNnSgdmM98si0QWjREuXvuiowZdrMIEy/Xs+fxp4t8yQ6QhHWR+o= Received: from BN6PR11MB1282.namprd11.prod.outlook.com (2603:10b6:404:4a::20) by BN6PR11MB1955.namprd11.prod.outlook.com (2603:10b6:404:100::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Tue, 14 Jul 2020 11:46:01 +0000 Received: from BN6PR11MB1282.namprd11.prod.outlook.com ([fe80::71e2:4d45:989c:a3bf]) by BN6PR11MB1282.namprd11.prod.outlook.com ([fe80::71e2:4d45:989c:a3bf%3]) with mapi id 15.20.3195.017; Tue, 14 Jul 2020 11:46:01 +0000 From: "Pattan, Reshma" To: Zhike Wang , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH v4] net/pcap: support snaplen option to truncate packet Thread-Index: AQHWWbiVglWZhCNWSEOGv3Jfw7hpqqkG9Ayg Date: Tue, 14 Jul 2020 11:46:00 +0000 Message-ID: References: <1593758842-6306-1-git-send-email-wangzhike@jd.com> <1594715212-29438-1-git-send-email-wangzhike@jd.com> In-Reply-To: <1594715212-29438-1-git-send-email-wangzhike@jd.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: jd.com; dkim=none (message not signed) header.d=none;jd.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.44.8.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c6cf9ac-80ed-44fe-54aa-08d827eb7b54 x-ms-traffictypediagnostic: BN6PR11MB1955: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iocWGBN8rbxofp/MGgSTQx5YKtRN1knTfR1QtUtQcQh+oEWLy9gwbhssdDqd/dHKuYNwkI9DxOEKqN9ACky6J5D+u106nenTEtKw3sS+0RvDYJwAoloeudnCwNlcoI4pwMLtwuxVSiUZPB3u6CM03/Cnnhce80uUAx8BHKljtaFNy5alJIFxp6xbtB/ldgjwncun8J11eZ7owNM7NVtaKsWyrt/mXsCl6JIShoJOV6oxIIaRZbAx0H0NgFU9lkqQkqDj7AooN3rg8goGXEnMfFoLEVPyCs2g2Fc2ZNig0uMqM5VxO71r8Sya5WjYowlVAKhyl1Un4YApHOHIOK7G4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1282.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(66476007)(4326008)(4744005)(83380400001)(76116006)(5660300002)(6506007)(52536014)(64756008)(66556008)(66446008)(110136005)(66946007)(316002)(71200400001)(9686003)(8676002)(55016002)(33656002)(2906002)(478600001)(7696005)(86362001)(107886003)(26005)(186003)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: CZiaZH7NSAcf+9WdO1/XupTKpgiwGuFOwoqz2mFGbwcr0bb+DlOS35JCOxluJ/y6OD0sBsB/rLAiJFGnLGb45FDym9pJoJZzK6aV1feBO2nvVXLY4WkOK0NJeNubyvISPTvIIrCi6BAsMTEczRDAQz0cl0OrUqx6ospyfgc3cM6WqLxVD54tkuGUBKKixsmFHH6jR97y+C44kWPlCrd1WT+tn6NdZtWyxccHeaqlA4FoE+K6j5SQmsWpU8xPS/Vb7uM/wTFOSZ3NdbRYTJM4fAglV3Ir5jz2pqKBCikXfThWNIROCRBEoeKTc+aMWNAUBoMyuognk5N0dAWtKin65tQAaoBQQc7AzokFikuFAxjEClImzhB/wrL2mpaGbUOc2z4sV1Vqyv4QpzM5FfBuXbVDNI4evAn4zWgNANmCYFpU+3GJtTxFgrt92LZOI5LN7ief4nJ+GwZ6c3kitOwEbBE5+3K2k/Bf6AqtPm2YrJU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1282.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c6cf9ac-80ed-44fe-54aa-08d827eb7b54 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 11:46:00.9338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bYbXsJDGcWE2ATcIPtEotxtCEoEoTFG8Hmi8sAgjilFXcFeSdXNIzM9bS6nIN+KjYIqpKpX9LRAWbJ+swv86/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1955 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: wangzk320@163.com On Behalf Of Zhike Wang > + "[snaplen=3Ddefault:0, meaning no > truncation]'\n", >From pdump changes, below are couple of comments. Bit more descriptive would be nice, how about, disables truncation of capt= ured packets.? > + if (cnt1 =3D=3D 1) { > + v.min =3D 1; Min should be 0. User still can pass 0 value. > + v.max =3D UINT16_MAX; Instead of allowing big max number, isn't it good to have some restricted = max value? Thanks, Reshma