From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C255A057B; Thu, 2 Apr 2020 11:12:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 804321BDAC; Thu, 2 Apr 2020 11:12:13 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4A7F12BCE for ; Thu, 2 Apr 2020 11:12:11 +0200 (CEST) IronPort-SDR: q2VrGhFhkRiYLY070Xr7SqtQUmceqJOISQV4Ko384Ma6tWDanVY7uMRJPJJBXBktPAQ3mwMPXc SOkYHJWp5Lxg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2020 02:12:10 -0700 IronPort-SDR: Py9HKoezPdqw1JfwSxYjHgX82CXce0IWbggQTBtSW1gw5T4+fwZ0qkT0yXNgldfweW9+ztALBN oZPzK4Bn4rlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,335,1580803200"; d="scan'208";a="284713015" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga002.fm.intel.com with ESMTP; 02 Apr 2020 02:12:10 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Apr 2020 02:12:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Apr 2020 02:12:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M6zz5bon9R0gxcRG//ZMIs0rTSGvas5SnGSCQyKqGrML+bEYyZdfQqih4MBtvlDkhoqONoVvIiG28Niu5yNEUKLYvN7AstdJ3rJpb/moL/Ysz3JE3rBA4HtuViZh51gsK8OdCRCaz34FnRhGtHdLnfy4u9ZUwwXsplfwoOwiSIBvW1NgPbrmlg53P/fuLiCA07jNfP3tpU0h82E0tSwJpKKnMC7NGnVcOWH2bTHV40rm/SCWSP6ODHpF/aZo+3s6M85Ma0ZXCapTW/nZNxhRFC1ZqhuZJ73UdMd+ABEvZCzeoyHTN7mO9jLpRjOqT0hMH7RiuBS66/SVfE7CrNe/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXYdu6MHLcf78syZxkjbyfwMj3DwEwQfKwASHtlIklU=; b=JPHryu6rEqwjKWMbq0bP9E7c7DTxagRtIcjbpsHIwyKIYx5/gVpmxYr7vw4OyotHSJQmyxBR0Nm75FQsGoRa99oV5JG53Jqey1utBQFildVssX1SY00853pyq1uajFbgbep7Y9Cl0XFee7thZePN+9SDlxu2VRgh6vV5jG8Ei7XqN8h3GgWfNNaTM+yC77QEYzxfgh78TF4UXraputJd/O1diNOQtJ+wwILgRk7lvEX5K15ilB8zbMkpkTjxvBS+z2wM3SbmboPOMsGSLoDUtn5TQAhk2m03XJBw4qXCjL73kt8RtXtLWnjNr6MpZfzQDdpMbuZ/ERK5MJrOpO0Ceg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXYdu6MHLcf78syZxkjbyfwMj3DwEwQfKwASHtlIklU=; b=feREkpAGNommyZEHGPZ1umFh6lRrMBWttruQ8CWf36P5L28Majkl6I9RPEY/N6xwaonmVeE/FK5rZUX5+8i1qSIiNXQw+2F5rk6RfGp4zSf1oVceP3QfQBYc4ez1xURQiWBRcI9C8il277AO23/uODrpYgMV+t/gVEndCbDdeSs= Received: from BN6PR11MB1473.namprd11.prod.outlook.com (2603:10b6:405:a::16) by BN6PR11MB4164.namprd11.prod.outlook.com (2603:10b6:405:82::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Thu, 2 Apr 2020 09:12:06 +0000 Received: from BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e]) by BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e%7]) with mapi id 15.20.2856.019; Thu, 2 Apr 2020 09:12:06 +0000 From: "Wang, Xiao W" To: Xiaojun Liu , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 5/5] net/fm10k: add switch management support Thread-Index: AQHV/oVXrdlpCcJaHUarHYxkOhrouqhlnVUQ Date: Thu, 2 Apr 2020 09:12:06 +0000 Message-ID: References: <1582879102-17977-6-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-1-git-send-email-xiaojun.liu@silicom.co.il> <1584687523-19362-6-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: <1584687523-19362-6-git-send-email-xiaojun.liu@silicom.co.il> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiao.w.wang@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 090c9c01-27d0-44ce-cf8e-08d7d6e5ea9f x-ms-traffictypediagnostic: BN6PR11MB4164: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0361212EA8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1473.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(366004)(66946007)(498600001)(81166006)(64756008)(6636002)(66556008)(33656002)(81156014)(8676002)(7696005)(66446008)(52536014)(71200400001)(86362001)(66476007)(9686003)(76116006)(5660300002)(2906002)(8936002)(53546011)(55016002)(6506007)(26005)(4326008)(110136005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1JMBAxJLgvPxrj1lXEIIRmSWVml0nKG/GJtBMzKRoTmvD8RdJPUm1l7w+OjU5O7Xv/8MmXyNOfVHtVRixjtzQoW/2hyl3IivMjU97O7YLucItBpHeAE+UsxdUzmUlE0hiBRGmypj7zBazGdPb5MrZUawu9IKaHGUtJO520a01cc0ddugNxzJ1BxazAN7KanZopsWoneGvaQIAunW8TQNTfz0id2i7t+DcJ91tHQRhCMERhJvUVJOYzDujVIERd2AGjTJ1ZdlxbIS7xEzsxeCjiyiS8clGiKDkW0iimp8oRZLXhRtQtfOsdXU5zoMPOPxZjQOk/vNSs7J7IU/QetlYLoGR8XSiNWysIdTZ7Jv6NRRoWnpyGQvJRGf7fSZCj8janhz50WXtKsk0YHXhPzULyopAOemw6AXAocUC0a4+vpLPO81cOxufVnHzwxPhAg3 x-ms-exchange-antispam-messagedata: zRROqdytFxjtwlAOeWrVEfPg+rPQ+bs1W24bgGVSP4qn2keRhppmjlq47PTK+RSTwVGOt3raR+yvAwL5R1g3HcXwBIpo5agazxSJEwc65/uv2uo+XXErZzHPx6T+/Sl2+bO6ijdqgpvYqX0ntlFHyw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 090c9c01-27d0-44ce-cf8e-08d7d6e5ea9f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2020 09:12:06.7631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gkYZHh8jq8S0DkuUgTxF4VR9UgA6jGV+Buid+T/7xLSYp8nLQbmMCIzmT3vgO+ncJP3cXVChYl0ih5qq49ur2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4164 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/fm10k: add switch management support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, This is a feature-add patch, so you need to add release note in doc/guides/= rel_notes/release_20_05.rst, that can be included as part of this 5/5 patch= . Another issue, why delete DEV_RX_OFFLOAD_RSS_HASH unconditionally? I think = it would impact the existing usage. @@ -1808,8 +2044,7 @@ static uint64_t fm10k_get_rx_port_offloads_capa(stru= ct rte_eth_dev *dev) DEV_RX_OFFLOAD_UDP_CKSUM | DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_JUMBO_FRAME | - DEV_RX_OFFLOAD_HEADER_SPLIT | - DEV_RX_OFFLOAD_RSS_HASH); + DEV_RX_OFFLOAD_HEADER_SPLIT); Also some comments on the feature description are inlined below. Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, March 20, 2020 2:59 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v3 5/5] net/fm10k: add switch management support >=20 > Split dev init to 2 parts. > First only register the port in switch > management; second init hook will be > called after all the pf are registered > and switch initialization. It will finish > dev init. Also add switch interrupt support. > Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset > to support mirror operation. Add fm10k_dev_filter_ctrl > to support flow operation. > Add dpdk port and pf mapping, so > the dpdk port can map to a specific pf > and 1 dpdk port can map to 2 pf to get > total 100G throughput. Update fm10k.rst. >=20 > Signed-off-by: Xiaojun Liu > --- > doc/guides/nics/fm10k.rst | 5 + > drivers/net/fm10k/fm10k_ethdev.c | 559 > ++++++++++++++++++++++++++++++++++++--- > 2 files changed, 525 insertions(+), 39 deletions(-) >=20 > diff --git a/doc/guides/nics/fm10k.rst b/doc/guides/nics/fm10k.rst > index 4e178c2..75f9929 100644 > --- a/doc/guides/nics/fm10k.rst > +++ b/doc/guides/nics/fm10k.rst > @@ -124,6 +124,11 @@ FM10000 PMD driver. The switch driver can be > acquired from Intel support. > Only Testpoint is validated with DPDK, the latest version that has been > validated with DPDK is 4.1.6. >=20 > +To avoid loading other switch driver from outside of DPDK, there is anot= her > +way to load switch driver in DPDK. If you want to use the inline switch = driver, "There is a way to load..." Since what you do is the only way to load switc= h driver inside DPDK. > +you need to set ''CONFIG_RTE_FM10K_SWITCH_MANAGEMENT=3Dy'' in the > configure file. Configuration file. > +The inline switch driver supports mirror and some flow forward rules. Please be clear on what forwarding rules are supported. Any doc reader will= be confused by "some". > + > Support for Switch Restart > ~~~~~~~~~~~~~~~~~~~~~~~~~~ [...]