From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E490FA0559; Mon, 16 Mar 2020 08:34:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19BF61C026; Mon, 16 Mar 2020 08:34:46 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BF85ACF3 for ; Mon, 16 Mar 2020 08:34:43 +0100 (CET) IronPort-SDR: UYlWd4oN2MQ4qvxRqeFSZFL5vk/L+rtCR1uCJkfN1uojuDo4Q6iSG1LwWO4tNVJsdXsrlPXagW zlaCsyOtCvEw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 00:34:42 -0700 IronPort-SDR: w/yKou+nlyTFqnWVAu7+bvLAZYNqa/u4WvM2m6JrI1XEl85XQELw6bcY6WM7hTCOnlwMG97rWD dErsIu7zMEjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,559,1574150400"; d="scan'208";a="237878917" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 16 Mar 2020 00:34:42 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 00:34:41 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 00:34:41 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 00:34:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QcVOCHgKyrkTvmBSWAv+331UALOFwc70EO9PXAjDk5vZaYQk7NfjjVeU+rC8VLF9319ONlZmLGK4YkTTsjcG68RuG9FAdY+r24QHdMajRb1aecvnqPgP16Xpsge9FCmgoZaWW+BsZuDXoN250yX8dKPn42cAjnCuLvGyTxth+ZhqQ1WA1/cdz9tclWEEKf7LE7Fxhkxh5Mkyd1RAncMBOpFX2CVIYKbnJqso4bo2vrLiY3Wa6mTXXKDB2XuNtvTYOJ9ob+yxBy42k8hfVhswhWUqCxZEtkE6L/Qbyimq+YO1V+DrXffTiRrYjvDv756Yra+d5mcX8ajG831HW9nEkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CvRiR1gSCP9xMk+zI+terZj43mxmudlqt3yRtcXgdDs=; b=mnm00CnvE++luU4qy9vVRj3zHCthbFgwgeDKO9HC2VhnuUvKeEWzsCrF20f8kY2oBBGZxTJclFJ9UJcjEWciKfhB0mHDPdIpzI8s5W1H0edTsXc5C69U2D6VFHzOiuuT2/eG/OGuSXXkCbkQlcAjA4u9NsHTF1kDvW1/9xXm6lFKOnMXeksFLjRTzXu5dLNpVp6+DmL4SJJFysEs85ATDQH3wIWxLM6Y4Sd/HmhQ91P/ab1bfXMt7BjBfOyY9zL1neTUo6HnJtEuvy12eflwnQWxNvM8DHe5Cw6FdqPWUKYmh0iOcmDYeOAiEPqPuMpuNzZbQuyvE+KSuJClWefJow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CvRiR1gSCP9xMk+zI+terZj43mxmudlqt3yRtcXgdDs=; b=FNUNdGikfU/4ae9XQe8to7s/v/rb80R6sjerKJa0Rf06pAK6tvtn/yOTZ/04nTCXBf4ankpT1W+1hwHBzyAJxQLL0jT5qUwHqFxvc71hI5jhv0R5Rbpf/blg9QYJrv00XGOkRiKE0I80Dez8goWZNF/eAu7T3UfJYqfCsT5DWn4= Received: from BN6PR11MB1473.namprd11.prod.outlook.com (2603:10b6:405:a::16) by BN6PR11MB0002.namprd11.prod.outlook.com (2603:10b6:405:62::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.15; Mon, 16 Mar 2020 07:34:39 +0000 Received: from BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e]) by BN6PR11MB1473.namprd11.prod.outlook.com ([fe80::d013:5d99:e57e:570e%7]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 07:34:39 +0000 From: "Wang, Xiao W" To: Xiaojun Liu , "Zhang, Qi Z" , "Kwan, Ngai-mint" , "Keller, Jacob E" CC: "dev@dpdk.org" Thread-Topic: [PATCH v1 5/5] net/fm10k: add switch management support Thread-Index: AQHV7hKf9xjbNT01nUC8+ImLM0tgRKhK61Jw Date: Mon, 16 Mar 2020 07:34:39 +0000 Message-ID: References: <1582207174-31037-2-git-send-email-xiaojun.liu@silicom.co.il> <1582879102-17977-1-git-send-email-xiaojun.liu@silicom.co.il> <1582879102-17977-6-git-send-email-xiaojun.liu@silicom.co.il> In-Reply-To: <1582879102-17977-6-git-send-email-xiaojun.liu@silicom.co.il> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=xiao.w.wang@intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e400bca5-6ed0-43da-5fa9-08d7c97c7c8b x-ms-traffictypediagnostic: BN6PR11MB0002: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 03449D5DD1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(396003)(376002)(136003)(366004)(39860400002)(199004)(6506007)(53546011)(52536014)(81166006)(86362001)(81156014)(4326008)(8676002)(9686003)(186003)(2906002)(7696005)(55016002)(26005)(8936002)(66446008)(33656002)(71200400001)(64756008)(66556008)(66946007)(5660300002)(66476007)(76116006)(478600001)(6636002)(316002)(110136005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR11MB0002; H:BN6PR11MB1473.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +MsRCoMuEExks3Uq4iZmYYYD8kvMjRTZ1oBzX4BIksPDAn4lno8GbLP0lnnc+Zy3xnEj4vOKPJccTkCvmjnClxWdwhJLfD9L9MVi70g+UUv668Y3v4AnRUNN7kjBYpzRaVVZkFAQmWYpiXCgu8D4gjXTHOHcnnQpnO1ljneZsA8BZVmKvEjA6uI8x6P669AAHkHh3twJpeDhb26un9yGgMoua/lukCGjVpgTBBQJFaV2lV82HjDnuHDgDoh25aCqGw8levI7kuqbOGYT8tQ/t16mV3GclLfcDbOUq7dnjzZvr664pdjK61yaV+8O3xxw4cp1ixzdkt44uTWzcorFZ/Tmyisrw9nPzgAjcg9MTSpxjypYdWvBs7hx+wVcKP0kb6BnVi13OFPIoGUofg9hIiDAEn0wpeNdpmG6z9X6D9z0SX3oklaAqcK/sJV6l8VG x-ms-exchange-antispam-messagedata: WjUF2zw7eBbbGCOk48BvM5izD+b+OpmQe99bXTg4SDr2ddWEztOSdaXdiSk+VhCOvxK8tnDSEoW5CqDAN4C3UielQSEayJO4ut1sDEf2IAS/k7NQN7ho8KGU3mXdoJqY8fa1t761gkavRYvrX8n90g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e400bca5-6ed0-43da-5fa9-08d7c97c7c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2020 07:34:39.7071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IzbXuMyo8fj/svusEkshrfVwVl26vF3XOJNhYAhMaV2QQNsYIheObLMU6C8yKmp1mLGHrCCt9N06S0e8ms0+Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0002 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 5/5] net/fm10k: add switch management support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiaojun, Best Regards, Xiao > -----Original Message----- > From: Xiaojun Liu > Sent: Friday, February 28, 2020 4:38 PM > To: Wang, Xiao W ; Zhang, Qi Z > ; Kwan, Ngai-mint ; Kelle= r, > Jacob E > Cc: dev@dpdk.org; Xiaojun Liu > Subject: [PATCH v1 5/5] net/fm10k: add switch management support >=20 > Split dev init to 2 parts. > First only register the port in switch > management; second init hook will be > called after all the pf are registered > and switch initialization. It will finish > dev init. Also add switch interrupt support. > Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset > to support mirror operation. Add fm10k_dev_filter_ctrl > to support flow operation. > Add dpdk port and pf mapping, so > the dpdk port can map to a specific pf > and 1 dpdk port can map to 2 pf to get > total 100G throughput. >=20 > To enable the switch management, you need add > CONFIG_RTE_FM10K_MANAGEMENT=3Dy in > config/common_linux when building. >=20 > Signed-off-by: Xiaojun Liu > --- > drivers/net/fm10k/base/fm10k_type.h | 1 + > drivers/net/fm10k/fm10k_ethdev.c | 562 > +++++++++++++++++++++++++++++--- > drivers/net/fm10k/switch/fm10k_switch.c | 20 +- > drivers/net/fm10k/switch/fm10k_switch.h | 1 + > 4 files changed, 541 insertions(+), 43 deletions(-) >=20 > diff --git a/drivers/net/fm10k/base/fm10k_type.h > b/drivers/net/fm10k/base/fm10k_type.h > index 84781ba..810e5ee 100644 > --- a/drivers/net/fm10k/base/fm10k_type.h > +++ b/drivers/net/fm10k/base/fm10k_type.h > @@ -717,6 +717,7 @@ struct fm10k_hw { > u16 subsystem_vendor_id; > u8 revision_id; > u32 flags; > + bool switch_ready; > #define FM10K_HW_FLAG_CLOCK_OWNER BIT(0) > }; >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 581c690..f11fa53 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -13,6 +13,10 @@ >=20 > #include "fm10k.h" > #include "base/fm10k_api.h" > +#ifdef RTE_FM10K_MANAGEMENT > +#include "switch/fm10k_regs.h" > +#include "switch/fm10k_switch.h" > +#endif >=20 > /* Default delay to acquire mailbox lock */ > #define FM10K_MBXLOCK_DELAY_US 20 > @@ -461,9 +465,6 @@ struct fm10k_xstats_name_off { >=20 > PMD_INIT_FUNC_TRACE(); >=20 > - if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) > - dev->data->dev_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_RSS_HASH; > - Why delete this? Will it break the existing usage? > /* multipe queue mode checking */ > ret =3D fm10k_check_mq_mode(dev); > if (ret !=3D 0) { [...]